Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp179515ybc;
        Mon, 18 Nov 2019 22:54:09 -0800 (PST)
X-Google-Smtp-Source: APXvYqwzUMt650aVaauenwHozfV9yeFviOOBYWqxcn1YsAjGldvH2DwS6UPPsZvFPD6ISgLQrI8q
X-Received: by 2002:a17:906:1c4d:: with SMTP id l13mr32348627ejg.308.1574146449041;
        Mon, 18 Nov 2019 22:54:09 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1574146449; cv=none;
        d=google.com; s=arc-20160816;
        b=oCOVwehyWkMHh6rGL1PAqSGII822d2lMg4lV1g2KEUf/vTi7s6Ox3F9Qig5Fi3CwNL
         0hMZzGoGSsy5beF7wqs4EmOq7Lqg9xHzRJluxuTV2J5YLaE3Qy5KtAHhZdYTFuzLtmas
         I1Sb1bFYl0cjmIHD7VxS7c7eiNrtsIquCTLRIsuaHPp59zhSApfnFX+GzlRX7J4PbcRD
         7EuDu+LqMnk8nDM2NNhuo/ANj4E8u6e6EDQGf+q3iUUIGTmWvzNoeVmWi4wTg+bS9pKO
         1BD0dEFaWmmecTLbkln6c+xKYKTngsrJUTfkwnW04RXNCjlUSjMFFZExA5nf4gn2zuzJ
         7H+g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:mime-version:references
         :in-reply-to:message-id:date:subject:cc:to:from;
        bh=2gZW9nYdzkXkyTc5bBk/WveG4zN9ZQjJdfxaExNTDSc=;
        b=F2AoEL6XhSj0JnPK3ivk2+s9ys03Ps6Yps8rAN7UPeHYSa3JzH3I+krw4r196RfNOo
         11ep+6N9e9h9OmMxO8UUdqP6aCRfkkAdXNOuD8EG64aDB4DzpjW6mTxByubtEvH9eRd9
         /TtNaRKQWv2WAtZ5A9OYRw5HWxX03aJoiEwgyfSy94MdOH6n87hv/5HkrUl7wcSDYlZE
         XuhDoXN8trGrB63F9/NG2TyAYaUflarfZ3/x3tbZreX9IyYCsuBEW16On38eIXdSy538
         eP6VrmO954CmgaZ+WZ9gXHNuSh99k2BPwc3RZii6u1eKp8webZPNx5wEJB09K9FNtdBD
         daBg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b="Cu/4rNAG";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id q17si16433608edc.6.2019.11.18.22.53.45;
        Mon, 18 Nov 2019 22:54:09 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b="Cu/4rNAG";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727837AbfKSGvN (ORCPT <rfc822;parkch98@gmail.com> + 99 others);
        Tue, 19 Nov 2019 01:51:13 -0500
Received: from hqemgate14.nvidia.com ([216.228.121.143]:10804 "EHLO
        hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727575AbfKSGvE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 19 Nov 2019 01:51:04 -0500
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5dd390da0001>; Mon, 18 Nov 2019 22:51:06 -0800
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Mon, 18 Nov 2019 22:51:03 -0800
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Mon, 18 Nov 2019 22:51:03 -0800
Received: from HQMAIL105.nvidia.com (172.20.187.12) by HQMAIL105.nvidia.com
 (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 19 Nov
 2019 06:51:03 +0000
Received: from hqnvemgw03.nvidia.com (10.124.88.68) by HQMAIL105.nvidia.com
 (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend
 Transport; Tue, 19 Nov 2019 06:51:03 +0000
Received: from skomatineni-linux.nvidia.com (Not Verified[10.2.175.254]) by hqnvemgw03.nvidia.com with Trustwave SEG (v7,5,8,10121)
        id <B5dd390d50002>; Mon, 18 Nov 2019 22:51:03 -0800
From:   Sowjanya Komatineni <skomatineni@nvidia.com>
To:     <skomatineni@nvidia.com>, <thierry.reding@gmail.com>,
        <jonathanh@nvidia.com>, <digetx@gmail.com>,
        <mperttunen@nvidia.com>, <gregkh@linuxfoundation.org>,
        <sboyd@kernel.org>, <tglx@linutronix.de>, <robh+dt@kernel.org>,
        <mark.rutland@arm.com>
CC:     <allison@lohutok.net>, <pdeschrijver@nvidia.com>,
        <pgaikwad@nvidia.com>, <mturquette@baylibre.com>,
        <horms+renesas@verge.net.au>, <Jisheng.Zhang@synaptics.com>,
        <krzk@kernel.org>, <arnd@arndb.de>, <spujar@nvidia.com>,
        <josephl@nvidia.com>, <vidyas@nvidia.com>,
        <daniel.lezcano@linaro.org>, <mmaddireddy@nvidia.com>,
        <markz@nvidia.com>, <devicetree@vger.kernel.org>,
        <linux-clk@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: [PATCH v1 08/17] clk: tegra: Use Tegra PMC helper function for PLLE IDDQ
Date:   Mon, 18 Nov 2019 22:50:25 -0800
Message-ID: <1574146234-3871-9-git-send-email-skomatineni@nvidia.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1574146234-3871-1-git-send-email-skomatineni@nvidia.com>
References: <1574146234-3871-1-git-send-email-skomatineni@nvidia.com>
X-NVConfidentiality: public
MIME-Version: 1.0
Content-Type: text/plain
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1574146266; bh=2gZW9nYdzkXkyTc5bBk/WveG4zN9ZQjJdfxaExNTDSc=;
        h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer:
         In-Reply-To:References:X-NVConfidentiality:MIME-Version:
         Content-Type;
        b=Cu/4rNAGo+PfmjejTL4sGQT42og6qZzdi+71bYE393qKBBvw5BM1AgpZebJgQ7V8E
         4kLCONQPkjhFLglkh0vaTwH3QJHpRnsYhajwuaf6/tgdGrw8aBZcA+gUoYCHTlU2Sj
         1ta5ylz4etZ5vy99B7h8JXxurplN3Ogp980hcZZrWx2OBkZfUVUSRhDYG0Oma+HHTf
         OItDek0dyABqpJgfeeTNhogM8oG+YzORXKCnOyvX+t4KtNI1d7ZhElI/Tw7fMApStu
         UjEakwhPrawPH5Ikli8RJhWcMlh1RkMOhSoKDoMNhv9pH6rSKi+W5vHPPXRD3YVwTJ
         QN7SbbzsGBemA==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Tegra PMC has PLLE IDDQ programming to bring the PLLE pads out of
DPD idle state through software by overriding the hardware control.

Currently Tegra clock driver programs Tegra PMC registers directly
for enabling software override and to bring PLLE pads out of DPD
idle state. With this, when Tegra PMC is in secure mode, any direct
PMC register access from non-secure world will not go through.

This patch updates Tegra clock driver to use Tegra PMC helper function
to clear PLLE IDDQ through software control that does PMC programming
using tegra_pmc_writel and tegra_pmc_readl which supports both secure
mode and non-secure mode PMC access.

Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
---
 drivers/clk/tegra/clk-pll.c | 19 +------------------
 1 file changed, 1 insertion(+), 18 deletions(-)

diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c
index f3c0a637174f..4ae9e282e7be 100644
--- a/drivers/clk/tegra/clk-pll.c
+++ b/drivers/clk/tegra/clk-pll.c
@@ -143,10 +143,6 @@
 #define PLLCX_MISC2_DEFAULT 0x30211200
 #define PLLCX_MISC3_DEFAULT 0x200
 
-#define PMC_SATA_PWRGT 0x1ac
-#define PMC_SATA_PWRGT_PLLE_IDDQ_VALUE BIT(5)
-#define PMC_SATA_PWRGT_PLLE_IDDQ_SWCTL BIT(4)
-
 #define PLLSS_MISC_KCP		0
 #define PLLSS_MISC_KVCO		0
 #define PLLSS_MISC_SETUP	0
@@ -863,24 +859,11 @@ static int clk_plle_training(struct tegra_clk_pll *pll)
 	u32 val;
 	unsigned long timeout;
 
-	if (!pll->pmc)
-		return -ENOSYS;
-
 	/*
 	 * PLLE is already disabled, and setup cleared;
 	 * create falling edge on PLLE IDDQ input.
 	 */
-	val = readl(pll->pmc + PMC_SATA_PWRGT);
-	val |= PMC_SATA_PWRGT_PLLE_IDDQ_VALUE;
-	writel(val, pll->pmc + PMC_SATA_PWRGT);
-
-	val = readl(pll->pmc + PMC_SATA_PWRGT);
-	val |= PMC_SATA_PWRGT_PLLE_IDDQ_SWCTL;
-	writel(val, pll->pmc + PMC_SATA_PWRGT);
-
-	val = readl(pll->pmc + PMC_SATA_PWRGT);
-	val &= ~PMC_SATA_PWRGT_PLLE_IDDQ_VALUE;
-	writel(val, pll->pmc + PMC_SATA_PWRGT);
+	tegra_pmc_clear_plle_iddq();
 
 	val = pll_readl_misc(pll);
 
-- 
2.7.4