Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Henry Lin <henryl@nvidia.com>
To:     Mathias Nyman <mathias.nyman@linux.intel.com>
CC:     "hch@infradead.org" <hch@infradead.org>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] usb: xhci: only set D3hot for pci device
Thread-Topic: [PATCH v2] usb: xhci: only set D3hot for pci device
Thread-Index: AQHVmcS7lHXr9UykNUiPUbt28T8id6eMWLWAgAXK/Uw=
Date:   Tue, 19 Nov 2019 07:46:09 +0000
Message-ID: <MN2PR12MB338999B37136F467C04F147FAC4C0@MN2PR12MB3389.namprd12.prod.outlook.com>
References: <20191112071831.1043-1-henryl@nvidia.com>
 <20191113014927.11915-1-henryl@nvidia.com>,<7aa0d839-57f8-54af-4b55-b3e605ae20cc@linux.intel.com>
In-Reply-To: <7aa0d839-57f8-54af-4b55-b3e605ae20cc@linux.intel.com>
Accept-Language: en-US, zh-TW
received-spf: None (protection.outlook.com: nvidia.com does not designate
 permitted sender hosts)
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ac2b2fe6-6868-42af-c36e-08d76cc48b1d
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Nov 2019 07:46:09.9008
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SQG6K6MiLmeKuyMWSlByDIUyJPSJf9S7FttUzIoJiK7+2AU/IMlLvhDHFrjiscK3lfUY6tigvIDGRayTmz2Biw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3119
X-OriginatorOrg: Nvidia.com
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1574149574; bh=5H0RmjhmDZEqAzHj76nXE65rznAHo2y1B6Tw1kcJ1SA=;
        h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature:
         ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:
         Thread-Index:Date:Message-ID:References:In-Reply-To:
         Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:
         authentication-results:x-originating-ip:x-ms-publictraffictype:
         x-ms-office365-filtering-correlation-id:x-ms-traffictypediagnostic:
         x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers:
         x-forefront-prvs:x-forefront-antispam-report:received-spf:
         x-ms-exchange-senderadcheck:x-microsoft-antispam:
         x-microsoft-antispam-message-info:x-ms-exchange-transport-forked:
         MIME-Version:X-MS-Exchange-CrossTenant-Network-Message-Id:
         X-MS-Exchange-CrossTenant-originalarrivaltime:
         X-MS-Exchange-CrossTenant-fromentityheader:
         X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:
         X-MS-Exchange-CrossTenant-userprincipalname:
         X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg:
         Content-Language:Content-Type:Content-Transfer-Encoding;
        b=I8CXyUdjyycJbRSFOgMLgh4R6vd3LqoAR2oEzhlr+WsB7hjCPr1WTMCDfzJZYMtrZ
         UjExEgpHJAkWWROG93IyPqdEpxz/klGb12D0qkjAm3y/dHQrcjM/0jpzWfvmkbRIT2
         lb4y1fe/MuTJokarkHXxFvfcrtvQnL400XEXwQD4y/YBUiNUJFMHh6KbdOFtpNSGFk
         3NzSFDzix0f7MjdUYNxfjTJjy3IJ7wIkTU/f2kPbo81EZPV4b0mJGnND2kkm831bls
         AHDABbeJc8qFYR1YtWFb+nd2mw94leZD3fgJReS0Bwq6NmfAMii5ivm8uQJY88HfKg
         IqC4CSPKD1/Rw==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> The XHCI_SPURIOUS_WAKEUP quirk both resets the controller at shutdown=0A=
> and sets it to PCI D3 at remove/shutdown.=0A=
=0A=
> Is it so that the NVIDIA Tegra xHC just needs to be reset at shutdown?=0A=
> The quirk is not set for Tegra xHC in current mainline kernel.=0A=
Some versions of NVIDIA Tegra xHC support VF on virtualization environment.=
 In that case, they need reset at shutdown. For now, Tegra xHC's VF support=
 has not been submitted to mainline kernel.=0A=
=0A=
> Agree that we shouldn't call PCI specific functions in the generic shutdo=
wn code.=0A=
> Would be better if we could move the PCI parts to xhci-pci.c or hcd-pci.c=
=0A=
=0A=
> Maybe we need to add a xhci_pci_shutdown() function for the xhci pci driv=
er=0A=
> that could take care of the pci related shutdown quirks before calling=0A=
> usb_hcd_pci_shutdown(), and call that instead of directly calling=0A=
> usb_hcd_pci_shutdown().=0A=
To keep original code sequence, I implemented this in a similar way to set =
xhci_pci_shutdown() as hc_driver.shutdown(). In xhci_pci_shutdown(), it cal=
ls xhci_shutdown() first and then does XHCI_SPURIOUS_WAKEUP quirk. Will pos=
t it as v3 patch.=