Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Namjae Jeon" <namjae.jeon@samsung.com>
To:     "'Daniel Wagner'" <dwagner@suse.de>
Cc:     <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
        <gregkh@linuxfoundation.org>, <valdis.kletnieks@vt.edu>,
        <hch@lst.de>, <linkinjeon@gmail.com>, <Markus.Elfring@web.de>,
        <sj1557.seo@samsung.com>
In-Reply-To: <20191119085639.kr4esp72dix4lvok@beryllium.lan>
Subject: RE: [PATCH v2 02/13] exfat: add super block operations
Date:   Tue, 19 Nov 2019 18:22:28 +0900
Message-ID: <00d101d59eba$dcc373c0$964a5b40$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQEo1XJlLzywHhHshRBLsQkFEP9+bwICkZlvAboM/rECPrXdMKi77zBA
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20191119071107.1947-1-namjae.jeon@samsung.com>
        <CGME20191119071403epcas1p3f3d69faad57984fa3d079cf18f0a46dc@epcas1p3.samsung.com>
        <20191119071107.1947-3-namjae.jeon@samsung.com>
        <20191119085639.kr4esp72dix4lvok@beryllium.lan>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> Hi,
Hi,
> 
> On Tue, Nov 19, 2019 at 02:10:56AM -0500, Namjae Jeon wrote:
> > +static void exfat_put_super(struct super_block *sb)
> > +{
> > +	struct exfat_sb_info *sbi = EXFAT_SB(sb);
> > +
> > +	mutex_lock(&sbi->s_lock);
> > +	if (READ_ONCE(sbi->s_dirt)) {
> > +		WRITE_ONCE(sbi->s_dirt, true);
> 
> No idea what the code does. But I was just skimming over and find the
> above pattern somehow strange. Shouldn't this be something like
Right.

> 
> 	if (!READ_ONCE(sbi->s_dirt)) {
> 		WRITE_ONCE(sbi->s_dirt, true);

It should be :
	if (READ_ONCE(sbi->s_dirt)) {
 		WRITE_ONCE(sbi->s_dirt, false);
I will fix it on v3.
Thanks for review!
> 
> ?
> 
> Thanks,
> Daniel