Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932234AbWAPHof (ORCPT ); Mon, 16 Jan 2006 02:44:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932237AbWAPHof (ORCPT ); Mon, 16 Jan 2006 02:44:35 -0500 Received: from smtp206.mail.sc5.yahoo.com ([216.136.129.96]:46704 "HELO smtp206.mail.sc5.yahoo.com") by vger.kernel.org with SMTP id S932234AbWAPHof (ORCPT ); Mon, 16 Jan 2006 02:44:35 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com.au; h=Received:Message-ID:Date:From:User-Agent:X-Accept-Language:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=3s+XHCSwwsYOU3xnwaPSBUnE4YRYtw/Xnr/z182GkXkCStBvJB5hQUm1jbEpaa1XSCJYqpRtT3VxoEi9tnhsUFmoJ7RnVa6py8r5/ljDYZdn3Cg4yC6voTDHJns+i6rSnziG0UeV9W63CN//tEj7rgCn7IEqf5hTKZMm4F1SpUw= ; Message-ID: <43CB4EDA.6070803@yahoo.com.au> Date: Mon, 16 Jan 2006 18:44:26 +1100 From: Nick Piggin User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20051007 Debian/1.7.12-1 X-Accept-Language: en MIME-Version: 1.0 To: Christoph Lameter CC: Magnus Damm , Nick Piggin , Andrew Morton , Linux Kernel Mailing List , Linux Memory Management List Subject: Re: Race in new page migration code? References: <20060114155517.GA30543@wotan.suse.de> <20060114181949.GA27382@wotan.suse.de> <43C9DD98.5000506@yahoo.com.au> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1093 Lines: 30 Christoph Lameter wrote: > On Sun, 15 Jan 2006, Nick Piggin wrote: > > >>OK (either way is fine), but you should still drop the __isolate_lru_page >>nonsense and revert it like my patch does. > > > Ok with me. Magnus: You needed the __isolate_lru_page for some other > purpose. Is that still the case? > Either way, we can remove it from the tree for now. But I'm almost sure such a user would be wrong too. The reason it is required is very specific and it is because taking lru_lock and then looking up a page on the LRU uniquely does not pin the page. If you find the page via any other means other than simply looking on the LRU, then get_page_testone is wrong and you should either pin it or take a normal reference to it instead. -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/