Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 11.1 \(3445.4.7\))
Subject: Re: [PATCH] KVM: nVMX: add CR4_LA57 bit to nested CR4_FIXED1
From:   Liran Alon <liran.alon@oracle.com>
In-Reply-To: <20191119083359.15319-1-chenyi.qiang@intel.com>
Date:   Tue, 19 Nov 2019 13:09:21 +0200
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        =?utf-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        Xiaoyao Li <xiaoyao.li@intel.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <348B5C47-7AA0-4DAC-91A7-8FB0D0205EF6@oracle.com>
References: <20191119083359.15319-1-chenyi.qiang@intel.com>
To:     Chenyi Qiang <chenyi.qiang@intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On 19 Nov 2019, at 10:33, Chenyi Qiang <chenyi.qiang@intel.com> wrote:
>=20
> When L1 guest uses 5-level paging, it fails vm-entry to L2 due to
> invalid host-state. It needs to add CR4_LA57 bit to nested CR4_FIXED1
> MSR.
>=20
> Signed-off-by: Chenyi Qiang <chenyi.qiang@intel.com>
> Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com>

Reviewed-by: Liran Alon <liran.alon@oracle.com>

> ---
> arch/x86/kvm/vmx/vmx.c | 1 +
> 1 file changed, 1 insertion(+)
>=20
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index 621142e55e28..89253d60e23a 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -6962,6 +6962,7 @@ static void =
nested_vmx_cr_fixed1_bits_update(struct kvm_vcpu *vcpu)
> 	cr4_fixed1_update(X86_CR4_SMAP,       ebx, =
bit(X86_FEATURE_SMAP));
> 	cr4_fixed1_update(X86_CR4_PKE,        ecx, =
bit(X86_FEATURE_PKU));
> 	cr4_fixed1_update(X86_CR4_UMIP,       ecx, =
bit(X86_FEATURE_UMIP));
> +	cr4_fixed1_update(X86_CR4_LA57,       ecx, =
bit(X86_FEATURE_LA57));
>=20
> #undef cr4_fixed1_update
> }
> --=20
> 2.17.1
>=20