Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp487353ybc; Tue, 19 Nov 2019 04:39:20 -0800 (PST) X-Google-Smtp-Source: APXvYqxBdRtwuvK9KDiOc9rZa6/o0iB4WHH/QQHTstYxqM78NP3rh6GmGXz3EDD/yIY9g40w60OH X-Received: by 2002:a17:906:f119:: with SMTP id gv25mr4477063ejb.164.1574167160436; Tue, 19 Nov 2019 04:39:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574167160; cv=none; d=google.com; s=arc-20160816; b=QlDNw/pxT5nB8qv2unD18GnBouSf9Qc+iqkNsi1IKmxEeWFG/OyOJoeyYrDh7jzl2E hHRtGnUF9VH9NOwSnMwCAlak3s+UXzqHnyu++/zoHKzYO101gi030hpEDYB6785thqhJ zCdwmyn4vCABVlbJklmybM/8kC85MwuJcUgt2WvlcyYwc1F6aeBLb53B3fCl88gsY4yv GUcY8CYNvYOAfBNdZGjuw5T4Yo5QeZ93Fk8dErFsxDfbHBSsMdPesiNf+Acme/GJv6pW 0VkXhqOarHAOtqGJRau4Rct8qCCGbmRlGkPR04QkPdwuZaxVGNtd/VARuruhXqtobPff VkZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=R8+SvhnJa558I8SO2dyKnyaZy1B9crNn4LmnjwaP64I=; b=G1ylv9ryY/171epo8lAa5NPI/P5mMVdbCXylM50UketJ6WmjCIwCVw6lTpiB+Gojo0 0PkoquHeT4TEJEOOQX1tsFh6YIv7lW9gTccNTqj3R3uSkMnbjf3cb50rPNLbaEesRHt4 V61aUL07/UW2+0XPf/TKf/XvdZ9tFl2d2012xi+a6pJP6THDOQBpG22Jn4SLleDkbKcS el5sCUz37iN0B7gwHxHlaxcWzd+CHLtKwve6703+MFTUxJfH5zllz4vj+HBQODKGr+6D F4Fz3rHx3tUaYXlgzsOXK2Y26LzSNTbp9MlS/dQ5719l9l6g5ahQeHawv//HnLRghZIu 214A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wcWxtO1U; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k11si13595415ejv.152.2019.11.19.04.38.56; Tue, 19 Nov 2019 04:39:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wcWxtO1U; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727809AbfKSMh1 (ORCPT + 99 others); Tue, 19 Nov 2019 07:37:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:59634 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725798AbfKSMh1 (ORCPT ); Tue, 19 Nov 2019 07:37:27 -0500 Received: from localhost (unknown [89.205.136.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57AF520637; Tue, 19 Nov 2019 12:37:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574167047; bh=3SRua9bveRcBMHy6i6cnairtbSKL6I4YXWTgid0PSbs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wcWxtO1UIJsEb7vUeKZ11Y2RojlhWJy92BhE1liCnm/IEF8SOuHo7tfRWVDQtxSRf hWj8IZcuYBMpOoywVRojsLQTnGQXuLn7IiHHvcseFp2LkvCXXd6Wlau0vqAuhFbBs0 PDdXsu7JkP9kRaXyBI6lzuxKm6bfixKJgSTBZW9I= Date: Tue, 19 Nov 2019 13:37:24 +0100 From: Greg KH To: rui_feng@realsil.com.cn Cc: arnd@arndb.de, dan.carpenter@oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] misc: rtsx: Fix impossible condition Message-ID: <20191119123724.GA1975017@kroah.com> References: <1574151990-3335-1-git-send-email-rui_feng@realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1574151990-3335-1-git-send-email-rui_feng@realsil.com.cn> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 19, 2019 at 04:26:30PM +0800, rui_feng@realsil.com.cn wrote: > From: Rui Feng > > A u8 can only go up to 255, condition n > 396 is > impossible, so change u8 to u16. > > Signed-off-by: Rui Feng > --- > drivers/misc/cardreader/rts5261.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) What changed from v1? Always put that below the --- line as the documentation asks you to. Please fix up and send a v3. thanks, greg k-h