Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191114051242.14651-1-helen.koike@collabora.com>
 <20191114051242.14651-3-helen.koike@collabora.com> <09d4f683-d03d-46c9-e9d2-b8cceb72446e@xs4all.nl>
 <9cb116f6-64f4-1510-b128-8657d6d4889b@collabora.com> <CAFLEztRQfYE_Mssiq4KxK-QyJEe+KT4eTsvnLZQK5T=uVADUqA@mail.gmail.com>
 <4135d35cd581b31d08b547852ac43e959957abf5.camel@collabora.com>
In-Reply-To: <4135d35cd581b31d08b547852ac43e959957abf5.camel@collabora.com>
From:   Tomasz Figa <tfiga@chromium.org>
Date:   Tue, 19 Nov 2019 22:03:59 +0900
Message-ID: <CAAFQd5BPwSnY51vJboCB6Hr2Yz4jMqt4VWLNNLTpiwenGo_Wew@mail.gmail.com>
Subject: Re: [PATCH v11 02/11] media: staging: rkisp1: add document for rkisp1
 meta buffer format
To:     Ezequiel Garcia <ezequiel@collabora.com>
Cc:     Jacob Chen <jacobchen110@gmail.com>,
        Helen Koike <helen.koike@collabora.com>,
        Hans Verkuil <hverkuil@xs4all.nl>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        Mark Rutland <mark.rutland@arm.com>,
        linux-devicetree <devicetree@vger.kernel.org>,
        Eddie Cai <eddie.cai.linux@gmail.com>, kernel@collabora.com,
        Heiko Stuebner <heiko@sntech.de>,
        Jacob Chen <jacob-chen@rock-chips.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        Jeffy Chen <jeffy.chen@rock-chips.com>,
        =?UTF-8?B?6ZKf5Lul5bSH?= <zyc@rock-chips.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Hans Verkuil <hans.verkuil@cisco.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Shunqian Zheng <zhengsq@rock-chips.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        "list@263.net:IOMMU DRIVERS <iommu@lists.linux-foundation.org>, Joerg
        Roedel <joro@8bytes.org>," <linux-arm-kernel@lists.infradead.org>,
        Linux Media Mailing List <linux-media@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Nov 19, 2019 at 9:56 PM Ezequiel Garcia <ezequiel@collabora.com> wr=
ote:
>
> Hello Jacob,
>
> Thanks for the insight.
>
> On Tue, 2019-11-19 at 18:16 +0800, Jacob Chen wrote:
> > Hi Helen ,
> >
> > Helen Koike <helen.koike@collabora.com> =E4=BA=8E2019=E5=B9=B411=E6=9C=
=8814=E6=97=A5=E5=91=A8=E5=9B=9B =E4=B8=8B=E5=8D=886:59=E5=86=99=E9=81=93=
=EF=BC=9A
> > >
> > >
> > > On 11/14/19 6:21 AM, Hans Verkuil wrote:
> > > > On 11/14/19 6:12 AM, Helen Koike wrote:
> > > > > From: Jacob Chen <jacob2.chen@rock-chips.com>
> > > > >
> > > > > This commit add document for rkisp1 meta buffer format
> > > > >
> > > > > Signed-off-by: Jacob Chen <jacob-chen@rock-chips.com>
> > > > > [refactored for upstream]
> > > > > Signed-off-by: Helen Koike <helen.koike@collabora.com>
> > > >
> > > > checkpatch gives me:
> > > >
> > > > WARNING: Missing Signed-off-by: line by nominal patch author 'Jacob=
 Chen <jacob2.chen@rock-chips.com>'
> > > >
> > > > Looking at this series I see duplicate Signed-off-by entries for Ja=
cob Chen and a total
> > > > of three different email addresses:
> > > >
> > > > jacob2.chen@rock-chips.com
> > > > jacob-chen@rock-chips.com
> > > > cc@rock-chips.com
> > >
> > > And I see a name in the Maintainers file as Jacob Chen <jacob-chen@io=
twrt.com>.
> > > I was wondering if I could replace the email by jacob-chen@iotwrt.com=
, or if I should
> > > keep the original ones.
> > >
> > > Helen
> > >
> >
> > "jacob2.chen@rock-chips.com"/"jacob-chen@rock-chips.com" is me and
> > "cc@rock-chips.com" is another one.
> > ' jacob-chen@rock-chips.com' is invalid now,  so you could replace the
> > email by 'jacob-chen@iotwrt.com'.
> >
>
> Authorship and SOB can't be changed freely, the original must be retained=
,
> because this gives proper credit to the company that sponsored the work.
>
> I.e. if your mail used to be jacob2.chen at rock-chips.com, then I think
> we can use that. And if cc at rock-chips.com is a different engineer,
> also named Jacob Chen, perhaps we can mention that somewhere to reduce th=
e
> confusion.

Some patches have been developed by Jacob <jacob2.chen at
rock-chips.com>, some by Jacob <cc at rock-chips.com> and some by
both.

Some patches have been also re-posted by Jacob after leaving Rockchip
AFAIR, from the <jacob-chen at iotwrt.com> address. Those should have
<jacob2.chen at rock-chips.com> as From: and include sign-offs from
both <jacob2.chen at rock-chips.com> and <jacob-chen at iotwrt.com>.

So the conclusion is that the original sign-offs should be retained
+/- typos fixed.

For typos, was <jacob-chen at rock-chips.com> a typo of <jacob2.chen
at rock-chips.com> or a typo of <jacob-chen at iotwrt.com>?

Best regards,
Tomasz