Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp690932ybc; Tue, 19 Nov 2019 07:45:51 -0800 (PST) X-Google-Smtp-Source: APXvYqxucYjBKW78ObhPmAilmm5Je7JFMkgNOq2Z5ndgcMYQlEIk3xFayx5MAA/lWFC4aj+Hku0u X-Received: by 2002:a17:906:48b:: with SMTP id f11mr35607161eja.225.1574178350985; Tue, 19 Nov 2019 07:45:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574178350; cv=none; d=google.com; s=arc-20160816; b=qbmDrOizbznBJwnc9C8TmKDxWq9jncHuGfYmZgYCWF6wWDNHmApQ1WR5pMP5gJWNU9 VjFczZBkMz/SKUfRqPzaalg3Z5ZNN5I7E1l5ABfkeXxOHDrbFqAoydCuGAo9fWrCA6z9 UzIMZpSv6d41k1gIP+TiWgZvp1E5rpW8vZuDZRFVB2xH/IX/MOoz7ZgCLmRJpM3c/oih ZeKeMCJA3kuiTWcqt1pZ5WyhyBAKGoQj7KquXE/ytdRjGm6o9XjP2IVo7KVb7c3ER89D zX6oKO5nhEJ7hBTmdO4bpMmEql1W4QOiqKMDeqArepXXFkjFVgH+4H+6n3mOfZwTV+dC bIYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=nWs/1bjDvNuzUJtmMQammwiguABeAIM4rx8Ev82Odj4=; b=TayFbOdVBbt7b5NtuDypADgMLmEr93MKbOePLZkMO+0hIqU6977Y7nB1WL6HoIUdkh NKtTyA2wqSW3s01T7UQ1HizkSBQdfOv9ek3zBfQPan8xqtOXZo3cS4XDHM0lHAQZK4P1 ujVBk8yVT5TyQtNLAzVb5U1av8yZlGdeQriyv/VSy6Wn4RQLlQv4fpPv2L6c1lnUevV0 0g3qQYTKoieyCibLYQeTDVjf2Ve7EJhUweE187f06xfq0QCBsxb2Z6KaFbYv9G4H16BC Uy3YYlUzgy7BnhdjA8VWWQwfL+6ALZmlSfH3ECyW6cpnqI7NMxdJinWzrk6MkI/Z1opI EgIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=us8sMchD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l20si14566395ejx.389.2019.11.19.07.45.27; Tue, 19 Nov 2019 07:45:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=us8sMchD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727949AbfKSPmW (ORCPT + 99 others); Tue, 19 Nov 2019 10:42:22 -0500 Received: from mail-qk1-f194.google.com ([209.85.222.194]:34362 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727682AbfKSPmW (ORCPT ); Tue, 19 Nov 2019 10:42:22 -0500 Received: by mail-qk1-f194.google.com with SMTP id 205so18218228qkk.1 for ; Tue, 19 Nov 2019 07:42:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=nWs/1bjDvNuzUJtmMQammwiguABeAIM4rx8Ev82Odj4=; b=us8sMchDRqbzZLY+8PM7/pe8WsLDZaohdyGl7R3EeSoWSvgvizJcLMF0BSaCEqsdy4 NSYDM17Ete2jESTbIDna9vtA0dUXsmg6bBXQOCH48RDKNzLBxQ6mlp7dlkil/PAQ5hl4 kxrZ3bqxv5B9F8bKvIHUq5QUdUopVtt0xgGF3OfR4oa410peA1MSURbcEDbJvRagtXXW +SqQC2r8fKOXJEA7CxMEGgKlIO7ejUpU40J+VxnUNJ6vEHK8//vMrnAp2qoHjQxavaiI vz7OWx7ODCOY89S+kEdO/+LJrWWnNLTcSyv0Maq4YAOgtfhCfquKCCUXG3oySb+mCvBb 38tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=nWs/1bjDvNuzUJtmMQammwiguABeAIM4rx8Ev82Odj4=; b=MkmElEoeV/r2P6toq5wCa+7090xixOyfg63d6ybpuYuDjrrzjwS5RdFmtCUseXH1wC DxRHiRIDbNYbjZvP08yGGtqX81aB/2eyLIlm0LOwtpnvwNZM0oA/hsDmJeDzRTx9VRuJ D1/x5alC6Xm43xYB/vY/s+0ut6uzdsAkA0ee/rl7t3pia7Wpvo+396HGeYfPrzR1tlOm MGzTfoFItBTL1SqZKCdlLQRpFUp40rEVkI2XhiY3bRQJvu+jOqlTRSAOg5R1v6fO2B7J Auy4Of2FL6jtMmdFQziCUzfsdNDb9l+PzKbOC7tKw0dsFXGALwmXsiVgArSKcMBNaGB6 SV/g== X-Gm-Message-State: APjAAAXtvsppph2f/73ttl4FrejJisEy3wy0Ava37cOgsPFeXF9jygu/ orZKeI52HbZUjpBLt3A1FlLwRA== X-Received: by 2002:a05:620a:13c4:: with SMTP id g4mr30230662qkl.391.1574178139850; Tue, 19 Nov 2019 07:42:19 -0800 (PST) Received: from localhost ([2620:10d:c091:500::c7ac]) by smtp.gmail.com with ESMTPSA id i17sm7188612qtm.53.2019.11.19.07.42.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2019 07:42:19 -0800 (PST) Date: Tue, 19 Nov 2019 10:42:17 -0500 From: Johannes Weiner To: Alex Shi Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, shakeelb@google.com Subject: Re: [PATCH v4 2/9] mm/huge_memory: fix uninitialized compiler warning Message-ID: <20191119154217.GC382712@cmpxchg.org> References: <1574166203-151975-1-git-send-email-alex.shi@linux.alibaba.com> <1574166203-151975-3-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1574166203-151975-3-git-send-email-alex.shi@linux.alibaba.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 19, 2019 at 08:23:16PM +0800, Alex Shi wrote: > ../mm/huge_memory.c: In function ‘split_huge_page_to_list’: > ../mm/huge_memory.c:2766:9: warning: ‘flags’ may be used uninitialized > in this function [-Wmaybe-uninitialized] > lruvec = lock_page_lruvec_irqsave(head, pgdata, flags); > ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Like with the previous patch, there is no lock_page_lruvec_irqsave() at this point in the series.