Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [v2] nbd:fix memory leak in nbd_get_socket()
To:     Sun Ke <sunke32@huawei.com>, josef@toxicpanda.com, axboe@kernel.dk,
        linux-block@vger.kernel.org, nbd@other.debian.org,
        linux-kernel@vger.kernel.org
References: <1574143751-138680-1-git-send-email-sunke32@huawei.com>
Cc:     stable@vger.kernel.org
From:   Mike Christie <mchristi@redhat.com>
Message-ID: <5DD416DB.1040302@redhat.com>
Date:   Tue, 19 Nov 2019 10:22:51 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <1574143751-138680-1-git-send-email-sunke32@huawei.com>
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/19/2019 12:09 AM, Sun Ke wrote:
> Before return NULL,put the sock first.
>=20
> Cc: stable@vger.kernel.org
> Fixes: cf1b2326b734 ("nbd: verify socket is supported during setup")
> Signed-off-by: Sun Ke <sunke32@huawei.com>
> ---
> v2: add cc:stable tag
> ---
>  drivers/block/nbd.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
> index a94ee45..19e7599 100644
> --- a/drivers/block/nbd.c
> +++ b/drivers/block/nbd.c
> @@ -993,6 +993,7 @@ static struct socket *nbd_get_socket(struct nbd_devic=
e *nbd, unsigned long fd,
>  =09if (sock->ops->shutdown =3D=3D sock_no_shutdown) {
>  =09=09dev_err(disk_to_dev(nbd->disk), "Unsupported socket: shutdown call=
out must be supported.\n");
>  =09=09*err =3D -EINVAL;
> +=09=09sockfd_put(sock);
>  =09=09return NULL;
>  =09}
> =20
>=20

Reviewed-by: Mike Christie <mchristi@redhat.com>