Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp745263ybc; Tue, 19 Nov 2019 08:34:58 -0800 (PST) X-Google-Smtp-Source: APXvYqyLftvmwpCDkhCh3rYiGHzz8JAJp9mY4foYi6w+SarqeNah8QcLxAcA4bKnNAm1lHm06gXM X-Received: by 2002:a5d:65c4:: with SMTP id e4mr23851772wrw.269.1574181298082; Tue, 19 Nov 2019 08:34:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574181298; cv=none; d=google.com; s=arc-20160816; b=L3HNr32EL8oAAAGUwf+sBjBBnwT4Ch42sN6G5p0dskzo0ot3qGvkuU4wMlK6AJbWqH NH2Fjuy1uRefZPRcMJf7/KipLNritXJfZ4KTFZyIZR81lCH8Tsgpqo36j8h5Htm1fQJT zX5uoqkreE8H8Bc7nEn9Nc169AS5WtmBNB98SiDaAAos7s8/+wPyUnSz3Oi3XBy3x23l aD1lP60/gPm7405n45Ze1wPJjPCs5W7I4juIiWGaM3ylYhrH+MXJO/h5k+gXQqg4UCKD BzM7UOysboioknmdvA5CcGSNSqelzLG863N9sCEFPRmo7sLgtOaM7m/QMJ1pnGu0uWbb 6G5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=/iMDL5VyFoPjrhEt8lCc0V98Qi1awJhWQ2UKeZBXGdg=; b=h3bALUgND4YUsn/UOJ9jKurs6cRDm9AHCPwyIt3mW2pXXlMN9DZrnKIr9pSK/XuInk vhbbGvrkxAJr6rnSgPgF0GZp7IqcpRFKa4RxXPbt2vSc71kr9rPI1GGoK1cAa4GUhvQW wwgr8RXDxvUe0Uqh/wU0rq6dXeEPqBDHF1XYEmtzROusLvsRYc6nugexh8622/FGtuE4 bi/yXxFuCI6x0bX9D2edOQgpnUz3lHq0eeOU4tgj72yGEPjhD4Akct3b5WnuZ03r4q2T etIhe60YZltECwqPKShXF8ugALtrVeQqow1sEdvy1EkvAKsBsFGserDT55hz6HNN/A1q 3YnQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s38si15154347edd.351.2019.11.19.08.34.31; Tue, 19 Nov 2019 08:34:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728547AbfKSQcn (ORCPT + 99 others); Tue, 19 Nov 2019 11:32:43 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:11791 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728433AbfKSQcn (ORCPT ); Tue, 19 Nov 2019 11:32:43 -0500 X-IronPort-AV: E=Sophos;i="5.69,218,1571695200"; d="scan'208";a="327283104" Received: from palace.lip6.fr ([132.227.105.202]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES128-SHA256; 19 Nov 2019 17:32:39 +0100 From: Julia Lawall To: Masahiro Yamada , Jani Nikula Cc: kernel-janitors@vger.kernel.org, Gilles Muller , Nicolas Palix , Michal Marek , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: [PATCH] Coccinelle: ptr_ret: drop PTR_ERR_OR_ZERO semantic patch Date: Tue, 19 Nov 2019 16:56:57 +0100 Message-Id: <1574179017-23787-1-git-send-email-Julia.Lawall@lip6.fr> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This mostly made changes that made the code harder to read, so drop it. Signed-off-by: Julia Lawall --- scripts/coccinelle/api/ptr_ret.cocci | 97 ----------------------------------- 1 file changed, 97 deletions(-) diff --git a/scripts/coccinelle/api/ptr_ret.cocci b/scripts/coccinelle/api/ptr_ret.cocci deleted file mode 100644 index e76cd5d..0000000 --- a/scripts/coccinelle/api/ptr_ret.cocci +++ /dev/null @@ -1,97 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0-only -/// -/// Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR -/// -// Confidence: High -// Copyright: (C) 2012 Julia Lawall, INRIA/LIP6. -// Copyright: (C) 2012 Gilles Muller, INRIA/LiP6. -// URL: http://coccinelle.lip6.fr/ -// Options: --no-includes --include-headers -// -// Keywords: ERR_PTR, PTR_ERR, PTR_ERR_OR_ZERO -// Version min: 2.6.39 -// - -virtual context -virtual patch -virtual org -virtual report - -@depends on patch@ -expression ptr; -@@ - -- if (IS_ERR(ptr)) return PTR_ERR(ptr); else return 0; -+ return PTR_ERR_OR_ZERO(ptr); - -@depends on patch@ -expression ptr; -@@ - -- if (IS_ERR(ptr)) return PTR_ERR(ptr); return 0; -+ return PTR_ERR_OR_ZERO(ptr); - -@depends on patch@ -expression ptr; -@@ - -- (IS_ERR(ptr) ? PTR_ERR(ptr) : 0) -+ PTR_ERR_OR_ZERO(ptr) - -@r1 depends on !patch@ -expression ptr; -position p1; -@@ - -* if@p1 (IS_ERR(ptr)) return PTR_ERR(ptr); else return 0; - -@r2 depends on !patch@ -expression ptr; -position p2; -@@ - -* if@p2 (IS_ERR(ptr)) return PTR_ERR(ptr); return 0; - -@r3 depends on !patch@ -expression ptr; -position p3; -@@ - -* IS_ERR@p3(ptr) ? PTR_ERR(ptr) : 0 - -@script:python depends on org@ -p << r1.p1; -@@ - -coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used") - - -@script:python depends on org@ -p << r2.p2; -@@ - -coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used") - -@script:python depends on org@ -p << r3.p3; -@@ - -coccilib.org.print_todo(p[0], "WARNING: PTR_ERR_OR_ZERO can be used") - -@script:python depends on report@ -p << r1.p1; -@@ - -coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used") - -@script:python depends on report@ -p << r2.p2; -@@ - -coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used") - -@script:python depends on report@ -p << r3.p3; -@@ - -coccilib.report.print_report(p[0], "WARNING: PTR_ERR_OR_ZERO can be used")