Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp858340ybc; Tue, 19 Nov 2019 10:23:50 -0800 (PST) X-Google-Smtp-Source: APXvYqz0jLCosFmG2mZ0rffJa+h/D88r5LUyrHOTP8W0ma9GpTo2IPepp+n8Uc6hqPxBPwOvfQgS X-Received: by 2002:a1c:9a4f:: with SMTP id c76mr7465685wme.103.1574187830266; Tue, 19 Nov 2019 10:23:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574187830; cv=none; d=google.com; s=arc-20160816; b=jU6SRqjhBEOBlz/PA5R7qF6AUcpMbCoiB6IBIwtCh1OpSTN7lyYOorGBm47TTW9oNa Ob6j5UPCvu/UCFFKb4Sp+9r7XlzC7ZrLMh1MICMbT9vvPYcfOvHYAqZ1eFrbeue6vPDg /kdJgOWecrNhMGDWHVmuIrQqWh7WBeV1ITF03e4Wtk5nP3iXPFprCiMPVpgHO66ZROPK kNsR5G1a5aOtEr73Ud5dbps8x9ws1dCXhLu2N280HGjgF/KfGOhZe9G1hnHDMREnOqaW W9VDk2qdCuZUndwM5hw6oYdYZs01tZbFse3CtZ/xdyX92E0X17/TMHig6+7ThbOPxspZ 181Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=0dUXKYCswQ0fk3ChDtCHMcNLvLahQKNVxckNHbLK62U=; b=CP3Xr570mHH8Fam+iEkqeySCFGDie1kEDH2N7OiIqk+6MdV+qiICB+jK/dHC8jPD/x txq1e+Me92krtO067RO5Yk257osCa9snFuDSvnUMb94mcAUIUc1ibercFyzJ3org1GVL sHrm5etmyZ5zwa9U4SHmNCEcFrQkKLqtUGTpFL+n2YMdZaVVS+SKXWANbDuQdQUYQj8m VVimdf9hi1iNsQs261mbahuuCivalb2pdzdZxcY4TN+x6p6DHSDu09g76MOI5K5RP59Y EzO22JM1CvgJzy/EhyVA7hLave0BMaabf97YKVHaa9grj3K4K3Wvt9FeFSP+1dKI2jja nmaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=e5lESrFN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r1si15398378edm.57.2019.11.19.10.23.25; Tue, 19 Nov 2019 10:23:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=e5lESrFN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727316AbfKSSVV (ORCPT + 99 others); Tue, 19 Nov 2019 13:21:21 -0500 Received: from mail-lf1-f66.google.com ([209.85.167.66]:34168 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726510AbfKSSVV (ORCPT ); Tue, 19 Nov 2019 13:21:21 -0500 Received: by mail-lf1-f66.google.com with SMTP id l28so8405609lfj.1; Tue, 19 Nov 2019 10:21:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0dUXKYCswQ0fk3ChDtCHMcNLvLahQKNVxckNHbLK62U=; b=e5lESrFN8MyoYepnYPws1P7yf4C1dXiYfMOkmezNqIXAiZCpH6SxlKI9ix3SlSORNf /5JsXZyp1E+IjqGqwMhUYHulRiSh9QJkMf1GIFQllRE77579xVcB4EDXytX2AWhcMFvQ 1ksK6LpTugAMceaAYTPHCvwtSWDKN7rqeIueDTbWQtIHR4HQydG5oXkfTtYGFdaIoyjU CylOl88XU0mV6aCUOh7u/8Q+Yga6rgxzX3jS4Uzen0MivFUrqkq6uYhpdWXn0ASFSQew 25whUzIeI6GQW/U3sk+CCl9AnoSAUrolJLK0fI3TEVzTWkTXjIjQqrrTPxWQjG7LKd5E juzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0dUXKYCswQ0fk3ChDtCHMcNLvLahQKNVxckNHbLK62U=; b=hFKk88AGKEQsXUJsQecvDfOHklYS+Mjvwe5VP0vgkVKiGMAUR+uuUXmifzMYyKuZGT 6xpaGktrvldf96Ph0gnyCPFM2uurQOlwczHQD3XoxaJtlFI5qwL71kfYqdxh3+0yXBMQ EdU0UEK2fqTfyvO6Jj0fEgoBsRtoJAygewp7YnlxqEpCD+FpLEZ68Kz3wc4FW2hRV1Gw 4WzKy4qCYyomJ0x3OKTMpbOQTbJBdpuOnrvVvqwcyGMU941nZVm3Pwmjqozdml+QtM/s HuAzObTURvwyfKZPOBKnUjMHGjxmaxrPh1nQrtMZJy2IUvZw74OLYqNQjpJct6KQGtDD aDqQ== X-Gm-Message-State: APjAAAU3RGINO3AC5giwceh/QPBW0ZBvkK24IebAedRSNYFJIPEl0c/8 35o9sFfF/+3bxRxsvFBIYDciFkbXteULQv273OeJ0GNw X-Received: by 2002:a19:4318:: with SMTP id q24mr5172404lfa.12.1574187679050; Tue, 19 Nov 2019 10:21:19 -0800 (PST) MIME-Version: 1.0 References: <20191118152518.3374263-1-adrian.ratiu@collabora.com> <20191118152518.3374263-4-adrian.ratiu@collabora.com> In-Reply-To: <20191118152518.3374263-4-adrian.ratiu@collabora.com> From: Fabio Estevam Date: Tue, 19 Nov 2019 15:21:14 -0300 Message-ID: Subject: Re: [PATCH v3 3/4] drm: imx: Add i.MX 6 MIPI DSI host driver To: Adrian Ratiu Cc: "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-stm32@st-md-mailman.stormreply.com, linux-rockchip@lists.infradead.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Martyn Welch , Sjoerd Simons , linux-kernel , DRI mailing list , NXP Linux Team , kernel@collabora.com, Emil Velikov Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Adrian, On Mon, Nov 18, 2019 at 12:25 PM Adrian Ratiu wrote: Some nitpicks: > + > +config DRM_IMX_MIPI_DSI > + tristate "Freescale i.MX DRM MIPI DSI" This text seems too generic as there are i.MX SoCs that use different MIPI DSI IP. Maybe "Freescale i.MX6 DRM MIPI DSI" instead? > +module_platform_driver(imx_mipi_dsi_driver); > + > +MODULE_DESCRIPTION("i.MX MIPI DSI host controller driver"); i.MX6 MIPI DSI, please.