Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] block-mq: ratelimit the warning log
To:     Junxiao Bi <junxiao.bi@oracle.com>, linux-kernel@vger.kernel.org
References: <20191114230233.3582-1-junxiao.bi@oracle.com>
Cc:     axboe@kernel.dk
From:   Junxiao Bi <junxiao.bi@oracle.com>
Message-ID: <00519647-0993-4e7c-0990-283358c1865b@oracle.com>
Date:   Tue, 19 Nov 2019 13:12:07 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0)
 Gecko/20100101 Thunderbird/60.9.1
MIME-Version: 1.0
In-Reply-To: <20191114230233.3582-1-junxiao.bi@oracle.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Anybody help reviewing this?

On 11/14/19 3:02 PM, Junxiao Bi wrote:
> When doing cpu online/offlile, sometimes this warning will be triggered,
> it's harmless, io will be dispatched. But sometimes it warns too much and
> even stall the whole system, so ratelimit it.
>
> Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
> ---
>   block/blk-mq.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index ec791156e9cc..846f5d26c523 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -1384,7 +1384,7 @@ static void __blk_mq_run_hw_queue(struct blk_mq_hw_ctx *hctx)
>   	 *   handle dispatched requests to this hctx
>   	 */
>   	if (!cpumask_test_cpu(raw_smp_processor_id(), hctx->cpumask) &&
> -		cpu_online(hctx->next_cpu)) {
> +		cpu_online(hctx->next_cpu) && printk_ratelimit()) {
>   		printk(KERN_WARNING "run queue from wrong CPU %d, hctx %s\n",
>   			raw_smp_processor_id(),
>   			cpumask_empty(hctx->cpumask) ? "inactive": "active");