Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1e9719feb8c650ea90dec41850fe9058eef59862.camel@perches.com>
Subject: Re: [PATCH 2/2] MAINTAINERS: Switch to Marvell addresses
From:   Joe Perches <joe@perches.com>
To:     Robert Richter <rrichter@marvell.com>
Cc:     Arnd Bergmann <arnd@arndb.de>, arm soc <arm@kernel.org>,
        Jan Glauber <jglauber@marvell.com>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        George Cherian <gcherian@marvell.com>,
        Ganapatrao Prabhakerrao Kulkarni <gkulkarni@marvell.com>,
        Will Deacon <will@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        "soc@kernel.org" <soc@kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date:   Tue, 19 Nov 2019 13:12:00 -0800
In-Reply-To: <20191119202328.cqfzf5a4svn23h5a@rric.localdomain>
References: <20191119165549.14570-1-rrichter@marvell.com>
         <20191119165549.14570-4-rrichter@marvell.com>
         <64ace55545c028bc39b08370074aafd32e8fc5f5.camel@perches.com>
         <20191119185012.2fekd6f5gbpflpqe@rric.localdomain>
         <cb41a8956be6cf11e9d25c1790eeb8c935b9ab29.camel@perches.com>
         <20191119202328.cqfzf5a4svn23h5a@rric.localdomain>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.34.1-2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2019-11-19 at 20:23 +0000, Robert Richter wrote:
> Joe,
> 
> thanks for your review.
> 
> On 19.11.19 11:56:53, Joe Perches wrote:
> > Maybe make that change globally in all the files other
> > than MAINTAINERS as well eventually.
> > 
> > arch/arm64/mm/numa.c:6: * Author: Ganapatrao Kulkarni <gkulkarni@cavium.com>
> > arch/mips/cavium-octeon/octeon-usb.c:551:MODULE_AUTHOR("David Daney <david.daney@cavium.com>");
> > arch/mips/include/asm/octeon/cvmx-coremask.h:6: * Copyright (c) 2016  Cavium Inc. (support@cavium.com).
> 
> [...]
> 
> This is a bit past the scope of this patch.

Yup, completely agree, as it seems I understated with "eventually".

>  I will leave that change to the driver's maintainers.

Fine by me.  btw:  There's also entries for @caviumnetworks.com
so those might change one day too.

> I also think that authorship does not
> change even if the author's email address changed or vanished later. I
> am not sure on the general handling of MODULE_AUTHOR(), should that
> always contain a valid email address? Seems not the case. I don't
> think somebody actually sends an email to the author, it is more to
> better identify the author.

Changelog identifies the author, MODULE_AUTHOR is actually
available via modinfo -a, which shows email if entered,
but that may also be rarely used in practice.