Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1051861ybc; Tue, 19 Nov 2019 13:41:06 -0800 (PST) X-Google-Smtp-Source: APXvYqxWiwnFxTZgIhVZP3knH4LVNUJO1+JyulDXaCoCNriPvuIPXDXYTHpypEbnNRzCStMpyNe9 X-Received: by 2002:a17:906:4697:: with SMTP id a23mr37519998ejr.322.1574199665871; Tue, 19 Nov 2019 13:41:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574199665; cv=none; d=google.com; s=arc-20160816; b=CCtPJPeAMOCk4BPE+MK5897HSZjVzXUU3oig5ViQuNnfvx+fWYYAtKJ+oUqQuswF/a D4y7I+4yltyHhVa7lAaxyWd5kcfunZ3cWm6bHoC9lVcBSti/r5KIvSAOrWOdAjXnk8dD VwzxmHO70QrinXUHl1i2G9ygW5rPhBR8ELYvhqunnmdQy+56SXIlCHH+drE6fWeu1kMR Y3AswWtFWe8wYXYwc599lF3UMNQkmlrJClCzLlq5a+gcYBgzHVwiyaNA9z/4QvX1U0GJ i+W6Wogte70sFkcraFWKZ8o3MOzG7oklufKMWFwwj8xt8EBpLaWWTAObZwP1lmB2NGsY sMjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:from:subject:mime-version :message-id:date:dkim-signature; bh=6Oh8ez2vQeUAb5PnTKMOWQGApcFEd8vMEamkT67anhA=; b=Qd3BaQ+vbNWvGnvSu+QBuSwoas9CfXAsbANigCn3Wzca2CpMLbzsfBfenI5swOuWgB 6N8gxmSHX7Dw5S7yJq7khT5raOzEpnLDQSHZE+wwsE/WqAIR8kVdxHTeyGEzVqoQKwvu Js4E0h/ss27hi3bBP02T1bSb+Tfjlghm5lYJrYcVFlMV5CXnsS/liU+UyuwoDupDSRVw yDufodjmcK0R9MBZXhseroFmOOT7WoEyn+vaw2jAGLESjZzrkWVU5TY2NLWkiZXeVNbX wn0n0rD5sEEYyur2pF6bW7w65Ffg6RBtWNLMfF6xtIPRzBjeUShm3mJLuqJ5YX5rS7ji teyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=l8EMZDoz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h37si17902589eda.249.2019.11.19.13.40.41; Tue, 19 Nov 2019 13:41:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=l8EMZDoz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727423AbfKSVjD (ORCPT + 99 others); Tue, 19 Nov 2019 16:39:03 -0500 Received: from mail-pg1-f202.google.com ([209.85.215.202]:42505 "EHLO mail-pg1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727202AbfKSVjC (ORCPT ); Tue, 19 Nov 2019 16:39:02 -0500 Received: by mail-pg1-f202.google.com with SMTP id p8so16520746pgm.9 for ; Tue, 19 Nov 2019 13:39:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=6Oh8ez2vQeUAb5PnTKMOWQGApcFEd8vMEamkT67anhA=; b=l8EMZDoz0ncUEb4shgTBSTIj1pS4wqZFXkz7gFMBxdZSjfycv6kM3MA/0efHq1TYGS bQ8xu8kr0EfaIywUvuBjrpKOZi+dpA4ASU4DQ1F50s2oLIDMJoC9A34cXKw+U8S5PhIm zpo/Ytsfiy2l4Yx9wr9SsWw5NgSv89oqfO88TPOozgedrlP/chHEcbHua5kRWywRgwVI z4rLgpQBiC6iy6pW7ClaYLFfwCTYTjrkB0C5pAAINwyTnCzjCkKf2pZSlLEK17fwKFoG xJOzucXyeHBIJowKHjryY3FrpF78uFB24kMuBxJ+3BIJxazcaKAI6D3qJz0UVXv1cOho hSgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=6Oh8ez2vQeUAb5PnTKMOWQGApcFEd8vMEamkT67anhA=; b=rzmhOr7Oro4JKvdSEN0c8nV7jd7ALblaKF/OfUhJtyu3YmIhpDb8z8OoPA5fv632yc fd4yaTRO5F38SWA6HeCDq/fU08AvHBnE5im1FJI/gdoA07l0/sC5QfElGpj4ndrBBqvv pNLHJPdLZzZfJlsbeq3KZom+99NfErTqjPMJqmXyO1hGyKM7X7hy/q/Aj0mgvJdopDd3 a7FJ3eR4Zo4QctaxnYL7lTbd2Y/i7LrwAMnwVZA+My641HD+nFmpv6+ljx8TArRek8HK oIsYYwrUhkBltA+NHV21l5cpMm6LW9/Xq6l55pPJ9mnEIbk4V2wVeCWYEtL9FJz1XtSx XpcQ== X-Gm-Message-State: APjAAAVeA2Hus2D3nh38q5ZZeNIYrlZl9iBWsURkrep6Bjcoik2vB1yS alMbPDWQrMCh4NZNXuvUnjpIRWVrMgGrnHcQ7kILuA== X-Received: by 2002:a65:5648:: with SMTP id m8mr2923798pgs.286.1574199541054; Tue, 19 Nov 2019 13:39:01 -0800 (PST) Date: Tue, 19 Nov 2019 13:38:34 -0800 Message-Id: <20191119213834.175992-1-brendanhiggins@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.24.0.432.g9d3f5f5b63-goog Subject: [PATCH linux-kselftest/test v1] Documentation: kunit: fix typos and gramatical errors From: Brendan Higgins To: shuah@kernel.org, davidgow@google.com Cc: kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, corbet@lwn.net, heidifahim@google.com, trishalfonso@google.com, Brendan Higgins , Randy Dunlap Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix typos and gramatical errors in the Getting Started and Usage guide for KUnit. Reported-by: Randy Dunlap Link: https://patchwork.kernel.org/patch/11156481/ Signed-off-by: Brendan Higgins --- Documentation/dev-tools/kunit/start.rst | 6 +++--- Documentation/dev-tools/kunit/usage.rst | 22 +++++++++++----------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/Documentation/dev-tools/kunit/start.rst b/Documentation/dev-tools/kunit/start.rst index f4d9a4fa914f8..db146c7d77490 100644 --- a/Documentation/dev-tools/kunit/start.rst +++ b/Documentation/dev-tools/kunit/start.rst @@ -26,7 +26,7 @@ For more information on this wrapper (also called kunit_tool) checkout the Creating a kunitconfig ====================== -The Python script is a thin wrapper around Kbuild as such, it needs to be +The Python script is a thin wrapper around Kbuild. As such, it needs to be configured with a ``kunitconfig`` file. This file essentially contains the regular Kernel config, with the specific test targets as well. @@ -62,8 +62,8 @@ If everything worked correctly, you should see the following: followed by a list of tests that are run. All of them should be passing. .. note:: - Because it is building a lot of sources for the first time, the ``Building - kunit kernel`` step may take a while. + Because it is building a lot of sources for the first time, the + ``Building KUnit kernel`` step may take a while. Writing your first test ======================= diff --git a/Documentation/dev-tools/kunit/usage.rst b/Documentation/dev-tools/kunit/usage.rst index c6e69634e274b..ae42a0d128c27 100644 --- a/Documentation/dev-tools/kunit/usage.rst +++ b/Documentation/dev-tools/kunit/usage.rst @@ -16,7 +16,7 @@ Organization of this document ============================= This document is organized into two main sections: Testing and Isolating -Behavior. The first covers what a unit test is and how to use KUnit to write +Behavior. The first covers what unit tests are and how to use KUnit to write them. The second covers how to use KUnit to isolate code and make it possible to unit test code that was otherwise un-unit-testable. @@ -174,13 +174,13 @@ Test Suites ~~~~~~~~~~~ Now obviously one unit test isn't very helpful; the power comes from having -many test cases covering all of your behaviors. Consequently it is common to -have many *similar* tests; in order to reduce duplication in these closely -related tests most unit testing frameworks provide the concept of a *test -suite*, in KUnit we call it a *test suite*; all it is is just a collection of -test cases for a unit of code with a set up function that gets invoked before -every test cases and then a tear down function that gets invoked after every -test case completes. +many test cases covering all of a unit's behaviors. Consequently it is common +to have many *similar* tests; in order to reduce duplication in these closely +related tests most unit testing frameworks - including KUnit - provide the +concept of a *test suite*. A *test suite* is just a collection of test cases +for a unit of code with a set up function that gets invoked before every test +case and then a tear down function that gets invoked after every test case +completes. Example: @@ -211,7 +211,7 @@ KUnit test framework. .. note:: A test case will only be run if it is associated with a test suite. -For a more information on these types of things see the :doc:`api/test`. +For more information on these types of things see the :doc:`api/test`. Isolating Behavior ================== @@ -454,7 +454,7 @@ KUnit on non-UML architectures By default KUnit uses UML as a way to provide dependencies for code under test. Under most circumstances KUnit's usage of UML should be treated as an implementation detail of how KUnit works under the hood. Nevertheless, there -are instances where being able to run architecture specific code, or test +are instances where being able to run architecture specific code or test against real hardware is desirable. For these reasons KUnit supports running on other architectures. @@ -557,7 +557,7 @@ run your tests on your hardware setup just by compiling for your architecture. .. important:: Always prefer tests that run on UML to tests that only run under a particular architecture, and always prefer tests that run under QEMU or another easy - (and monitarily free) to obtain software environment to a specific piece of + (and monetarily free) to obtain software environment to a specific piece of hardware. Nevertheless, there are still valid reasons to write an architecture or hardware -- 2.24.0.432.g9d3f5f5b63-goog