Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1055742ybc; Tue, 19 Nov 2019 13:45:45 -0800 (PST) X-Google-Smtp-Source: APXvYqyxvDVGo56mzJnNQ03QChC/bohMYCTRhbm7OVobk+S8sriM4anIn1n4f5SkDijseetkW618 X-Received: by 2002:a1c:1d10:: with SMTP id d16mr48424wmd.14.1574199944950; Tue, 19 Nov 2019 13:45:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574199944; cv=none; d=google.com; s=arc-20160816; b=0lEj1RCCXrbV/n64mQcq6VPSWVzbXfGqQg00vkzLqw9xsZDaq8lkDo+94SYjdlJOh6 lTDbvg2B8CA03NJevLV4/aONzubFDfUx8MijjEN4suYI7p6OjlHWE+9RMZ5gcOnwDWZ7 FmEm+k2AHCRDX6kH8OMYzfsWtXOYKT3uIKGrmm0pqazEhljA6Qsb/lrynWHc7UurwQMC 6FP7Do7bBjd1jGJEeLX+uvY8x1yBu6llKh4osKaQWSl0ePVrlb4rzbr4sSBPkVgcRYRS JsLoKNhR6KzK5Jt6aAlmp0J9T5OPakJu9Tya6FEwdXo5MpwCJs10h+kpd8WG0fXjpA2x B9/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=80HVy2cMgO3Lcq96dxGmlk0Fput3T7/03D4ZoxCBebA=; b=GizEGQ1eRValZq4DdXrLsijKLKCazLLXtyLFXqfnPZ03/pJA4vQAzYxzFcHoz/6OVe T5TxYWm6DlvEJoHhwHo0ykIit6Ah9/i2ytqH4M3UUrE9MHgCVZ+wWTAD6Ujr0ify7RZk lqoAzdDyCGhk2k4Dpb8eoNEtLe6BCYJdifSGkAMX1X5sT4eJ8IdhvIWillDoOSIyqb/c 9Stbk+Ijfo84AYFnRtbOjkfKDmQMVs2ETIyigZCHSbbQTqpJYonJwT+g1y79ARCiZIet 1fTjGjhHt6kcAOPccizEJtqPMI6otWtwM9sIH/MQw8GPm6Wwt3ljEPCkgbXSPzb/xF/0 lWRw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q8si15122493edb.28.2019.11.19.13.45.21; Tue, 19 Nov 2019 13:45:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727486AbfKSVoQ (ORCPT + 99 others); Tue, 19 Nov 2019 16:44:16 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:37880 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727395AbfKSVoI (ORCPT ); Tue, 19 Nov 2019 16:44:08 -0500 X-IronPort-AV: E=Sophos;i="5.69,219,1571695200"; d="scan'208";a="412575417" Received: from palace.lip6.fr ([132.227.105.202]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES128-SHA256; 19 Nov 2019 22:44:04 +0100 From: Julia Lawall To: Masahiro Yamada Cc: kernel-janitors@vger.kernel.org, Gilles Muller , Nicolas Palix , Michal Marek , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: [PATCH 4/4 v2] coccinelle: platform_get_irq: drop unneeded metavariable Date: Tue, 19 Nov 2019 22:08:25 +0100 Message-Id: <1574197705-31132-5-git-send-email-Julia.Lawall@lip6.fr> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1574197705-31132-1-git-send-email-Julia.Lawall@lip6.fr> References: <1574197705-31132-1-git-send-email-Julia.Lawall@lip6.fr> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Having E as a metavariable adds the requirement to verify its type. This seems like an unnecessary constraint, so drop it. There is currently no impact on the set of results. Signed-off-by: Julia Lawall --- v2: fix From and To (very sorry for the mistake) scripts/coccinelle/api/platform_get_irq.cocci | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/scripts/coccinelle/api/platform_get_irq.cocci b/scripts/coccinelle/api/platform_get_irq.cocci index e5d04fb..17e5895 100644 --- a/scripts/coccinelle/api/platform_get_irq.cocci +++ b/scripts/coccinelle/api/platform_get_irq.cocci @@ -11,7 +11,6 @@ virtual report @depends on context@ expression ret; -struct platform_device *E; @@ ret = @@ -19,7 +18,7 @@ ret = platform_get_irq | platform_get_irq_byname -)(E, ...); +)(...); if ( \( ret < 0 \| ret <= 0 \) ) { @@ -30,7 +29,6 @@ if ( \( ret < 0 \| ret <= 0 \) ) @depends on patch@ expression ret; -struct platform_device *E; statement S; @@ @@ -39,7 +37,7 @@ ret = platform_get_irq | platform_get_irq_byname -)(E, ...); +)(...); if ( \( ret < 0 \| ret <= 0 \) ) -{ @@ -49,7 +47,6 @@ S @depends on patch@ expression ret; -struct platform_device *E; @@ ret = @@ -57,7 +54,7 @@ ret = platform_get_irq | platform_get_irq_byname -)(E, ...); +)(...); if ( \( ret < 0 \| ret <= 0 \) ) { @@ -76,7 +73,6 @@ if ( \( ret < 0 \| ret <= 0 \) ) @r depends on org || report@ position p1; expression ret; -struct platform_device *E; @@ ret = @@ -84,7 +80,7 @@ ret = platform_get_irq | platform_get_irq_byname -)(E, ...); +)(...); if ( \( ret < 0 \| ret <= 0 \) ) {