Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1154380ybc; Tue, 19 Nov 2019 15:36:21 -0800 (PST) X-Google-Smtp-Source: APXvYqxM9h5+YtROX/Hj8rCoC7D5rbHW3QZdZO9nd7kQ1rW8Su3O0FxAXwDxyhVsFF6+IzHQ47/C X-Received: by 2002:a17:906:d939:: with SMTP id rn25mr490987ejb.147.1574206581631; Tue, 19 Nov 2019 15:36:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574206581; cv=none; d=google.com; s=arc-20160816; b=Ih2x4Rg3YTJ+4hGrEw4nTQxkiRSmo7SKoOrKoQVJoJOBTsOG0pLm2wW9ixOcHLWxpz V+KyisT/uKMvW0IBf8Udi4OooPy1ThizOWA+pvSx+QI4QY5aRKVKA+YC2TW2RwH0UXs0 Lg8IZ/aMWd2szDn1a31rAU+D5ldCph9rmcZMRiRdmBI1SbhO5zgPpa/7h74cCqLhrEAn 9Wj1CdSVkbds3Y3qAF7mJgeiI3LctSPR8oEqdnw5QSiuwv2yhu+I+q7znHeFXATtM3ak beB7DR7p7iQQE3wfxwYghFo8YcSnAU/UoRZY7j0KYH8fiKJGD+YUrQPpYxsssS7WHngI hOcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=S8cSAODsBNs/kjgFuz3dSAOALhPDmx/iKzNv4ZwO+Cw=; b=c4iRVBFXh1snJuZdpM8gM26JUkgJFfDqGvnLjZ5aBCmFWn297iGRCFDaCNavnWlJx8 hk9rx7h3AeU/mag77uYrLtV4P0oJV7lr96BaoajNCXz0x7NJO3PO4Dz3CnoTme7vhXie QiT3fgwMTKQsQvrMbjeARF2A6azYwRe5k84umRObj4bEZXqayc3XKzE9A0fu6BRGU01U 81NCQPgRC8rMZYzVVmv7s7PThY16dr35cSWZByNR2kVzfZp8N1ZiecFF0hEAbR2tQHu3 OG0TBCsmVIR59/bp/Ng6JSPO4vSlqfFM4vxG+Nhci52q6wg2hlobTvBcQ0EF1f9GXQqU Ut3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n15si14043671ejj.68.2019.11.19.15.35.57; Tue, 19 Nov 2019 15:36:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727415AbfKSXdo (ORCPT + 99 others); Tue, 19 Nov 2019 18:33:44 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:46602 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726874AbfKSXdo (ORCPT ); Tue, 19 Nov 2019 18:33:44 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B436C142A3422; Tue, 19 Nov 2019 15:33:41 -0800 (PST) Date: Tue, 19 Nov 2019 15:33:41 -0800 (PST) Message-Id: <20191119.153341.1849410731804008442.davem@davemloft.net> To: ivan.khoronzhuk@linaro.org Cc: netdev@vger.kernel.org, vinicius.gomes@intel.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, linux-kernel@vger.kernel.org, olteanv@gmail.com Subject: Re: [net PATCH v2] taprio: don't reject same mqprio settings From: David Miller In-Reply-To: <20191119002312.23811-1-ivan.khoronzhuk@linaro.org> References: <20191119002312.23811-1-ivan.khoronzhuk@linaro.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 19 Nov 2019 15:33:42 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ivan Khoronzhuk Date: Tue, 19 Nov 2019 02:23:12 +0200 > The taprio qdisc allows to set mqprio setting but only once. In case > if mqprio settings are provided next time the error is returned as > it's not allowed to change traffic class mapping in-flignt and that > is normal. But if configuration is absolutely the same - no need to > return error. It allows to provide same command couple times, > changing only base time for instance, or changing only scheds maps, > but leaving mqprio setting w/o modification. It more corresponds the > message: "Changing the traffic mapping of a running schedule is not > supported", so reject mqprio if it's really changed. > > Also corrected TC_BITMASK + 1 for consistency, as proposed. > > Fixes: a3d43c0d56f1 ("taprio: Add support adding an admin schedule") > Reviewed-by: Vladimir Oltean > Tested-by: Vladimir Oltean > Acked-by: Vinicius Costa Gomes > Signed-off-by: Ivan Khoronzhuk Applied and queued up for -stable.