Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 19 Nov 2019 17:12:17 -0800
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     David Miller <davem@davemloft.net>
Cc:     anders.roxell@linaro.org, kuznet@ms2.inr.ac.ru,
        yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ipmr: fix suspicious RCU warning
Message-ID: <20191120011217.GM2889@paulmck-ThinkPad-P72>
Reply-To: paulmck@kernel.org
References: <20191118090925.2474-1-anders.roxell@linaro.org>
 <20191119.145048.487849503145486152.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191119.145048.487849503145486152.davem@davemloft.net>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Nov 19, 2019 at 02:50:48PM -0800, David Miller wrote:
> From: Anders Roxell <anders.roxell@linaro.org>
> Date: Mon, 18 Nov 2019 10:09:25 +0100
> 
> > @@ -108,9 +108,18 @@ static void igmpmsg_netlink_event(struct mr_table *mrt, struct sk_buff *pkt);
> >  static void mroute_clean_tables(struct mr_table *mrt, int flags);
> >  static void ipmr_expire_process(struct timer_list *t);
> >  
> > +#ifdef CONFIG_PROVE_LOCKING
> > +int ip_mr_initialized;
> > +void ip_mr_now_initialized(void) { ip_mr_initialized = 1; }
> > +#else
> > +const int ip_mr_initialized = 1;
> > +void ip_mr_now_initialized(void) { }
> > +#endif
> 
> This seems excessive and a bit not so pretty.
> 
> > +
> >  #ifdef CONFIG_IP_MROUTE_MULTIPLE_TABLES
> >  #define ipmr_for_each_table(mrt, net) \
> > -	list_for_each_entry_rcu(mrt, &net->ipv4.mr_tables, list)
> > +	list_for_each_entry_rcu(mrt, &net->ipv4.mr_tables, list, \
> > +			(lockdep_rtnl_is_held() || !ip_mr_initialized))
> >  
> >  static struct mr_table *ipmr_mr_table_iter(struct net *net,
> >  					   struct mr_table *mrt)
> 
> The problematic code path is ipmr_rules_init() done during ipmr_net_init().
> 
> You can just wrap this call around RCU locking or take the RTNL mutex.

Agreed, that would work quite well.

							Thanx, Paul

> That way you don't need to rediculous ip_mr_initialized knob which frankly
> doesn't even seem accurate to me.  It's a centralized global variable
> which is holding state about multiple network namespace objects which makes
> absolutely no sense at all, it's wrong.