Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1252571ybc; Tue, 19 Nov 2019 17:16:28 -0800 (PST) X-Google-Smtp-Source: APXvYqyuUUZBhnl8NYStmHt+RqLatsX14a6GphtPro/xGSjQkGGjFzdsOqfdc6clC6yYRrQ3M+/v X-Received: by 2002:a17:906:2654:: with SMTP id i20mr1148163ejc.163.1574212588190; Tue, 19 Nov 2019 17:16:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574212588; cv=none; d=google.com; s=arc-20160816; b=ubh9XCg5OoFVTrnVp9sujaU/QoaqdF0C/c1ayRO3u875b94lcDNHohAwelYLIx2Grq Cgz2YhIVp4wLZgbNYPmBzPcqNFhCe6EvjSK/vbQ7Kfh2uRb6p2u0tZgZnkFMuSAB9o2Y 3jgOC8HbzR57ye44VlQ0UtsxQwkay+sZq5+mbWHQIDTL2ibTkWNufFCNh/ARzQGQTB/7 jivMgrFgpj2gkA1Dh+gxcWNd+0LJqMHrR4kwu/a3SOiQk059uT3F/JT7ofl5PwNfVh3A mryqZwQ+ASqcAUmw/Eu0JmD5eC3tjdegHuH0QvwJUdAP4z/vB5W55+jeewUK9C6EqP8p LKrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=2tf+wSIpyi0L7jIJMtqHVmP4pvstpzpkqyBtxEGyytw=; b=mtrTG5vIy/nKVO4I+JXNxZJh+T2yd3aZUpuUyOTy0R84jErAGBLBBSxsbsLiiDQmVJ BTz4cNDf45Ca3/VTTSFvQ5E1SQGK3Uj4cJkCrXKEFKUwh88KaTrUcz+oU1merGrYfTVA 9NOQkgDgwqCEgaPtfb6ZAKa4zXNIXU9aBZJC97yxWMXbaKJEq0Uwd4nb4PGdqkdEmhkD LUgngKFNbRbaFS3bMysZEAaODDXNuYHLQziwxaAHAs/sm5WYK2sTWO1cgrLTj6uQZkjb +fevnAe2ZfXvhfGQ43EZhNaEqr4mIBIQf4SbHUiBK2F7sc4AkgrTSyTHWTAVOpxA2xom Gm8w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n15si6748964ejr.94.2019.11.19.17.16.03; Tue, 19 Nov 2019 17:16:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727615AbfKTBPC (ORCPT + 99 others); Tue, 19 Nov 2019 20:15:02 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:47970 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727545AbfKTBPC (ORCPT ); Tue, 19 Nov 2019 20:15:02 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A8B3E1454E871; Tue, 19 Nov 2019 17:15:01 -0800 (PST) Date: Tue, 19 Nov 2019 17:15:01 -0800 (PST) Message-Id: <20191119.171501.666690660172999834.davem@davemloft.net> To: sgarzare@redhat.com Cc: netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, decui@microsoft.com, stefanha@redhat.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, jhansen@vmware.com Subject: Re: [PATCH net-next 4/6] vsock: add vsock_loopback transport From: David Miller In-Reply-To: <20191119110121.14480-5-sgarzare@redhat.com> References: <20191119110121.14480-1-sgarzare@redhat.com> <20191119110121.14480-5-sgarzare@redhat.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 19 Nov 2019 17:15:02 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stefano Garzarella Date: Tue, 19 Nov 2019 12:01:19 +0100 > +static int vsock_loopback_cancel_pkt(struct vsock_sock *vsk) > +{ > + struct vsock_loopback *vsock; > + struct virtio_vsock_pkt *pkt, *n; > + int ret; > + LIST_HEAD(freeme); Reverse christmas tree ordering of local variables here please.