Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Andy Duan <fugang.duan@nxp.com>
To:     Chuhong Yuan <hslester96@gmail.com>
CC:     "David S . Miller" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH net v4] net: fec: fix clock count mis-match
Thread-Topic: [EXT] [PATCH net v4] net: fec: fix clock count mis-match
Thread-Index: AQHVn0FjeP+5ynWFrkKEfPaLxMT/yqeTRiQg
Date:   Wed, 20 Nov 2019 01:33:11 +0000
Message-ID: <VI1PR0402MB3600B65E741DB82ACA31FC6DFF4F0@VI1PR0402MB3600.eurprd04.prod.outlook.com>
References: <20191120012513.11161-1-hslester96@gmail.com>
In-Reply-To: <20191120012513.11161-1-hslester96@gmail.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d05709d3-d14c-4b58-b349-08d76d599adf
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2019 01:33:11.3323
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tM+Qr7n4kZp6l6+vVPeQpplICni3V6+db3as37FOabaShWxga5sDya6HoGpPaOfup0J2IVjX/OOXIXZMUtKUqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3439
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Chuhong Yuan <hslester96@gmail.com> Sent: Wednesday, November 20, 201=
9 9:25 AM
> pm_runtime_put_autosuspend in probe will call runtime suspend to disable
> clks automatically if CONFIG_PM is defined. (If CONFIG_PM is not defined,=
 its
> implementation will be empty, then runtime suspend will not be called.)
>=20
> Therefore, we can call pm_runtime_get_sync to runtime resume it first to
> enable clks, which matches the runtime suspend. (Only when CONFIG_PM is
> defined, otherwise pm_runtime_get_sync will also be empty, then runtime
> resume will not be called.)
>=20
> Then it is fine to disable clks without causing clock count mis-match.
>=20
> Fixes: c43eab3eddb4 ("net: fec: add missed clk_disable_unprepare in
> remove")
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>

Suggested-by: Fugang Duan <fugang.duan@nxp.com>
Acked-by: Fugang Duan <fugang.duan@nxp.com>
> ---
> Changes in v4:
>   - Fix some typos.
>=20
>  drivers/net/ethernet/freescale/fec_main.c | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index a9c386b63581..4bb30761abfc 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -3636,6 +3636,11 @@ fec_drv_remove(struct platform_device *pdev)
>         struct net_device *ndev =3D platform_get_drvdata(pdev);
>         struct fec_enet_private *fep =3D netdev_priv(ndev);
>         struct device_node *np =3D pdev->dev.of_node;
> +       int ret;
> +
> +       ret =3D pm_runtime_get_sync(&pdev->dev);
> +       if (ret < 0)
> +               return ret;
>=20
>         cancel_work_sync(&fep->tx_timeout_work);
>         fec_ptp_stop(pdev);
> @@ -3643,15 +3648,17 @@ fec_drv_remove(struct platform_device *pdev)
>         fec_enet_mii_remove(fep);
>         if (fep->reg_phy)
>                 regulator_disable(fep->reg_phy);
> -       pm_runtime_put(&pdev->dev);
> -       pm_runtime_disable(&pdev->dev);
> -       clk_disable_unprepare(fep->clk_ahb);
> -       clk_disable_unprepare(fep->clk_ipg);
> +
>         if (of_phy_is_fixed_link(np))
>                 of_phy_deregister_fixed_link(np);
>         of_node_put(fep->phy_node);
>         free_netdev(ndev);
>=20
> +       clk_disable_unprepare(fep->clk_ahb);
> +       clk_disable_unprepare(fep->clk_ipg);
> +       pm_runtime_put_noidle(&pdev->dev);
> +       pm_runtime_disable(&pdev->dev);
> +
>         return 0;
>  }
>=20
> --
> 2.24.0