Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1319402ybc; Tue, 19 Nov 2019 18:44:35 -0800 (PST) X-Google-Smtp-Source: APXvYqzWWzYq08aEEqWRKwfJBuSLMBVXhnofowWww82BciVOCSfnwDu4VhKtd6hq+DDl+1pjvB2n X-Received: by 2002:a17:906:c789:: with SMTP id cw9mr1794571ejb.40.1574217875862; Tue, 19 Nov 2019 18:44:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574217875; cv=none; d=google.com; s=arc-20160816; b=ikjWAJoFNdLjYWzC0f2CwrfvJc3XFudQwI7tBrt7iS8wb9b4LMrMY21rWntkdGdtKW FIFyCEqGB0fOgyissd5uG5E9dc6v9IPj4qUcg5sHISSWsLlkIFcaTq0+WQNdk99eH9qB 558wpImm9FkBn4qqqKn8IPPZ2vm9NatnH4pQQ1MUHYRb5yAZVqjhuu61FP6Yo3x7SswP OxhZzp4DvQ0WCYqSzimb/S+OmmvTDI9zl6loHc/Ru5gG9tpI3U48Y+4X+sPLegkkHbiw UbFV043zmo3uFShoO4AIXpp25S0J6mKcbf2jWpZQ5irpzgX2Xd1Wlp/dY2QKJGWRr3TF WZqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:references:cc:to:from:subject:dkim-signature; bh=vkxAajpmJKWNvP2J+E8iawWh4/OVA4qkQqxYXhvuqY4=; b=f6v3AqUBT05eblom7gnJCF14AUJhMa3ihEEYHq8Sl093TEWD0JuQdbdxwxJeA404Hw 1U0V31sTM+Fu+62BCuClXB/SMQEPfwr+JTazcii1UHJD4ftrATlvhp0vKBu3G5UCbSkR 0sF2b2wHHdPvaaE0vcZMKWyOEJvNHtODScIg8qSPQrvDFRsgBVQ8LB9lMH1/+u3+93JV KWdC3KJvTTeK+ne2xCTfpuAkge3GzqbpXw2rYQZXdY+/A7qQP77Q+Ld39cWi0RItke/V 9CKgQ1l6QhXYYsk4fDn3ZYAFWXsUMREns8zxRUBiAjXKE1jf+b8xq2uliTpttua1BVYj /RCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=cUnDAuRn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d4si7005532ejw.149.2019.11.19.18.44.10; Tue, 19 Nov 2019 18:44:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=cUnDAuRn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727532AbfKTCkh (ORCPT + 99 others); Tue, 19 Nov 2019 21:40:37 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:48698 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726957AbfKTCkg (ORCPT ); Tue, 19 Nov 2019 21:40:36 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xAK2d8TZ007296; Wed, 20 Nov 2019 02:39:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : cc : references : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=vkxAajpmJKWNvP2J+E8iawWh4/OVA4qkQqxYXhvuqY4=; b=cUnDAuRnVyMZ+x1R4JRvdTWs84La8b6mokop73uH9kB9KH+Kt/1OXxOuIcAGNVhHgDTf 9EolK/RZdRgwWAgW1ULwei9drZEhA71trcz092RuuMtbmImAUnz/dOJI+8WKDUImLn9n pGTfU2kJCPSu7yxY0dBxKOSW7yB+1iCyy5se7dyY14zcJ/INKpf1f+oazkl0XqjI+x+i wOXKmhnnCX3/xW/O07s4VXDqWMjINqxJo81HCGOUtNEaCqgWIA2fN8jeHq//QEQ98LgV bsN6t4D0yJTZ9zAusXm7rENRMZNocZq8g65/TP9XHhzEm8hwKU6Qf4FrYGujok7ILOZn Sw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2wa8httspq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Nov 2019 02:39:34 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xAK2X4jH148405; Wed, 20 Nov 2019 02:39:33 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 2wbxm5a554-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Nov 2019 02:39:33 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id xAK2dWfT021200; Wed, 20 Nov 2019 02:39:32 GMT Received: from bostrovs-us.us.oracle.com (/10.152.32.65) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 19 Nov 2019 18:39:32 -0800 Subject: Re: Ping: [PATCH 0/2] x86/Xen/32: xen_iret_crit_fixup adjustments From: Boris Ostrovsky To: Jan Beulich , Juergen Gross Cc: lkml , the arch/x86 maintainers , Andy Lutomirski , "xen-devel@lists.xenproject.org" References: <09359c00-5769-0e0d-4af9-963897d3b498@suse.com> <40267a5b-8f1b-6463-72cd-f8f354c58bc4@oracle.com> <6d70b8e0-7acd-d8ea-fa41-6866ae1ffef9@oracle.com> Autocrypt: addr=boris.ostrovsky@oracle.com; prefer-encrypt=mutual; keydata= mQINBFH8CgsBEAC0KiOi9siOvlXatK2xX99e/J3OvApoYWjieVQ9232Eb7GzCWrItCzP8FUV PQg8rMsSd0OzIvvjbEAvaWLlbs8wa3MtVLysHY/DfqRK9Zvr/RgrsYC6ukOB7igy2PGqZd+M MDnSmVzik0sPvB6xPV7QyFsykEgpnHbvdZAUy/vyys8xgT0PVYR5hyvhyf6VIfGuvqIsvJw5 C8+P71CHI+U/IhsKrLrsiYHpAhQkw+Zvyeml6XSi5w4LXDbF+3oholKYCkPwxmGdK8MUIdkM d7iYdKqiP4W6FKQou/lC3jvOceGupEoDV9botSWEIIlKdtm6C4GfL45RD8V4B9iy24JHPlom woVWc0xBZboQguhauQqrBFooHO3roEeM1pxXjLUbDtH4t3SAI3gt4dpSyT3EvzhyNQVVIxj2 FXnIChrYxR6S0ijSqUKO0cAduenhBrpYbz9qFcB/GyxD+ZWY7OgQKHUZMWapx5bHGQ8bUZz2 SfjZwK+GETGhfkvNMf6zXbZkDq4kKB/ywaKvVPodS1Poa44+B9sxbUp1jMfFtlOJ3AYB0WDS Op3d7F2ry20CIf1Ifh0nIxkQPkTX7aX5rI92oZeu5u038dHUu/dO2EcuCjl1eDMGm5PLHDSP 0QUw5xzk1Y8MG1JQ56PtqReO33inBXG63yTIikJmUXFTw6lLJwARAQABtDNCb3JpcyBPc3Ry b3Zza3kgKFdvcmspIDxib3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT6JAjgEEwECACIFAlH8 CgsCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEIredpCGysGyasEP/j5xApopUf4g 9Fl3UxZuBx+oduuw3JHqgbGZ2siA3EA4bKwtKq8eT7ekpApn4c0HA8TWTDtgZtLSV5IdH+9z JimBDrhLkDI3Zsx2CafL4pMJvpUavhc5mEU8myp4dWCuIylHiWG65agvUeFZYK4P33fGqoaS VGx3tsQIAr7MsQxilMfRiTEoYH0WWthhE0YVQzV6kx4wj4yLGYPPBtFqnrapKKC8yFTpgjaK jImqWhU9CSUAXdNEs/oKVR1XlkDpMCFDl88vKAuJwugnixjbPFTVPyoC7+4Bm/FnL3iwlJVE qIGQRspt09r+datFzPqSbp5Fo/9m4JSvgtPp2X2+gIGgLPWp2ft1NXHHVWP19sPgEsEJXSr9 tskM8ScxEkqAUuDs6+x/ISX8wa5Pvmo65drN+JWA8EqKOHQG6LUsUdJolFM2i4Z0k40BnFU/ kjTARjrXW94LwokVy4x+ZYgImrnKWeKac6fMfMwH2aKpCQLlVxdO4qvJkv92SzZz4538az1T m+3ekJAimou89cXwXHCFb5WqJcyjDfdQF857vTn1z4qu7udYCuuV/4xDEhslUq1+GcNDjAhB nNYPzD+SvhWEsrjuXv+fDONdJtmLUpKs4Jtak3smGGhZsqpcNv8nQzUGDQZjuCSmDqW8vn2o hWwveNeRTkxh+2x1Qb3GT46uuQINBFH8CgsBEADGC/yx5ctcLQlB9hbq7KNqCDyZNoYu1HAB Hal3MuxPfoGKObEktawQPQaSTB5vNlDxKihezLnlT/PKjcXC2R1OjSDinlu5XNGc6mnky03q yymUPyiMtWhBBftezTRxWRslPaFWlg/h/Y1iDuOcklhpr7K1h1jRPCrf1yIoxbIpDbffnuyz kuto4AahRvBU4Js4sU7f/btU+h+e0AcLVzIhTVPIz7PM+Gk2LNzZ3/on4dnEc/qd+ZZFlOQ4 KDN/hPqlwA/YJsKzAPX51L6Vv344pqTm6Z0f9M7YALB/11FO2nBB7zw7HAUYqJeHutCwxm7i BDNt0g9fhviNcJzagqJ1R7aPjtjBoYvKkbwNu5sWDpQ4idnsnck4YT6ctzN4I+6lfkU8zMzC gM2R4qqUXmxFIS4Bee+gnJi0Pc3KcBYBZsDK44FtM//5Cp9DrxRQOh19kNHBlxkmEb8kL/pw XIDcEq8MXzPBbxwHKJ3QRWRe5jPNpf8HCjnZz0XyJV0/4M1JvOua7IZftOttQ6KnM4m6WNIZ 2ydg7dBhDa6iv1oKdL7wdp/rCulVWn8R7+3cRK95SnWiJ0qKDlMbIN8oGMhHdin8cSRYdmHK kTnvSGJNlkis5a+048o0C6jI3LozQYD/W9wq7MvgChgVQw1iEOB4u/3FXDEGulRVko6xCBU4 SQARAQABiQIfBBgBAgAJBQJR/AoLAhsMAAoJEIredpCGysGyfvMQAIywR6jTqix6/fL0Ip8G jpt3uk//QNxGJE3ZkUNLX6N786vnEJvc1beCu6EwqD1ezG9fJKMl7F3SEgpYaiKEcHfoKGdh 30B3Hsq44vOoxR6zxw2B/giADjhmWTP5tWQ9548N4VhIZMYQMQCkdqaueSL+8asp8tBNP+TJ PAIIANYvJaD8xA7sYUXGTzOXDh2THWSvmEWWmzok8er/u6ZKdS1YmZkUy8cfzrll/9hiGCTj u3qcaOM6i/m4hqtvsI1cOORMVwjJF4+IkC5ZBoeRs/xW5zIBdSUoC8L+OCyj5JETWTt40+lu qoqAF/AEGsNZTrwHJYu9rbHH260C0KYCNqmxDdcROUqIzJdzDKOrDmebkEVnxVeLJBIhYZUd t3Iq9hdjpU50TA6sQ3mZxzBdfRgg+vaj2DsJqI5Xla9QGKD+xNT6v14cZuIMZzO7w0DoojM4 ByrabFsOQxGvE0w9Dch2BDSI2Xyk1zjPKxG1VNBQVx3flH37QDWpL2zlJikW29Ws86PHdthh Fm5PY8YtX576DchSP6qJC57/eAAe/9ztZdVAdesQwGb9hZHJc75B+VNm4xrh/PJO6c1THqdQ 19WVJ+7rDx3PhVncGlbAOiiiE3NOFPJ1OQYxPKtpBUukAlOTnkKE6QcA4zckFepUkfmBV1wM Jg6OxFYd01z+a+oL Message-ID: Date: Tue, 19 Nov 2019 21:39:21 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <6d70b8e0-7acd-d8ea-fa41-6866ae1ffef9@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9446 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1911200022 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9446 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1911200023 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/19/19 9:17 PM, Boris Ostrovsky wrote: > On 11/19/19 12:50 PM, Boris Ostrovsky wrote: >> On 11/19/19 7:58 AM, Jan Beulich wrote: >>> On 11.11.2019 15:30, Jan Beulich wrote: >>>> The first patch here fixes another regression from 3c88c692c287 >>>> ("x86/stackframe/32: Provide consistent pt_regs"), besides the >>>> one already addressed by >>>> https://lists.xenproject.org/archives/html/xen-devel/2019-10/msg01988.html. >>>> The second patch is a minimal bit of cleanup on top. >>>> >>>> 1: make xen_iret_crit_fixup independent of frame layout >>>> 2: simplify xen_iret_crit_fixup's ring check >>> Seeing that the other regression fix has been taken into -tip, >>> what is the situation here? Should 5.4 really ship with this >>> still unfixed? >> I am still unable to boot a 32-bit guest with those patches, crashing in >> int3_exception_notify with regs->sp zero. >> >> When I revert to 3c88c692c287 the guest actually boots so my (?) problem >> was introduced somewhere in-between. > Nevermind this. I didn't read your patches correctly. BTW, I'd rather this not go into 5.4 this late. 3c88c692c287 has been there since 5.2 and noone complained. -boris