Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Namjae Jeon" <namjae.jeon@samsung.com>
To:     "'Christoph Hellwig'" <hch@lst.de>
Cc:     "'Daniel Wagner'" <dwagner@suse.de>,
        <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
        <gregkh@linuxfoundation.org>, <valdis.kletnieks@vt.edu>,
        <linkinjeon@gmail.com>, <Markus.Elfring@web.de>,
        <sj1557.seo@samsung.com>
In-Reply-To: <20191119171752.GA20042@lst.de>
Subject: RE: [PATCH v2 02/13] exfat: add super block operations
Date:   Wed, 20 Nov 2019 13:33:16 +0900
Message-ID: <007901d59f5b$a0eb6780$e2c23680$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Language: ko
Thread-Index: AQEo1XJlLzywHhHshRBLsQkFEP9+bwICkZlvAboM/rECPrXdMAJVBHmKAkbIIb+omFKvQA==
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20191119071107.1947-1-namjae.jeon@samsung.com>
        <CGME20191119071403epcas1p3f3d69faad57984fa3d079cf18f0a46dc@epcas1p3.samsung.com>
        <20191119071107.1947-3-namjae.jeon@samsung.com>
        <20191119085639.kr4esp72dix4lvok@beryllium.lan>
        <00d101d59eba$dcc373c0$964a5b40$@samsung.com>
        <20191119171752.GA20042@lst.de>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> On Tue, Nov 19, 2019 at 06:22:28PM +0900, Namjae Jeon wrote:
> > > No idea what the code does. But I was just skimming over and find the
> > > above pattern somehow strange. Shouldn't this be something like
> > Right.
> >
> > >
> > > 	if (!READ_ONCE(sbi->s_dirt)) {
> > > 		WRITE_ONCE(sbi->s_dirt, true);
> >
> > It should be :
> > 	if (READ_ONCE(sbi->s_dirt)) {
> >  		WRITE_ONCE(sbi->s_dirt, false);
> > I will fix it on v3.
> 
> The other option would be to an unsigned long flags field and define
> bits flags on it, then use test_and_set_bit, test_and_clear_bit etc.
> Which might be closer to the pattern we use elsewhere in the kernel.
I will replace it with test_and_set/clear_bit().

Thanks!