Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1612191ybc; Wed, 20 Nov 2019 01:04:13 -0800 (PST) X-Google-Smtp-Source: APXvYqzuW+texczcrmJZzFpPPp17Rc+A/vPQ+Ugq+hpzwbKzI2iei36jmt3XC6bLQSrFUo8mMIkO X-Received: by 2002:a17:906:1c59:: with SMTP id l25mr3869709ejg.98.1574240653250; Wed, 20 Nov 2019 01:04:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574240653; cv=none; d=google.com; s=arc-20160816; b=SyPN51a9pFBa95DNS2KAPN10//W06Otv6FaIJE3On1ju7Dbu1hQkiqlscv8lQ3q2UC tI0bkw8vt0HALcN6uYtE5FvlJNUPH+K31Bg9AF75HcxGIhZkGlBe/1xH6lio1lwa6YeK nofRniVLXiktE2r8fdrBxzZGqMJz8AEIzmf44nU3QwB/+qiv44qKCMaei33lRBGF/kP8 6rTlRpjcP3pzBInYP0a0g0d0jJ/SYmHxmtyGaG5ZKEEJlRU62ufTZ98z+xNjXwbmcfke nUQwoAgGkvd3NalmC7rrhc7DFBk3fpU3iMB8N6fglZgffCD6kdg0EpwnmRkAvzVaFO9c 9ZUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:in-reply-to:mime-version:references :message-id:subject:cc:to:from:date:dkim-signature; bh=df2jZGkaKYIX8XGP45379iKP8na141nKrPLZMKk0bUg=; b=cUR3DBeY1ozWEn5mv2xNwmfIEibVrDNTF/Ey7NK49oDJY2U3fGnU4o04JG6iQTSbNC PWMDco7B49c3iCHD73LImce846Wn2G6t5on9hQT1XVYbOPMhawKxNbAv67dI2oeE/DyC a8aYgtYuPHb5USjizl0D4IFBZZpMrAeq9CdV3J8c1u/VDLBahIoFMZHW4wzP2gFB9qXI 39xzJ++3p9zk+y/FKDYKRrL4Gfa141uhesb3E5Z9IUWKGMWCk+Yj5/f0nn1V0lGIf9zg QE+rVvtG+DXT26A5nxyuagBEngH/yZrBKiqMFQ+N5kGWbfdFBHkEv/ZLkEMLby0ZiS0Z e6rA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="F/ilQoZV"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j6si5748653ejb.419.2019.11.20.01.03.48; Wed, 20 Nov 2019 01:04:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="F/ilQoZV"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728078AbfKTJAS (ORCPT + 99 others); Wed, 20 Nov 2019 04:00:18 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:40710 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728062AbfKTJAR (ORCPT ); Wed, 20 Nov 2019 04:00:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574240416; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=df2jZGkaKYIX8XGP45379iKP8na141nKrPLZMKk0bUg=; b=F/ilQoZVp+JWRDAwyJOnKsgprtNC1zi9PeKxiiwDW7+ahJBAH9SiwgvR6zRTk/b24bURKU EIo9/rLP158Pmffr01kYW6heo9LgfHLtX6BnMSvwg1/jG3ikkq2seY/5Vd7LgiL3E97oKI c13ebqfGIg0ShmAfXB6ZB4uGW+RVRRY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-108-eR3fDIFtNJibupG0o-ICCQ-1; Wed, 20 Nov 2019 04:00:13 -0500 Received: by mail-wm1-f72.google.com with SMTP id h191so4772032wme.5 for ; Wed, 20 Nov 2019 01:00:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=z+y/mrfI8ftCAoV6iK00SrByVRSNZiEo0o81DOjJrmQ=; b=mzZxKp8wibrqfVovd+WgSvh5OlNA6m4yNkgRTHFv4jSJ+mdDkVTe0DhNch9xa37mSv gaJQslqVybQRxUJVpAp8OTnxinKF/1NVOOiOMAmQPdyEtpZrnt1BA9sJ2hQ6JVvvfu7g OxD8Jy55a3h+kC9fwboAcR90E7VPi1XkzHGvctDlgDvCJpH4DXtqkmik+eoyo9njUBI7 i2FR/qGj4q+x6/QHfRXuLNyNrA1KqhdRw+eC+RSKE6lS+LNWL5WofNYHYiuZSORd2Ypk XHqHulqfBItmvEZOg/bYN2/yfYhgJzdnhAWmysQ1G3KLpCWmJ4qV68wE0/xeTOXK5/91 h+7g== X-Gm-Message-State: APjAAAVOZcwxXCOaPEktU55jUkWYoSW79v3jXfsM1OrReS3G5Da7BUCn 2nb6vw0CSdYTPe5mirbo3aFRgbCL4N4lRKJfmXgLggE8wSZptdt9dj+x2jbi9cdyubex4S/+a9x iUu5+XMq055+55pAnlUYGeQMW X-Received: by 2002:a5d:640b:: with SMTP id z11mr1744248wru.195.1574240412214; Wed, 20 Nov 2019 01:00:12 -0800 (PST) X-Received: by 2002:a5d:640b:: with SMTP id z11mr1744217wru.195.1574240411959; Wed, 20 Nov 2019 01:00:11 -0800 (PST) Received: from steredhat (a-nu5-32.tin.it. [212.216.181.31]) by smtp.gmail.com with ESMTPSA id m16sm5646172wml.47.2019.11.20.01.00.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Nov 2019 01:00:11 -0800 (PST) Date: Wed, 20 Nov 2019 10:00:08 +0100 From: Stefano Garzarella To: David Miller Cc: netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, decui@microsoft.com, stefanha@redhat.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, jhansen@vmware.com Subject: Re: [PATCH net-next 4/6] vsock: add vsock_loopback transport Message-ID: <20191120090008.qlfc3lnzwl6yudsf@steredhat> References: <20191119110121.14480-1-sgarzare@redhat.com> <20191119110121.14480-5-sgarzare@redhat.com> <20191119.171501.666690660172999834.davem@davemloft.net> MIME-Version: 1.0 In-Reply-To: <20191119.171501.666690660172999834.davem@davemloft.net> X-MC-Unique: eR3fDIFtNJibupG0o-ICCQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 19, 2019 at 05:15:01PM -0800, David Miller wrote: > From: Stefano Garzarella > Date: Tue, 19 Nov 2019 12:01:19 +0100 >=20 > > +static int vsock_loopback_cancel_pkt(struct vsock_sock *vsk) > > +{ > > +=09struct vsock_loopback *vsock; > > +=09struct virtio_vsock_pkt *pkt, *n; > > +=09int ret; > > +=09LIST_HEAD(freeme); >=20 > Reverse christmas tree ordering of local variables here please. >=20 Sure, I'll fix in the v2. Thanks, Stefano