Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751003AbWAPPmz (ORCPT ); Mon, 16 Jan 2006 10:42:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751005AbWAPPmz (ORCPT ); Mon, 16 Jan 2006 10:42:55 -0500 Received: from ns.virtualhost.dk ([195.184.98.160]:60260 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S1751003AbWAPPmy (ORCPT ); Mon, 16 Jan 2006 10:42:54 -0500 Date: Mon, 16 Jan 2006 16:44:50 +0100 From: Jens Axboe To: "Randy.Dunlap" Cc: ide , lkml , akpm , jgarzik Subject: Re: [PATCH 1/4] SATA ACPI build (applies to 2.6.16-git9) Message-ID: <20060116154450.GK3945@suse.de> References: <20060113224252.38d8890f.rdunlap@xenotime.net> <20060116123112.GZ3945@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1605 Lines: 44 On Mon, Jan 16 2006, Randy.Dunlap wrote: > On Mon, 16 Jan 2006, Jens Axboe wrote: > > > On Fri, Jan 13 2006, Randy.Dunlap wrote: > > > From: Randy Dunlap > > > > > > Add ata_acpi in Makefile and Kconfig. > > > Add ACPI obj_handle. > > > Add ata_acpi.c to libata kernel-doc template file. > > > > Randy, > > > > Any chance you can add PATA support as well for this? Many of the > > notebooks out there with SATA controllers really have PATA devices > > behind a bridge, I think it's pretty much a pre-requisite for this to be > > considered complete that this is supported as well. The code should be > > the same, it just needs to lookup the right taskfiles. Right now on this > > T43, it finds nothing. > > I'll add that to my list but I don't yet think that it's quite > as simple as you make it sound... It might not be, I'm totally acpi clueless :-) But the code factoring should look something like this: - Lookup taskfiles needed for resume (and suspend might need some, too?). This step requires looking for sata and pata taskfiles listed, so you'd need code for both. - Submit and check status of said taskfiles. This step is independent of the drive type. So step 1 is the one that needs extending, how much work that is I dunno since I have no clue on the actual lookup or the acpi data. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/