Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 20 Nov 2019 09:13:39 +0100
From:   Andreas Kemnade <andreas@kemnade.info>
To:     Pierre-Hugues Husson <phh@phh.me>
Cc:     Lee Jones <lee.jones@linaro.org>, a.zummo@towertech.it,
        alexandre.belloni@bootlin.com,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-rtc@vger.kernel.org, b.galvani@gmail.com, stefan@agner.ch,
        letux-kernel@openphoenux.org
Subject: Re: [PATCH v2 2/5] mfd: rn5t618: add irq support
Message-ID: <20191120091339.4de02ad0@kemnade.info>
In-Reply-To: <CAJ-oXjTQMgF+zzTkWz21yG4ZdAszSDKkiAqocBcUjyMNEd0ozQ@mail.gmail.com>
References: <20191031213835.11390-1-andreas@kemnade.info>
 <20191031213835.11390-3-andreas@kemnade.info>
 <CAJ-oXjTQMgF+zzTkWz21yG4ZdAszSDKkiAqocBcUjyMNEd0ozQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 20 Nov 2019 08:54:44 +0100
Pierre-Hugues Husson <phh@phh.me> wrote:

[...]
> >
> > +static int __maybe_unused rn5t618_i2c_suspend(struct device *dev)
> > +{
> > +       struct rn5t618 *priv = dev_get_drvdata(dev);
> > +
> > +       if (priv->chip_irq)
> > +               disable_irq(priv->chip_irq);
> > +
> > +       return 0;
> > +}
> > +
> > +static int __maybe_unused rn5t618_i2c_resume(struct device *dev)
> > +{
> > +       struct rn5t618 *priv = dev_get_drvdata(dev);
> > +
> > +       if (priv->chip_irq)
> > +               enable_irq(priv->chip_irq);
> > +
> > +       return 0;
> > +}  
> 
> For what it's worth, the boards I have (Archos 101 Oxygen and Pipo P9)
> with rc5t619 use GPIO for power button.
> So IRQ would need to be enabled in suspend for this to work.
> Also, since you actually added alarm support, perhaps you want to
> wake-up from suspend using alarm as well?
> 
Already tested that, that works, because device_init_wakeup() is used. 
disable_irq() is needed because we cannot do i2c that early after resume.
Other mfd drivers do thas as well and waking up works.

Regards,
Andreas