Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1844103ybc; Wed, 20 Nov 2019 05:06:26 -0800 (PST) X-Google-Smtp-Source: APXvYqy249Y2JVK98wAc1xlm4yLpVRSqUMTnPmOqZeCgCuWmU/PuBZNTBzRWSZBzuCm/rSMCbITy X-Received: by 2002:a17:906:d96c:: with SMTP id rp12mr5349003ejb.253.1574255186851; Wed, 20 Nov 2019 05:06:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574255186; cv=none; d=google.com; s=arc-20160816; b=R12WSqoEsi0TI1JlU5uufmITqq8OWHxsBSojDy6fceHZFYJfmkB0ZyC5T7KkQYrH2w 4AXcmG6uUFAYMiuJduQcC+2SV8/Nbvn2oNjx4P8vA02vh2mNsvK29r+cntiZQnsNxANU ZU5EgtVNwWOGUbS8qIwMJB+NLlun+NfAl8TEtX/4xAwb4xESBOKqcFVn7jiHCSRB9Dyu cv6e2QH6T2uaeBcbGViffF7jSaY5Sv5r8M6vcnQaQuAwgkraInnLHzx8+roBVnWkadG8 QZTo8DoVBVkUF+wOT8OcXp/jm8vn238Vy3nUeiOzmV7QcDALkPbATyI49ffl2lhS6kv8 x99g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Qa1HOgWorxjKthsLq8+DCnYeGvSI14alSe9b0Bdsrlo=; b=cms9L0XXpmT2ZI3HeIp3lpZi0eMpnzggZiSN0xoYa+K/ds18rdH04QQj7RICXZQAFG 660CgFSVcCMJLxjdy+zC1KX5gobAymo15aYfcbDNLblo1el/CoegF66v9EcH8xVoAzQ/ UXPa9Ioax6R7JiYROVjAuYPXwbgoC72PmGaqXmzkrPhpy9SrwfmTGuOm2swPuDhLxarM h865IKEa9unCcwoiDyKhk6fXitzvvGI2VcsKVyYtw2knborCTh536MFcDS+q/gaQOEMA UzLc3eynv2qtlYzGtNPMZU+s+xID1KNcWs6TdkmAWX155xO8nemwzirDMKicMqum5qAf FDKQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ca23si7838031ejb.341.2019.11.20.05.06.02; Wed, 20 Nov 2019 05:06:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728897AbfKTKwc (ORCPT + 99 others); Wed, 20 Nov 2019 05:52:32 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:37550 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727514AbfKTKwb (ORCPT ); Wed, 20 Nov 2019 05:52:31 -0500 Received: from [79.140.122.151] (helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iXNb3-0004ZQ-Vn; Wed, 20 Nov 2019 10:52:30 +0000 Date: Wed, 20 Nov 2019 11:52:29 +0100 From: Christian Brauner To: Luc Van Oostenryck Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Joel Fernandes , Christian Brauner Subject: Re: [PATCH v2] fork: fix pidfd_poll()'s return type Message-ID: <20191120105227.uln6z5d67ita3edj@wittgenstein> References: <20191120002145.skgtkx2f5dxagx4f@wittgenstein> <20191120003320.31138-1-luc.vanoostenryck@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191120003320.31138-1-luc.vanoostenryck@gmail.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 20, 2019 at 01:33:20AM +0100, Luc Van Oostenryck wrote: > pidfd_poll() is defined as returning 'unsigned int' but the > .poll method is declared as returning '__poll_t', a bitwise type. > > Fix this by using the proper return type and using the EPOLL > constants instead of the POLL ones, as required for __poll_t. > > Fixes: b53b0b9d9a61 ("pidfd: add polling support") > Cc: Joel Fernandes (Google) > Cc: Christian Brauner > Cc: stable@vger.kernel.org # 5.3 > Signed-off-by: Luc Van Oostenryck > Reviewed-by: Christian Brauner Applied to https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git/log/?h=fixes Will likely send this as a fix for v5.4 still so stable only has to backport this to 5.3 and not 5.4 too. Thanks! Christian