Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp1923160ybc; Wed, 20 Nov 2019 06:18:21 -0800 (PST) X-Google-Smtp-Source: APXvYqztkpFDbm2ZuHlFkQ7rB8zzFMomlbJneVs+QPA7Bo2Hlo8jAd1DAaj2BjcOt7quz/RwbDq+ X-Received: by 2002:a17:907:371:: with SMTP id rs17mr4492129ejb.0.1574259501201; Wed, 20 Nov 2019 06:18:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574259501; cv=none; d=google.com; s=arc-20160816; b=dMz8d3tX4xvclDyWAPXZ1qwPwp31FQUjS8CFt8iFEYVbnQHkXUHoQXpEI/jDpLpk61 ZSFeMpH8ODpvaqXWA9dLjGmlK91916O8wUB0joOgaqjMf+4QoMmDkuSZNlMbvWfZe0RK IyDMB1qseYOxmN33X29nfQOOzXS6T+Ah3RlkRFCS0Gr7k6zw1Slhq3bTeouYQbRXwI5W xkkz79DMO4ndDEItq43OHBgcUyDHluyeypctWP7zClqA1949GqcWA3LkUPLR7L3jO3/q sdjDgqr66ukw3X2fYYTDFVOmij9di/QWYL0NqVWwsyEitcPdSGhZ7a5aXjHORqdo0va9 c16Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=b/WA5k5NDIDUJi4qvjCN6XCxgftang+NNB2B42r+YCo=; b=ju2hMVW/PDXk0556N5n+x13jV/qZexAlmSduPlYUKjR0s1TohrnSdkXA9ZXxM28GoS oo5bWLppDvLkX+9Tm39VEKsHIjxrrfIht3J6IEOm1aE6p0ogtOGtMSsowjiADXMQiGfQ Qysp4DrV75WNmrzJb1JFkslWKcPwwFWjpkeT31x3TCsSQfFkRUEJAVktlfLeoDUz6Cav x1m97qlrMN0k1y6uPcvgJJNEOqGqMLPWiI/naNchDGMjIwZPxQoDHFQKvwxuWZ0g+hLJ Nd7G9OY9SX4Na8VC7bh9sz6SDvXQQShtKx1y4ywZGyB+amevLPuUPzLo6jW5NglU9iT4 34mw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hK4GR1x1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ov27si16134975ejb.197.2019.11.20.06.17.53; Wed, 20 Nov 2019 06:18:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hK4GR1x1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730703AbfKTODk (ORCPT + 99 others); Wed, 20 Nov 2019 09:03:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:60136 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727794AbfKTODj (ORCPT ); Wed, 20 Nov 2019 09:03:39 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E10AB2235D; Wed, 20 Nov 2019 14:03:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574258619; bh=Sr4kx3bxXDK/jq5hC3f7AbWAqNS3/0SiEpKAmoRIlEM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hK4GR1x1Abrl7VA11Xe8okhsIqIBZ/8CBV4CCQNg9xzjr2EdlHswxfpv0GARBJsD6 Yt4A+aUDzvXdO8Co0NiYLgBp8Zwhc893A9rZzaLEfMmXshu2XEnViewLnrQnADVglA R6W0Gemh0Vnet6WmV9ZMnWkhFhwbh2db7bsYFB10= Date: Wed, 20 Nov 2019 15:03:37 +0100 From: Greg Kroah-Hartman To: patrick.rudolph@9elements.com Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , Alexios Zavras , Allison Randal , Stephen Boyd , Samuel Holland , Julius Werner Subject: Re: [PATCH 2/2] firmware: google: Expose coreboot tables over sysfs Message-ID: <20191120140337.GC2935300@kroah.com> References: <20191120133958.13160-1-patrick.rudolph@9elements.com> <20191120133958.13160-3-patrick.rudolph@9elements.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191120133958.13160-3-patrick.rudolph@9elements.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 20, 2019 at 02:39:47PM +0100, patrick.rudolph@9elements.com wrote: > +static struct bin_attribute coreboot_attr_data = { > + .attr = { .name = "data", .mode = 0444 }, > + .read = table_data_read, > +}; BIN_ATTR_RO()? thanks, greg k-h