Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/2] mm/memory-failure.c: not necessary to recalculate
 hpage
To:     Wei Yang <richardw.yang@linux.intel.com>,
        n-horiguchi@ah.jp.nec.com, akpm@linux-foundation.org
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20191118082003.26240-1-richardw.yang@linux.intel.com>
 <20191118082003.26240-2-richardw.yang@linux.intel.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat GmbH
Message-ID: <fdba31c8-d0c0-83a8-62d1-c04c1e894218@redhat.com>
Date:   Wed, 20 Nov 2019 16:07:38 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.1
MIME-Version: 1.0
In-Reply-To: <20191118082003.26240-2-richardw.yang@linux.intel.com>
Content-Language: en-US
Content-Type: text/plain; charset=WINDOWS-1252; format=flowed
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 18.11.19 09:20, Wei Yang wrote:
> hpage is not changed.
>=20
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> ---
>   mm/memory-failure.c | 1 -
>   1 file changed, 1 deletion(-)
>=20
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 392ac277b17d..9784f4339ae7 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1319,7 +1319,6 @@ int memory_failure(unsigned long pfn, int flags)
>   =09=09}
>   =09=09unlock_page(p);
>   =09=09VM_BUG_ON_PAGE(!page_count(p), p);
> -=09=09hpage =3D compound_head(p);
>   =09}
>  =20
>   =09/*
>=20

I am *absolutely* no transparent huge page expert (sorry :) ), but won't=20
the split_huge_page(p) eventually split the compound page, such that=20
compound_head(p) will return something else after that call?

--=20

Thanks,

David / dhildenb