Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 20 Nov 2019 17:23:51 +0200
From:   Mika Westerberg <mika.westerberg@linux.intel.com>
To:     Mario.Limonciello@dell.com
Cc:     pmenzel@molgen.mpg.de, andreas.noever@gmail.com,
        michael.jamet@intel.com, YehezkelShB@gmail.com, ck@xatom.net,
        linux-kernel@vger.kernel.org, anthony.wong@canonical.com
Subject: Re: USB devices on Dell TB16 dock stop working after resuming
Message-ID: <20191120152351.GJ11621@lahna.fi.intel.com>
References: <5d2b39bc-5952-c2b6-63b3-bce28122ffd5@molgen.mpg.de>
 <20191104142459.GC2552@lahna.fi.intel.com>
 <20191104144436.GD2552@lahna.fi.intel.com>
 <20191104154446.GH2552@lahna.fi.intel.com>
 <ea829adedf0445c0845e25d6e4b47905@AUSX13MPC105.AMER.DELL.COM>
 <d8cb6bc6-8145-eaed-5ba4-d7291478bdd7@molgen.mpg.de>
 <20191104162103.GI2552@lahna.fi.intel.com>
 <f0257624-920e-eec4-a2ec-7adf8ecbcc9d@molgen.mpg.de>
 <20191120105048.GY11621@lahna.fi.intel.com>
 <ccfa5f1a1b5e475aa4ddcbed2297b9c4@AUSX13MPC105.AMER.DELL.COM>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ccfa5f1a1b5e475aa4ddcbed2297b9c4@AUSX13MPC105.AMER.DELL.COM>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 20, 2019 at 02:15:17PM +0000, Mario.Limonciello@dell.com wrote:
> > -----Original Message-----
> > From: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Sent: Wednesday, November 20, 2019 4:51 AM
> > To: Paul Menzel
> > Cc: Limonciello, Mario; Andreas Noever; Michael Jamet; Yehezkel Bernat; Christian
> > Kellner; linux-kernel@vger.kernel.org; Anthony Wong
> > Subject: Re: USB devices on Dell TB16 dock stop working after resuming
> > 
> > 
> > [EXTERNAL EMAIL]
> > 
> > On Tue, Nov 19, 2019 at 05:55:43PM +0100, Paul Menzel wrote:
> > > Dear Mika,
> > >
> > >
> > > On 2019-11-04 17:21, Mika Westerberg wrote:
> > > > On Mon, Nov 04, 2019 at 05:11:10PM +0100, Paul Menzel wrote:
> > >
> > > >> On 2019-11-04 16:49, Mario.Limonciello@dell.com wrote:
> > > >>
> > > >>>> From: Mika Westerberg <mika.westerberg@linux.intel.com>
> > > >>>> Sent: Monday, November 4, 2019 9:45 AM
> > > >>
> > > >>>> On Mon, Nov 04, 2019 at 04:44:40PM +0200, Mika Westerberg wrote:
> > > >>>>> On Mon, Nov 04, 2019 at 04:25:03PM +0200, Mika Westerberg wrote:
> > > >>
> > > >>>>>> On Mon, Nov 04, 2019 at 02:13:13PM +0100, Paul Menzel wrote:
> > > >>
> > > >>>>>>> On the Dell XPS 13 9380 with Debian Sid/unstable with Linux 5.3.7
> > > >>>>>>> suspending the system, and resuming with Dell’s Thunderbolt TB16
> > > >>>>>>> dock connected, the USB input devices, keyboard and mouse,
> > > >>>>>>> connected to the TB16 stop working. They work for a few seconds
> > > >>>>>>> (mouse cursor can be moved), but then stop working. The laptop
> > > >>>>>>> keyboard and touchpad still works fine. All firmware is up-to-date
> > > >>>>>>> according to `fwupdmgr`.
> > > >>>>>>
> > > >>>>>> What are the exact steps to reproduce? Just "echo mem >
> > > >>>>>> /sys/power/state" and then resume by pressing power button?
> > > >>
> > > >> GNOME Shell 3.34.1+git20191024-1 is used, and the user just closes the
> > > >> display. So more than `echo mem > /sys/power/state` is done. What
> > > >> distribution do you use?
> > > >
> > > > I have buildroot based "distro" so there is no UI running.
> > >
> > > Hmm, this is quite different from the “normal” use-case of the these devices.
> > > That way you won’t hit the bugs of the normal users. ;-)
> > 
> > Well, I can install some distro to that thing also :) I suppose Debian
> > 10.2 does have this issue, no?
> > 
> > > >>>>> I tried v5.4-rc6 on my 9380 with TB16 dock connected and did a couple of
> > > >>>>> suspend/resume cycles (to s2idle) but I don't see any issues.
> > > >>>>>
> > > >>>>> I may have older/different firmware than you, though.
> > > >>>>
> > > >>>> Upgraded BIOS to 1.8.0 and TBT NVM to v44 but still can't reproduce this
> > > >>>> on my system :/
> > > >>
> > > >> The user reported the issue with the previous firmwares 1.x and TBT NVM v40.
> > > >> Updating to the recent version (I got the logs with) did not fix the issue.
> > > >
> > > > I also tried v40 (that was originally on that system) but I was not able
> > > > to reproduce it.
> > > >
> > > > Do you know if the user changed any BIOS settings?
> > >
> > > We had to disable the Thunderbolt security settings as otherwise the USB
> > > devices wouldn’t work at cold boot either.
> > 
> > That does not sound right at all. There is the preboot ACL that allows
> > you to use TBT dock aready on boot. Bolt takes care of this.
> 
> Yeah it might be useful to enumerate all the BIOS settings that are selected
> related to Thunderbolt.  Some of them are a bit confusing.

BTW, I played a bit with 9380 and it looks like there is no option to
enable Preboot ACL which means that if you have TBT security enabled
(user or secure) the Dock PCIe side is not functional during boot, only
once the OS has booted up. That's fine unless you want to enter BIOS
menu from the keyboard you have connected to the TB16 dock (probably not
too common use case anyway).