Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp2135479ybc; Wed, 20 Nov 2019 09:24:31 -0800 (PST) X-Google-Smtp-Source: APXvYqychQbBLtP+fQJZ7Sg9ZhDnFApW/OACINDwLWnYjNtrjruGGRRXyFD//Jk6YODGWBwSR/ni X-Received: by 2002:a7b:c098:: with SMTP id r24mr4717296wmh.63.1574270671844; Wed, 20 Nov 2019 09:24:31 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1574270671; cv=pass; d=google.com; s=arc-20160816; b=v+jvLJU06JbZq0b/pOYhnbTzCmBE1BamGzm4DTIfmJSK9GDa3CbujTYEX7CPxoQY2w BebBYZrSbsN3z6jZl1FG6uRU18JTf4rhi6Dn34kvVeUh5O9zetH0uAtjD46MBbp7H4Os F3ZLW/2YLq3Ic7MDBqQvxeCoLUnUqJ+WfCjGixqxgOCMoGM5bEALFOUOwukbVYW+WF1y hu0wdZ9lHJnHoSm3CaVkTSfWG+eX56sZh/QWuzWM7Vy/VVLZ7crH9fckFBwy0ahBH+N0 VxzhHCBDBVu2cnQ4NF9eDt7sLi1e0b95O2J7CvhT2uHTT+pfAgER/zd/TDmxUoLmipS7 irRQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :wdcipoutbound:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:subject:cc:to :from:dkim-signature:ironport-sdr:dkim-signature; bh=Zhi7OPPz04NXRrxY67F7WDSlQ5RvMPEPZ8yIwHKevb8=; b=fjCSpBDvQTTgsM3ARTO4b4ZmvjwR6l0WUBSDYgf7WzXTSFzdhXh0Xj6Q53JNlVQi3r Z3/SMA3ez+IZ48+u8yEJM9IpAi/TsuiwcdRHWIphcN1h1tCKV/jbICaLgebwGcnbHKwg FzUSIuCY7qy2KtgfaOQuPZqaxmKxzpa8yuWPKGpUeR4xlgkek8e6XB/RYbJpMArfeuqb p7mGEcjCUTgfT3G9IPu5phiPbQ1x7nKKquxLO56t4i9NRGS/jinS/E7HhA0r8cEw3KGI ETl3aNwOC0+/0v+WHo9X4H7EthkfhmrRUGiBK4fHxRewHwVB9ipdbaDxJTRahN0AYe4b AoWQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=fail header.i=@wdc.com header.s=dkim.wdc.com header.b=WWt0qC1x; dkim=pass header.i=@sharedspace.onmicrosoft.com header.s=selector2-sharedspace-onmicrosoft-com header.b=YTKci9hY; arc=pass (i=1 spf=pass spfdomain=wdc.com dkim=pass dkdomain=wdc.com dmarc=pass fromdomain=wdc.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=wdc.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w25si18037901edl.418.2019.11.20.09.24.06; Wed, 20 Nov 2019 09:24:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@wdc.com header.s=dkim.wdc.com header.b=WWt0qC1x; dkim=pass header.i=@sharedspace.onmicrosoft.com header.s=selector2-sharedspace-onmicrosoft-com header.b=YTKci9hY; arc=pass (i=1 spf=pass spfdomain=wdc.com dkim=pass dkdomain=wdc.com dmarc=pass fromdomain=wdc.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=wdc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728796AbfKTPhD (ORCPT + 99 others); Wed, 20 Nov 2019 10:37:03 -0500 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:15794 "EHLO esa3.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727928AbfKTPhD (ORCPT ); Wed, 20 Nov 2019 10:37:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1574264222; x=1605800222; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Zhi7OPPz04NXRrxY67F7WDSlQ5RvMPEPZ8yIwHKevb8=; b=WWt0qC1xdewea6cziTY5zFm2NAh529pI7FS6qPg0Q4JGCAAnMTB45ad1 x3yy31K+U+XnaZ8/oKO1rW7gRbE3JsRcanHsjZT2XkpYBzdOWKbY1bXcS eg7j7msTvBemLEPpVfv5OWxZePIjYlTSrHb0WCdo57V4lrBm+ObbRUOhm jQLF1qWZvnWr+0nJpuOiJNxb3PtftcmVKfZzVl+JS6jrtBcDNPHJ5fr1z 339KYoXkm8JwnLa6HFwfvRHZmDnfvhmNzbSd5DpQo5mJcKbYQbsmiYAZd fgxotS1tiQvh5FgcVn1yUFYA9BlC+rACdwlpWRgGAJZ2epvdaGzGfIN/z w==; IronPort-SDR: 1Kik3GJrkoMtYr02KcjWRL22AdZcuVDXh1SC2sKl6ihrofnJP0ulIqLl6RS/qMvrPEspU4FJM7 1iwDlrrQlT2VGHJtt5i3PG/5gtusfeJxPiZVk9GORWsVvWFycBN9ffEdtnLnjCHEYMcqMZ0Kpq 4Z+JmsZd5wCHkKRynOpaDEY7ixUIy43OJ2NtfrUaAgnZXsPM0gMyV61gBScUML3rPHuXdwFSQN PkyovxqkMupeD4R0c/Pd+Rx0k77QdygmFOdwqXP86ZPyVUAIrcYVfg6AvWwDklNbgVnjr2p5/V IoM= X-IronPort-AV: E=Sophos;i="5.69,222,1571673600"; d="scan'208";a="127973499" Received: from mail-co1nam03lp2058.outbound.protection.outlook.com (HELO NAM03-CO1-obe.outbound.protection.outlook.com) ([104.47.40.58]) by ob1.hgst.iphmx.com with ESMTP; 20 Nov 2019 23:37:01 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b6nJ+P3wrC5eydvFxxz28S1ksBMXtnp6oW1xPAcoso9bwWDOm+HO9hUAkOAjcf6m0ZsgOU8FW3lus4C5g6xVRo7r7EGdGs4CCbn+oC/o29XRV3cRh/Kw08XFuF/RYgVp+cKlmTyFbDATYcQ7s/J92q9RnexHzfGK0u3tzjAlkAJzVVPtS4uSjDgjzfDAeNvl94rZkoKb2+RUf2O+19u1kQBrJlOHdT8YzvvbLId5wNiVSkmhNKFPmcOg8HjqsnLlXF2nQb39ifqnQ9qQEcy4oXScAO/NxcCYPvz4NqZZrAoYfL9ipIHU843D5gsyjc1AkBDQZd4e59YnEySUADkGiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zhi7OPPz04NXRrxY67F7WDSlQ5RvMPEPZ8yIwHKevb8=; b=Hx2wHLsWxmW9VjYCgfvq+9i8/qaXtumofpVViDfVvYUzWwmQf6+W78Iw9AIYJnGqSqDR1KIsZNiNLo8BiA5pnf6i8QeVT7ySi9/Y7om0qnSSYlC/+2Fm5NWhLES4PtTCLg6P2/njJiXc8Hasof331H9hTuYLaAB8OIXmCSVOwHiW0HKxkaGKhnR+sM6jpu51z+V48hoP7atyBcs/4LBP2KjH0coUJVHec9UEJSJqDdijb5DhQ2xY39sXNOFDp1QU9OMsTRQdtT5N55MA7ku4up3iuQJbhZXtRKrWIElQxxjEqOYpRBwspkOeLPiJHqyDcCV/JHN3V6ozCZG7TIMIqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zhi7OPPz04NXRrxY67F7WDSlQ5RvMPEPZ8yIwHKevb8=; b=YTKci9hYusn35hctImWdbBDTkzGRHikgxLpZ1XtjEyfxFi/+4D9+mwcIxz/AIct5XQMS0l+b/r2FQ3YEd/Pd4oPOW5YjmnXWSTIDrsOu55iRa4V/8072bqI7lgKZd6UrBf0iNVe7GJaao5P3x6PPPtdgKY/47SFEES602qYx0O0= Received: from MN2PR04MB6991.namprd04.prod.outlook.com (10.186.144.209) by MN2PR04MB5965.namprd04.prod.outlook.com (20.178.246.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2451.23; Wed, 20 Nov 2019 15:36:59 +0000 Received: from MN2PR04MB6991.namprd04.prod.outlook.com ([fe80::5852:6199:7952:c2ce]) by MN2PR04MB6991.namprd04.prod.outlook.com ([fe80::5852:6199:7952:c2ce%7]) with mapi id 15.20.2474.015; Wed, 20 Nov 2019 15:36:59 +0000 From: Avri Altman To: Can Guo , "asutoshd@codeaurora.org" , "nguyenb@codeaurora.org" , "rnayak@codeaurora.org" , "linux-scsi@vger.kernel.org" , "kernel-team@android.com" , "saravanak@google.com" , "salyzyn@google.com" CC: Alim Akhtar , Pedro Sousa , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Bean Huo , Tomas Winkler , open list Subject: RE: [PATCH v4 5/5] scsi: ufs: Do not free irq in suspend Thread-Topic: [PATCH v4 5/5] scsi: ufs: Do not free irq in suspend Thread-Index: AQHVmee9U/BswetsqkSHgDuGmRZmjqeUO0QQ Date: Wed, 20 Nov 2019 15:36:59 +0000 Message-ID: References: <1573624824-671-1-git-send-email-cang@codeaurora.org> <1573624824-671-6-git-send-email-cang@codeaurora.org> In-Reply-To: <1573624824-671-6-git-send-email-cang@codeaurora.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Avri.Altman@wdc.com; x-originating-ip: [212.25.79.133] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 43a1e46c-c6da-4c31-b534-08d76dcf7b93 x-ms-traffictypediagnostic: MN2PR04MB5965: x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 02272225C5 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(346002)(396003)(136003)(39860400002)(366004)(376002)(199004)(189003)(256004)(3846002)(86362001)(6506007)(11346002)(2906002)(33656002)(15650500001)(14454004)(5660300002)(99286004)(76116006)(486006)(110136005)(14444005)(76176011)(4326008)(316002)(54906003)(6436002)(9686003)(6246003)(476003)(55016002)(4744005)(71190400001)(229853002)(446003)(8936002)(71200400001)(478600001)(74316002)(102836004)(26005)(25786009)(7696005)(66066001)(2201001)(186003)(66446008)(305945005)(8676002)(7416002)(52536014)(2501003)(81156014)(81166006)(7736002)(64756008)(66946007)(66476007)(66556008)(6116002);DIR:OUT;SFP:1102;SCL:1;SRVR:MN2PR04MB5965;H:MN2PR04MB6991.namprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: imdPebxp/J1mPIH3LHRNJQmAgHMInOAsbku2ZEvi7z+0NgMPxAtWlIj83H6vQcl3q48MXfL/k9vaUjiGhWBULrkolOxIcgEpM0MoPGQw51vtUffSYSvCybxtY4iXM/Mx57iZABEorNwFnZuZM6e7P0ZyI345JlCg4vJYYi1aYFjCC1pC6qQ+J4fixtunLrnbgbo30fVpMkVT8On0rHZgqbZBenv8d4GyGBEmJU0h1r0rEauzoTO7R4QrXH3J4kt4oWQDvpRFReVCbvyvLomC9YwiCgrIVIPzi6cI4JNLiRlnh8b6h0+c2Q3+fpn6B2lJzh0xpJQ0hIN4Onh6M2TJx/psHjtwWDFbX9e965JJY08u/ReoncAtO2c/ichUFmWDZDcs0DZqsuQYNxdMcRRfro9ZOEGZodf6ZjZ+UXUpotvyo3IRCo3kmLM0HsKj2YZZ x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43a1e46c-c6da-4c31-b534-08d76dcf7b93 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2019 15:36:59.3358 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2T9DGfK2dVQ7pdgaDkSAzFyvwI9HAJgPKbXnmFn3ZHsk0Z/WxTMfU66R+3oSbH7Ju8A9gl29ZiVc5K6daX3umA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB5965 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =20 >=20 > If PM QoS is enabled and we set request type to PM_QOS_REQ_AFFINE_IRQ > then freeing up the irq makes the free_irq() print out warning with call = stack. > We don't really need to free up irq during suspend, disabling it during s= uspend > and reenabling it during resume should be good enough. >=20 > Signed-off-by: Can Guo Your approach seems reasonable, However I failed to locate in the kernel PM_QOS_REQ_AFFINE_IRQ, Just in codeaurora. Is the WARN_ON in free_irq still applies? Thanks, Avri