Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191120040045.81115-1-saravanak@google.com>
In-Reply-To: <20191120040045.81115-1-saravanak@google.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Wed, 20 Nov 2019 10:09:48 -0600
Message-ID: <CAL_JsqJ4JQ7Oop5oWUYRCNA-xQrd0svQSPrp+y1F+Qux9xTRrQ@mail.gmail.com>
Subject: Re: [PATCH] of: Reduce log level of of_phandle_iterator_next()
To:     Saravana Kannan <saravanak@google.com>
Cc:     Frank Rowand <frowand.list@gmail.com>,
        Android Kernel Team <kernel-team@android.com>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Nov 19, 2019 at 10:00 PM Saravana Kannan <saravanak@google.com> wrote:
>
> These error messages are mostly useful for debugging malformed device
> tree data.

A malformed DT is an error, no?

> So change these messages from error to debug messages to
> avoid spamming the end user. Any error messages that might actually be
> useful to the user is probably going to come from the caller of these
> APIs. So leave it to them to decide if they need to print any error
> messages.

Generally that pattern results in every caller doing their own message
which is the wrong way around IMO. And recent patches fix some of
those cases[1].

Rob

[1] https://lkml.org/lkml/2019/7/30/41