Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 20 Nov 2019 19:05:52 +0100 (CET)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Davidlohr Bueso <dave@stgolabs.net>
cc:     mingo@kernel.org, peterz@infradead.org, bp@alien8.de,
        x86@kernel.org, linux-kernel@vger.kernel.org,
        Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH 1/4] x86/mm, pat: Convert pat tree to generic interval
 tree
In-Reply-To: <20191021231924.25373-2-dave@stgolabs.net>
Message-ID: <alpine.DEB.2.21.1911201901270.29534@nanos.tec.linutronix.de>
References: <20191021231924.25373-1-dave@stgolabs.net> <20191021231924.25373-2-dave@stgolabs.net>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 21 Oct 2019, Davidlohr Bueso wrote:
>  int rbt_memtype_check_insert(struct memtype *new,
>  			     enum page_cache_mode *ret_type)
>  {
>  	int err = 0;
>  
>  	err = memtype_rb_check_conflict(&memtype_rbroot, new->start, new->end,
> -						new->type, ret_type);
> -
> -	if (!err) {
> -		if (ret_type)
> -			new->type = *ret_type;
> -
> -		new->subtree_max_end = new->end;
> -		memtype_rb_insert(&memtype_rbroot, new);
> -	}
> +					new->type, ret_type);
> +	if (err)
> +		goto done;

Please return err here. That goto is pointless.

> +
> +	if (ret_type)
> +		new->type = *ret_type;
> +	memtype_interval_insert(new, &memtype_rbroot);
> +done:
>  	return err;
>  }

Other than that.

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>