Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Dragan Cvetic <draganc@xilinx.com>
To:     Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Derek Kiernan <dkiernan@xilinx.com>
Subject: RE: [PATCH] misc: xilinx_sdfec: fix xsdfec_poll()'s return type
Thread-Topic: [PATCH] misc: xilinx_sdfec: fix xsdfec_poll()'s return type
Thread-Index: AQHVnzbvRwd5Ss/ZH0ugJQL96aPqOKeUNshQgAAkIoCAABHVkA==
Date:   Wed, 20 Nov 2019 19:08:49 +0000
Message-ID: <CH2PR02MB6359A3A9D842021B15E89E7BCB4F0@CH2PR02MB6359.namprd02.prod.outlook.com>
References: <20191120001030.30779-1-luc.vanoostenryck@gmail.com>
 <CH2PR02MB6359CE45D06E908634CDA855CB4F0@CH2PR02MB6359.namprd02.prod.outlook.com>
 <20191120180229.frd5padrsdxf7hag@ltop.local>
In-Reply-To: <20191120180229.frd5padrsdxf7hag@ltop.local>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: xilinx.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0db8a9bc-c31a-4717-1dd0-08d76ded1332
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2019 19:08:49.1943
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: r0efDqtYW18IlrKd9zmuYFjJRVJ/Uw52WMKMCmsgnYM196L7OVVpTO4K9JtXxcW44JnKJ5SX/2o+9zYjb4Fndw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB6150
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Luc,

Thanks for the really useful answer.

I promise I'll test this soon.

Thanks
Dragan


> -----Original Message-----
> From: Luc Van Oostenryck [mailto:luc.vanoostenryck@gmail.com]
> Sent: Wednesday 20 November 2019 18:02
> To: Dragan Cvetic <draganc@xilinx.com>
> Cc: linux-kernel@vger.kernel.org; Derek Kiernan <dkiernan@xilinx.com>
> Subject: Re: [PATCH] misc: xilinx_sdfec: fix xsdfec_poll()'s return type
>=20
> On Wed, Nov 20, 2019 at 03:59:24PM +0000, Dragan Cvetic wrote:
> > Hi Luc,
> >
> > For the sake of my understanding I'd like to ask you when the .pole met=
hod is defined
> > Why I'm asking this? I have a fairly new book (published in 2017) which=
 suggests what is implemented in SDFEC driver.
> >
> > I'll test your suggestions and will come back to you soon.
>=20
> Well, yes, it changed in July 2017.
>=20
> The current definition can be found in include/linux/fs.h:
> 	struct file_operations {
> 		...
> 		__poll_t (*poll) (struct file *, struct poll_table_struct *);
> 		...
>=20
> The main commit making the change is:
>     a3f8683bf7d5 ("->poll() methods should return __poll_t")
>=20
>=20
> The result can be verified by compiling the driver with the command
> 	make C=3D2 path/to/the/driver.o
> which will use the static analyser 'sparse' to make additional checks
> where the difference between 'unsigned int' and __poll_t will matter.
> See Documentation/dev-tools/sparse.rst for more info about it.
>=20
> Best regards,
> -- Luc Van Oostenryck