Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp2460060ybc; Wed, 20 Nov 2019 14:45:04 -0800 (PST) X-Google-Smtp-Source: APXvYqxiCDx8+OHJ3E1l4hLTnfsIzzQqqRMDdOGXea1OegFWv62skPZYzF+6Ft1ZuWhuC1QcK8XU X-Received: by 2002:a17:906:1c07:: with SMTP id k7mr8265129ejg.229.1574289903938; Wed, 20 Nov 2019 14:45:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574289903; cv=none; d=google.com; s=arc-20160816; b=cTqa4DwQ5lQe/+O4UJL2qRy9KNWiRJVtuscL/NqQZQynwW5Qi3Gl4dWNVL6kSajV5N cY1aVU/DEKnJBdESsVor7TeVUdNdIz9VRlC9MC9PPSUNLYrXR1InSBdCpQoEyZLpOSnw o54RwvwqBm1anF/aK21RNI0Uu1D8LX1gMESRkowen3NyHvRvxBDwfr2IvbfqvaCYgexL WPhcZAos9yslw0ssuhts4E2eAAlVNqFwMc9nKvyqL16y/ga60u3ZcBMAzQBHFo8Sdu0g pA6E0zczQ9k8kNB0GgdPrHwu9gK9VxD2LCjU6Zfwo26V3o+B19O9vALUzRuDpb18hp35 bKEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:organization:references:in-reply-to:date:cc:to:from :subject:message-id; bh=CyIsyWuteO8AT1KutedO2mWufIMcBYkGSeUuIKxOTKY=; b=vpsTXMGVW9fxYTp6hz1NE5zk08iCikoaPMrYbw2b4u1/LXyfPMrdVPOqOSUWonm5f/ KLArUrSvfEjS4s91NA2Q3Wa+DpIbPSRQOMusYN3uVmfGOd6ZuxTxANfkHwvrFC8x2ez2 lbcEg5XCkd3Pn9WN/aTyzYsuRc+51N2sKdCfznEOY8l9/3AwkPvdWAWnpgd4eVU0wY70 5LuxL8avefq5bBHddNlnw81iwnBURhAeB/nYZJa4IhXgQZdIF7b5rAJadX3M7OsuChpT qp9Wj3bB/0dAdMmM7V25O7CBuJkbQHq8O5jWt43WON9nE1ZcvXinwDot4ate9XraDgrj XA7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codethink.co.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y18si647117edr.347.2019.11.20.14.44.37; Wed, 20 Nov 2019 14:45:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codethink.co.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726083AbfKTWnY (ORCPT + 99 others); Wed, 20 Nov 2019 17:43:24 -0500 Received: from imap1.codethink.co.uk ([176.9.8.82]:37287 "EHLO imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725842AbfKTWnY (ORCPT ); Wed, 20 Nov 2019 17:43:24 -0500 Received: from [167.98.27.226] (helo=xylophone) by imap1.codethink.co.uk with esmtpsa (Exim 4.84_2 #1 (Debian)) id 1iXYgs-0006FE-Oe; Wed, 20 Nov 2019 22:43:14 +0000 Message-ID: <4faa78cd0a86cf5d0aea9bb16d03145c5745450b.camel@codethink.co.uk> Subject: Re: [Y2038] [PATCH 07/23] y2038: vdso: powerpc: avoid timespec references From: Ben Hutchings To: Arnd Bergmann , y2038@lists.linaro.org, Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Cc: Christophe Leroy , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Nicholas Piggin , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, Allison Randal Date: Wed, 20 Nov 2019 22:43:13 +0000 In-Reply-To: <20191108210824.1534248-7-arnd@arndb.de> References: <20191108210236.1296047-1-arnd@arndb.de> <20191108210824.1534248-7-arnd@arndb.de> Organization: Codethink Ltd. Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2019-11-08 at 22:07 +0100, Arnd Bergmann wrote: [...] > --- a/arch/powerpc/kernel/vdso32/gettimeofday.S > +++ b/arch/powerpc/kernel/vdso32/gettimeofday.S > @@ -15,10 +15,8 @@ > /* Offset for the low 32-bit part of a field of long type */ > #if defined(CONFIG_PPC64) && defined(CONFIG_CPU_BIG_ENDIAN) > #define LOPART 4 > -#define TSPEC_TV_SEC TSPC64_TV_SEC+LOPART > #else > #define LOPART 0 > -#define TSPEC_TV_SEC TSPC32_TV_SEC > #endif > > .text > @@ -192,7 +190,7 @@ V_FUNCTION_BEGIN(__kernel_time) > bl __get_datapage@local > mr r9, r3 /* datapage ptr in r9 */ > > - lwz r3,STAMP_XTIME+TSPEC_TV_SEC(r9) > + lwz r3,STAMP_XTIME_SEC+LOWPART(r9) "LOWPART" should be "LOPART". > > cmplwi r11,0 /* check if t is NULL */ > beq 2f > @@ -268,7 +266,7 @@ __do_get_tspec: > * as a 32.32 fixed-point number in r3 and r4. > * Load & add the xtime stamp. > */ > - lwz r5,STAMP_XTIME+TSPEC_TV_SEC(r9) > + lwz r5,STAMP_XTIME_SEC+LOWPART(r9) Same here. > lwz r6,STAMP_SEC_FRAC(r9) > addc r4,r4,r6 > adde r3,r3,r5 [...] -- Ben Hutchings, Software Developer Codethink Ltd https://www.codethink.co.uk/ Dale House, 35 Dale Street Manchester, M1 2HF, United Kingdom