Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] erofs: drop all vle annotations for runtime names
To:     Gao Xiang <gaoxiang25@huawei.com>, Chao Yu <chao@kernel.org>,
        <linux-erofs@lists.ozlabs.org>
CC:     <linux-kernel@vger.kernel.org>, Gao Xiang <xiang@kernel.org>
References: <20191108032526.40762-1-gaoxiang25@huawei.com>
 <20191108033733.63919-1-gaoxiang25@huawei.com>
From:   Chao Yu <yuchao0@huawei.com>
Message-ID: <c12e9c9d-74ed-2beb-4e07-f9fdd731d00f@huawei.com>
Date:   Thu, 21 Nov 2019 09:12:41 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20191108033733.63919-1-gaoxiang25@huawei.com>
Content-Type: text/plain; charset="windows-1252"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2019/11/8 11:37, Gao Xiang wrote:
> VLE was an old informal name of fixed-sized output
> compression came from released ATC'19 paper [1].
> 
> Drop those old annotations since erofs can handle
> all encoded clusters in block-aligned basis, which
> is wider than fixed-sized output compression after
> larger clustersize feature is fully implemented.
> 
> Unaligned encoded data won't be considered in EROFS
> since it's not friendly to inplace I/O and decompression
> inplace.
> 
> a) Fixed-sized output compression with 16KB pcluster:
>   ___________________________________
>  |xxxxxxxx|xxxxxxxx|xxxxxxxx|xxxxxxxx|
>  |___ 0___|___ 1___|___ 2___|___ 3___| physical blocks
> 
> b) Block-aligned fixed-sized input compression with
>    16KB pcluster:
>   ___________________________________
>  |xxxxxxxx|xxxxxxxx|xxxxxxxx|xxx00000|
>  |___ 0___|___ 1___|___ 2___|___ 3___| physical blocks
> 
> c) Block-unaligned fixed-sized input compression with
>    16KB compression unit:
>   ____________________________________________
>  |..xxxxxx|xxxxxxxx|xxxxxxxx|xxxxxxxx|x.......|
>  |___ 0___|___ 1___|___ 2___|___ 3___|___ 4___| physical blocks
> 
> Refine better names for those as well.
> 
> [1] https://www.usenix.org/conference/atc19/presentation/gao
> 
> Cc: Chao Yu <yuchao0@huawei.com>
> Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,