Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Namjae Jeon" <namjae.jeon@samsung.com>
To:     =?windows-1257?Q?'Valdis_Kl=E7tnieks'?= <valdis.kletnieks@vt.edu>
Cc:     "'Nikolay Borisov'" <nborisov@suse.com>,
        <gregkh@linuxfoundation.org>, <hch@lst.de>, <linkinjeon@gmail.com>,
        <Markus.Elfring@web.de>, <sj1557.seo@samsung.com>,
        <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
In-Reply-To: <87255.1574306312@turing-police>
Subject: RE: [PATCH v2 05/13] exfat: add file operations
Date:   Thu, 21 Nov 2019 12:39:30 +0900
Message-ID: <010201d5a01d$48493270$d8db9750$@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="windows-1257"
Content-Transfer-Encoding: 7bit
Content-Language: ko
Thread-Index: AQEo1XJlLzywHhHshRBLsQkFEP9+bwE2rzOUAX+3+6QCnhKN6gFMKmQnAnC4oSSopgQxUA==
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20191119071107.1947-1-namjae.jeon@samsung.com>
        <CGME20191119071404epcas1p4f8df45690c07c4dd032af9cbfb5efcc6@epcas1p4.samsung.com>
        <20191119071107.1947-6-namjae.jeon@samsung.com>
        <398eeca9-e59f-385b-791d-561e56567026@suse.com>
        <00d201d5a00c$e6273ac0$b275b040$@samsung.com>
        <87255.1574306312@turing-police>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> 
> On Thu, 21 Nov 2019 10:42:13 +0900, "Namjae Jeon" said:
> 
> > > > +		if (clu.flags == 0x03) {
> > >
> > > That 0x03 is magic constant, better define actual flags and check
> > > clu.flag == (FLAG1|FLAG2)
> > Okay, Will fix it on v4.
> 
> Make sure you catch all the cases.  I seem to remember a lot of 0x01's
> in the code as well....
Yes, I know.
Thanks!