Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Fail (protection.outlook.com: domain of arm.com does not
 designate 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
From:   "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
To:     Mihail Atanassov <Mihail.Atanassov@arm.com>
CC:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        David Airlie <airlied@linux.ie>,
        Liviu Dudau <Liviu.Dudau@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        nd <nd@arm.com>, Sean Paul <sean@poorly.run>
Subject: Re: drm/komeda: Remove unnecessary komeda_wb_connector_detect
Thread-Topic: drm/komeda: Remove unnecessary komeda_wb_connector_detect
Thread-Index: AQHVoDWlPqB60NeFLUufwrTo5mSxsw==
Date:   Thu, 21 Nov 2019 06:33:54 +0000
Message-ID: <20191121063347.GA25271@jamwan02-TSP300>
References: <20191120120348.37340-1-mihail.atanassov@arm.com>
In-Reply-To: <20191120120348.37340-1-mihail.atanassov@arm.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Mutt/1.10.1 (2018-07-13)
Authentication-Results-Original: spf=none (sender IP is )
 smtp.mailfrom=james.qian.wang@arm.com; 
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 4fab43cd-d876-4053-32b2-08d76e4ccdd3
X-MS-TrafficTypeDiagnostic: VE1PR08MB5037:|VE1PR08MB5037:|AM5PR0802MB2417:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: <AM5PR0802MB241796BC6A35F296AE99F5E9B34E0@AM5PR0802MB2417.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
x-ms-oob-tlc-oobclassifiers: OLM:1468;OLM:1468;
x-forefront-prvs: 0228DDDDD7
X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(7916004)(4636009)(136003)(346002)(396003)(39850400004)(376002)(366004)(189003)(199004)(5660300002)(316002)(33716001)(25786009)(66066001)(8676002)(102836004)(6636002)(64756008)(66446008)(66476007)(33656002)(3846002)(2906002)(6512007)(66946007)(99286004)(86362001)(52116002)(229853002)(386003)(6506007)(76176011)(6436002)(6486002)(54906003)(6862004)(6246003)(4326008)(9686003)(6116002)(66556008)(7736002)(305945005)(446003)(14454004)(11346002)(478600001)(71190400001)(8936002)(1076003)(71200400001)(186003)(58126008)(26005)(14444005)(256004)(81156014)(55236004)(81166006);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR08MB5037;H:VE1PR08MB5006.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: zZkBPE9o8CM1aaJb08NxuuULVBTJY5GDFJWZYgPyyP2+xjhuXdb6g8E3O1qFcFhLFP/jNeNEcKARXZXpAEW5HsIb2ocwwR20CW91PRXM3S6EvY2lf+N9pfF1f3djPlRAth5Xco70DN/uhgn/3rtRvPMG848/Q35qRMwapw3TzVZtcpyk8+EYd5o9UG/0dkq8/hSL1TK8RMRuoW40WdhDj2Okw+D1jTfVSIIxqzfxxJGT/8kXv0tCsPWLJ0CrESlFq6/akeYYCzWrNfdKY/JBCmBMpACupCESVupFl5btu/D0jp7STCuzp63lrFuGN211hTprEr+vjkD7WB4TIflnWY+Z1b9vJRb3BIksIN4j+EzuYewZHX+rJmdOGPaYulmKgIsRdpffPsp5Hp55azXReFNjTsrQGQDFApEoT4G4S4fT/tLx7nWSBAvwV6q461a2
Content-Type: text/plain; charset="us-ascii"
Content-ID: <38FC27F944BE454FB1A4131BB69BFEFB@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5037
Original-Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=james.qian.wang@arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT037.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(7916004)(4636009)(136003)(396003)(346002)(376002)(39850400004)(1110001)(339900001)(189003)(199004)(33716001)(6246003)(305945005)(2906002)(99286004)(33656002)(25786009)(1076003)(8936002)(23726003)(3846002)(8676002)(446003)(6862004)(70206006)(70586007)(6116002)(50466002)(26826003)(4326008)(6636002)(356004)(478600001)(76130400001)(66066001)(8746002)(76176011)(14454004)(47776003)(26005)(46406003)(22756006)(107886003)(102836004)(5660300002)(11346002)(7736002)(336012)(9686003)(386003)(6506007)(97756001)(81156014)(14444005)(54906003)(81166006)(58126008)(6512007)(186003)(6486002)(316002)(229853002)(86362001)(105606002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR0802MB2417;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:Fail;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;MX:1;A:1;
X-MS-Office365-Filtering-Correlation-Id-Prvs: 03bf7d68-17fc-480c-f4ef-08d76e4cc7b8
NoDisclaimer: True
X-Forefront-PRVS: 0228DDDDD7
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: DMcReVG5szreuRh+P0zkP//OytoEBFHRPBuAEdb70cgNmoFQ6aX8mFixAr8Bjb60NGPKqbhOfuTNes/JqI5TRoElpqj0LN1yL9NU7p0q7xymPb0VFOd4kaC6NLbdFw96gXU/pyPW8ZFvmh4QObZGhIBJpWnqhleKJ+PnosOuupbx1uzFSVWrpJX7zXDXjcU5KMHqFVYkYkn7BfjKgwqqWVjUhSzcWYszsUj4JmG2CLOn+x1juRPk6WggRpDDIkOu38MnG0drQrtrHqPSAw/hv6sPyJoXFhiG7Zvh7ckXd0tcGw2yiW1pEoJvcPwqpaNuvVVWVZYKFWDkdM0nihllaEDcNmSHqqs80ePf3qL7SKbZXgbvtHmvciVsN6i9Fi+QvY+PocKi6h9p/1ropGw95+Q68dJrHcV3gnEpe1y8CDU07B3blUewR2fRk3xBaZvQ
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2019 06:34:04.5404
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4fab43cd-d876-4053-32b2-08d76e4ccdd3
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2417
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 20, 2019 at 12:03:55PM +0000, Mihail Atanassov wrote:
> The func is optional and the connector will report as always connected,
> i.e. no change in behaviour.
>=20
> Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 7 -------
>  1 file changed, 7 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/d=
rivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> index e465cc4879c9..c89ecdba8c28 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c
> @@ -107,12 +107,6 @@ static const struct drm_connector_helper_funcs komed=
a_wb_conn_helper_funcs =3D {
>  	.mode_valid	=3D komeda_wb_connector_mode_valid,
>  };
> =20
> -static enum drm_connector_status
> -komeda_wb_connector_detect(struct drm_connector *connector, bool force)
> -{
> -	return connector_status_connected;
> -}
> -
>  static int
>  komeda_wb_connector_fill_modes(struct drm_connector *connector,
>  			       uint32_t maxX, uint32_t maxY)
> @@ -128,7 +122,6 @@ static void komeda_wb_connector_destroy(struct drm_co=
nnector *connector)
> =20
>  static const struct drm_connector_funcs komeda_wb_connector_funcs =3D {
>  	.reset			=3D drm_atomic_helper_connector_reset,
> -	.detect			=3D komeda_wb_connector_detect,
>  	.fill_modes		=3D komeda_wb_connector_fill_modes,
>  	.destroy		=3D komeda_wb_connector_destroy,
>  	.atomic_duplicate_state	=3D drm_atomic_helper_connector_duplicate_state=
,

Looks good to me.

Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.co=
m>