Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp2959489ybc; Thu, 21 Nov 2019 00:51:11 -0800 (PST) X-Google-Smtp-Source: APXvYqz8Dg8ayyQWgmGrtuSAs22EGhqFJNAEoSaYYAaa9IFFbU8qVgGtgPDjJtLduIb5RrHUcpnq X-Received: by 2002:a17:906:7c5:: with SMTP id m5mr12153370ejc.231.1574326270981; Thu, 21 Nov 2019 00:51:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574326270; cv=none; d=google.com; s=arc-20160816; b=ezJLo/WI2A5kBlUHmKT8ze5V/xrgbAn6b2VxSJ6KiOMMkawYHSrNfxjKLbob/pJSgO vJzT+GXsYBaKwyBOLWLo4kI/D9r4nuO5vKmffUd1xeD9GHwBCeKdQytdM3tyihlimyMm yVe5ALQlJl1vRtq2PWHPgVRPRiNmtWM02eDrDtZzP26UbueJkx0A7RsjzLpkw/YO2PXN W0qNth9QRle/uDASFktrM0xF8G26AT1QhRabCSCSjHa+qZt7ZjeFKw9NpoSEUR5iYLR/ //yUJ8V0rlmSwMZCWG/sg9FfDuQHQ8lsJMlEN4+y2EmcLYz+I1Vrlev78DH7utiaU8O0 QZOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=LUozIY7AcPxWiAcGmvc7A/lbDB8ce0R4cY3LnSlGY7k=; b=obaQfLVVnUqwWLPOEDBkCEpwNB1sKgVNJcwDrHAc7w5xKDLdcIf0eIS4n/TABN3jj7 1cYxH+Kf71sL5EMz9+cpm658BFfmknA4ITVVs+pzWSXYJmvUqB5Knc7asxBEoZWVRiWn VK2QHHQgLKxzsSRDeek8WwiLudbfBMGKar/bsmHXNYIY8tFoWMKOeND/PI24o4O2mCZz 7F6+OboRNWrErr5O5hPongdk5tUbBngPp1PzIHr3VxDbKV801fWhRBGixaVxRhMQ108m RBFg3SJWxedsT74Rf9hALeOisY3zHHomSJHYnnzu2rSD/2IphbHdcCdZwrmLRik0A+y1 9Q1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 24si1353825eje.293.2019.11.21.00.50.47; Thu, 21 Nov 2019 00:51:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726638AbfKUItk (ORCPT + 99 others); Thu, 21 Nov 2019 03:49:40 -0500 Received: from www62.your-server.de ([213.133.104.62]:34272 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726132AbfKUItk (ORCPT ); Thu, 21 Nov 2019 03:49:40 -0500 Received: from [2a02:1205:507e:bf80:bef8:7f66:49c8:72e5] (helo=localhost) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1iXi9f-0002It-P2; Thu, 21 Nov 2019 09:49:35 +0100 Date: Thu, 21 Nov 2019 09:49:35 +0100 From: Daniel Borkmann To: =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= Cc: Luc Van Oostenryck , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Alexei Starovoitov , Magnus Karlsson , Jonathan Lemon , bpf Subject: Re: [PATCH] xsk: fix xsk_poll()'s return type Message-ID: <20191121084935.GB31576@pc-11.home> References: <20191120001042.30830-1-luc.vanoostenryck@gmail.com> <103f550e-4a78-e540-4a57-bdecc2f066cf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <103f550e-4a78-e540-4a57-bdecc2f066cf@intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.101.4/25639/Wed Nov 20 11:02:53 2019) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 20, 2019 at 07:15:42AM +0100, Bj?rn T?pel wrote: > On 2019-11-20 01:10, Luc Van Oostenryck wrote: > > xsk_poll() is defined as returning 'unsigned int' but the > > .poll method is declared as returning '__poll_t', a bitwise type. > > > > Fix this by using the proper return type and using the EPOLL > > constants instead of the POLL ones, as required for __poll_t. > > Thanks for the cleanup! > > Acked-by: Bj?rn T?pel > > Daniel/Alexei: This should go through bpf-next. Done, applied, thanks!