Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Shubhrajyoti Datta <shubhraj@xilinx.com>
To:     Rob Herring <robh@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        Michal Simek <michals@xilinx.com>
Subject: RE: [RFC PATCHv2 1/3] dt-bindings: misc: Add dt bindings for flex noc
 Performance Monitor
Thread-Topic: [RFC PATCHv2 1/3] dt-bindings: misc: Add dt bindings for flex
 noc Performance Monitor
Thread-Index: AQHVdCmZoFI17g0Ymkq7XWhFdff3yqdUgJwAgEEqGnA=
Date:   Thu, 21 Nov 2019 09:04:38 +0000
Message-ID: <MN2PR02MB60943664B80D3028F8422175AA4E0@MN2PR02MB6094.namprd02.prod.outlook.com>
References: <2de75a74ef4086090c532d3b80b7d6dcd115e45e.1569474867.git.shubhrajyoti.datta@xilinx.com>
 <20191010214835.GA4523@bogus>
In-Reply-To: <20191010214835.GA4523@bogus>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: xilinx.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: cf6c2898-cba2-45d2-3edc-08d76e61d6d7
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2019 09:04:38.9659
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YbfSKlMGQOOHoSw5IT7XlljKal00oJN53jV+MZSpFMW9+Q0GnBap+uoaxJktR10Q6GvW79ISx1r1ihUiyufcOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR02MB6398
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi,

> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Friday, October 11, 2019 3:19 AM
> To: Shubhrajyoti Datta <shubhraj@xilinx.com>
> Cc: linux-kernel@vger.kernel.org; devicetree@vger.kernel.org;
> arnd@arndb.de; gregkh@linuxfoundation.org; Michal Simek
> <michals@xilinx.com>
> Subject: Re: [RFC PATCHv2 1/3] dt-bindings: misc: Add dt bindings for fle=
x noc
> Performance Monitor
>=20
> On Thu, Sep 26, 2019 at 10:46:24AM +0530, Shubhrajyoti Datta wrote:
> > Add dt bindings for flexnoc Performance Monitor.
> > The flexnoc counters for read and write response and requests are
> > supported.
> >
> > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> > ---
> >  .../devicetree/bindings/misc/xlnx,flexnoc.txt      | 24
> ++++++++++++++++++++++
>=20
> bindings/perf/
>=20
> Please convert this to a schema. See
> Documentation/devicetree/writing-schema.rst.
Ok=20
>=20
> >  1 file changed, 24 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt
> >
> > diff --git a/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt
> > b/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt
> > new file mode 100644
> > index 0000000..6b533bc
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/misc/xlnx,flexnoc.txt
> > @@ -0,0 +1,24 @@
> > +* Xilinx Flexnoc Performance Monitor driver
>=20
> Bindings are for h/w blocks, not drivers.
Wil change
>=20
> > +
> > +The FlexNoc Performance Monitor has counters for monitoring the read
> > +and the write transaction counter.
> > +
> > +Required properties:
> > +- compatible: "xlnx,flexnoc-pm-2.7"
> > +- reg : Address and length of register sets for each device in
> > +       "reg-names"
> > +- reg-names : The names of the register addresses corresponding to the
> > +               registers filled in "reg"
> > +               - funnel: base address of the funnel registers
> > +               - baselpd: base address of the LPD PM registers
> > +               - basefpd: base address FPD PM registers
>=20
> Is this really all one h/w block.
>=20
> FlexNoC is an interconnect, right? Is there more to it than just perfmon?
Yes , however the driver only uses the monitoring  part.

>=20
> > +