Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Fail (protection.outlook.com: domain of arm.com does not
 designate 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
From:   "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
To:     Dave Airlie <airlied@gmail.com>, Liviu Dudau <Liviu.Dudau@arm.com>,
        "airlied@linux.ie" <airlied@linux.ie>,
        Brian Starkey <Brian.Starkey@arm.com>,
        "maarten.lankhorst@linux.intel.com" 
        <maarten.lankhorst@linux.intel.com>,
        Mihail Atanassov <Mihail.Atanassov@arm.com>, nd <nd@arm.com>,
        "Oscar Zhang (Arm Technology China)" <Oscar.Zhang@arm.com>,
        "Tiannan Zhu (Arm Technology China)" <Tiannan.Zhu@arm.com>,
        "Jonathan Chai (Arm Technology China)" <Jonathan.Chai@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "Julien Yin (Arm Technology China)" <Julien.Yin@arm.com>,
        "Channing Chen (Arm Technology China)" <Channing.Chen@arm.com>,
        "Thomas Sun (Arm Technology China)" <thomas.Sun@arm.com>,
        "Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>,
        Ben Davis <Ben.Davis@arm.com>
Subject: Re: [PATCH v4 6/6] drm/komeda: Expose side_by_side by sysfs/config_id
Thread-Topic: [PATCH v4 6/6] drm/komeda: Expose side_by_side by
 sysfs/config_id
Thread-Index: AQHVoDsY3wS7JXHxKU+92h5A5rXdAKeVYXUAgAAI04A=
Date:   Thu, 21 Nov 2019 10:21:08 +0000
Message-ID: <20191121102101.GA32514@jamwan02-TSP300>
References: <20191121071205.27511-1-james.qian.wang@arm.com>
 <20191121071205.27511-7-james.qian.wang@arm.com>
 <20191121094926.GC6236@phenom.ffwll.local>
In-Reply-To: <20191121094926.GC6236@phenom.ffwll.local>
Accept-Language: en-US
Content-Language: en-US
user-agent: Mutt/1.10.1 (2018-07-13)
Authentication-Results-Original: spf=none (sender IP is )
 smtp.mailfrom=james.qian.wang@arm.com; 
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 8612c760-76d1-479b-8b86-08d76e6c8c9f
X-MS-TrafficTypeDiagnostic: VE1PR08MB5101:|VE1PR08MB5101:|HE1PR0802MB2521:
X-MS-Exchange-PUrlCount: 2
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: <HE1PR0802MB25211BB3636DC77BD3A49266B34E0@HE1PR0802MB2521.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
x-ms-oob-tlc-oobclassifiers: OLM:6430;OLM:6430;
x-forefront-prvs: 0228DDDDD7
X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(7916004)(4636009)(396003)(346002)(39860400002)(376002)(366004)(136003)(199004)(189003)(86362001)(81156014)(55236004)(99286004)(52116002)(33716001)(229853002)(1076003)(6436002)(6486002)(478600001)(76176011)(966005)(66066001)(26005)(5660300002)(186003)(25786009)(8936002)(6636002)(6306002)(9686003)(102836004)(2906002)(6506007)(386003)(14454004)(305945005)(3846002)(256004)(6512007)(33656002)(14444005)(8676002)(110136005)(66946007)(446003)(6116002)(64756008)(7736002)(71200400001)(66446008)(66556008)(71190400001)(66476007)(11346002)(2501003)(58126008)(6246003)(316002)(2201001)(81166006)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR08MB5101;H:VE1PR08MB5006.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: Vt5YbTUNQs5Sxn5LuQ8e/YsbhVzG6vkP9eeFayg/mc7UjecQdgL1gncWFzbdZZrbHKmw6nnHH2Vw/QppfwDd3zMt0AOHBwG9O7zFiTAb4EABeY1RRv19UWdVnrVhykvIkO3q20Nl9ZDXOfCHOZpxVIK+UtD+Zx4m8F+a/5ynDd5nIZUbuxaqU6mUjccdkPXqry3mnCITUGY2wS5O+thYg9Qv9d4h4GVUVze9l57p5BwYi6RywE+P/Z+fKYnSCucKfa6ckUO1me+yd/EgbkKUPccTw6tI33CxDlnNsfFaceJoTTY82aoTTKTHRIkqMI+0SLn/WIqacpORDUseK5Q6TSJBnmizYTz3hvKaLLaS79f4JfLqw2njmEFBnRrR7L/Ht4k0Qo34imuEyfAEWDS8iBamgwgOZXFs6q22w8+dJLaS02USzndiJVkZ9X28kzaUU3QMu4YFsftCiouxwhb2c2kXzkV+LIuSXqEMjFIK8K8=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <FE7D88DA5A172F4CAEE863476F9DEDDB@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5101
Original-Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=james.qian.wang@arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT054.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(7916004)(346002)(376002)(39860400002)(136003)(396003)(1110001)(339900001)(189003)(199004)(40434004)(25786009)(1076003)(58126008)(50466002)(229853002)(33656002)(81166006)(26005)(46406003)(2501003)(7736002)(14454004)(478600001)(966005)(356004)(587094005)(102836004)(23726003)(81156014)(5024004)(305945005)(105606002)(6506007)(386003)(99286004)(6636002)(14444005)(9686003)(110136005)(33716001)(2201001)(70586007)(97756001)(22756006)(8746002)(336012)(446003)(6246003)(6306002)(70206006)(6486002)(76176011)(8676002)(2906002)(186003)(26826003)(316002)(11346002)(6116002)(3846002)(86362001)(5660300002)(8936002)(47776003)(6512007)(66066001)(76130400001)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0802MB2521;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:Fail;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;MX:1;A:1;
X-MS-Office365-Filtering-Correlation-Id-Prvs: 1cd417b3-9f04-4481-64dd-08d76e6c8663
X-Forefront-PRVS: 0228DDDDD7
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 9783tlMMd/s3PBDkJSJ8rT5Y4HCJv0sA2f/mdtsk6MkDqT4lUCd5i3PRAvSE+zaNWTXem9VlCD8R4fY1q2uPdRPvFMbcUmkpnVooRfGEz+Xv3la2/m917gfwmpfKpiIhFwSeQX+QUZo6m8KdrZhU/4udHagL1ZgrGprvccqqTVPsLDJxJcn93FLguWX2sOo2NNNnKnfL+8R0/iZA2HpRT3dAVzmX/3zs9sFUEVw2FTqRJEsgWWFd4l6B4XPWhcS54Bh95hLEGbuBKs8l1VPJ1sygr3f5l3kEL6B8Qh30Qqfp3lIenfrTXXGpeE27T2gwNJKJYN60EVPI3ZI9LYoUpbPSKoMrb9AtWziANVd0fMKkiyVz6EFkXeVU/JNVI1OiRwrduBTdXogu5TGDnSSsWIsz4hdWKvs4KNK4T4b1iTVOMlfO3E5DPdFREakFSUOB4ydKPtnSxDeUIZYuhpMnUf5jLlQGUoQssmvnUcQn3Rw=
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2019 10:21:19.0103
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8612c760-76d1-479b-8b86-08d76e6c8c9f
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2521
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 21, 2019 at 10:49:26AM +0100, Daniel Vetter wrote:
> On Thu, Nov 21, 2019 at 07:12:55AM +0000, james qian wang (Arm Technology=
 China) wrote:
> > There are some restrictions if HW works on side_by_side, expose it via
> > config_id to user.
> >
> > Signed-off-by: James Qian Wang (Arm Technology China) <james.qian.wang@=
arm.com>
> > ---
> >  drivers/gpu/drm/arm/display/include/malidp_product.h | 3 ++-
> >  drivers/gpu/drm/arm/display/komeda/komeda_dev.c      | 1 +
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/arm/display/include/malidp_product.h b/dri=
vers/gpu/drm/arm/display/include/malidp_product.h
> > index 1053b11352eb..96e2e4016250 100644
> > --- a/drivers/gpu/drm/arm/display/include/malidp_product.h
> > +++ b/drivers/gpu/drm/arm/display/include/malidp_product.h
> > @@ -27,7 +27,8 @@ union komeda_config_id {
> >                     n_scalers:2, /* number of scalers per pipeline */
> >                     n_layers:3, /* number of layers per pipeline */
> >                     n_richs:3, /* number of rich layers per pipeline */
> > -                   reserved_bits:6;
> > +                   side_by_side:1, /* if HW works on side_by_side mode=
 */
> > +                   reserved_bits:5;
> >     };
> >     __u32 value;
> >  };
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/=
gpu/drm/arm/display/komeda/komeda_dev.c
> > index c3fa4835cb8d..4dd4699d4e3d 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> > @@ -83,6 +83,7 @@ config_id_show(struct device *dev, struct device_attr=
ibute *attr, char *buf)
>
> Uh, this sysfs file here looks a lot like uapi for some compositor to
> decide what to do. Do you have the userspace for this?

Yes, our HWC driver uses this config_id and product_id for identifying the
HW caps.

> Also a few more thoughts on this:
> - You can't just add more fields to uapi structs.
> - This doesn't really feel like it was ever reviewed to fit into atomic.
> - sysfs should be one value per file, not a smorgasbrod of things stuffed
>   into a binary structure.

I will sent a series and split this struct to multiple files.

| This doesn't really feel like it was ever reviewed to fit into atomic

These values don't have atomic problem, since config_id is for
representing the HW caps info, which are not configurable.

Thanks
James

> -Daniel
>
> >     memset(&config_id, 0, sizeof(config_id));
> >
> >     config_id.max_line_sz =3D pipe->layers[0]->hsize_in.end;
> > +   config_id.side_by_side =3D mdev->side_by_side;
> >     config_id.n_pipelines =3D mdev->n_pipelines;
> >     config_id.n_scalers =3D pipe->n_scalers;
> >     config_id.n_layers =3D pipe->n_layers;
> > --
> > 2.20.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
IMPORTANT NOTICE: The contents of this email and any attachments are confid=
ential and may also be privileged. If you are not the intended recipient, p=
lease notify the sender immediately and do not disclose the contents to any=
 other person, use it for any purpose, or store or copy the information in =
any medium. Thank you.