Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp3060742ybc; Thu, 21 Nov 2019 02:43:40 -0800 (PST) X-Google-Smtp-Source: APXvYqz/GQHCJroTm/EK+NWO4w7g71cXZnY50ih1v8OMZB6a5W4ouwppFvrhnoQcavz1RWVO2l3E X-Received: by 2002:adf:f547:: with SMTP id j7mr9954383wrp.69.1574333020114; Thu, 21 Nov 2019 02:43:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574333020; cv=none; d=google.com; s=arc-20160816; b=AQ2N2rhii7khrvaJ2n1ag9/Lod7OwMUAWP4/Xm7zwC27TnnshNy0bCiqr9UoBOW3Po 9sqbfdItyb6s/Z8ebvtr736ZgNGf02uy8AzYNtzADZE1pH0eturIgiIJmEPkT0ZnmYHw OzVoX+r+EgbWv/ZR3Dze556yTzK6oDbmmOaw4Cp9/7vhpCdEWf1PL7dJYVG+bHQHioj4 S0HOBMHnNKjIMgFGziQIHyBiQZ/awagZRQuIX4K0Dyxp0jYwenN8q9W4paezYL2/sd2X h1Xs5G7pZHdB8VxlC5ShLJbvDGreK4Q66Lfygddd0IFLxSufIxjBglhwbSEypIqLkXek r64Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=aWtWnNIL44r1SfOTYhPBcpGogPusDVKyM58Fp0nSzlg=; b=LQqthtmcff2bAAhSbF0btGHaGLK5Dj6vYP2LNuKjHei8v+wNS/nHNriuINffi2gNws VtIEvTxAEFeBtQadUdKKGofItE2H+N1ZLf52rewcFiOP9tkIiMs46LESTVOglh7DJIgi sFUE+pr4iPCU7nkENoMDb99ERypQnflyNLyKBzHrbELM6EvCtPe84pH6WBLFFp0ifUw7 ovjs17sDE7omIAelc+dCfV84wgWH4QXG1oDnPMU5iS9NwIVe2ZcR2LjdB9ZBgx0LjnT8 4UxxIFsYMw36k1b3jNJ+xxWWJyEepg3M14WQ82d1wQh9DiC+wEXwAIzy4BcLQ2Xd6zOH IkcA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f24si1752643edf.15.2019.11.21.02.43.15; Thu, 21 Nov 2019 02:43:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726757AbfKUKlx (ORCPT + 99 others); Thu, 21 Nov 2019 05:41:53 -0500 Received: from mga12.intel.com ([192.55.52.136]:17388 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726165AbfKUKlw (ORCPT ); Thu, 21 Nov 2019 05:41:52 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 02:41:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,224,1571727600"; d="scan'208";a="408472759" Received: from jsakkine-mobl1.tm.intel.com (HELO localhost) ([10.237.50.162]) by fmsmga006.fm.intel.com with ESMTP; 21 Nov 2019 02:41:46 -0800 Date: Thu, 21 Nov 2019 12:41:45 +0200 From: Jarkko Sakkinen To: Sean Christopherson Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Tony Luck , Tony W Wang-oc , Shuah Khan , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-edac@vger.kernel.org, linux-kselftest@vger.kernel.org, Borislav Petkov Subject: Re: [PATCH v3 04/19] x86/intel: Initialize IA32_FEATURE_CONTROL MSR at boot Message-ID: <20191121104145.GC20907@linux.intel.com> References: <20191119031240.7779-1-sean.j.christopherson@intel.com> <20191119031240.7779-5-sean.j.christopherson@intel.com> <20191121103925.GB20907@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191121103925.GB20907@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 21, 2019 at 12:39:25PM +0200, Jarkko Sakkinen wrote: > > +void init_feature_control_msr(struct cpuinfo_x86 *c) I'd also use here shorter init_feat_ctl_msr(). It has one call site but shorter name is more convenient when playing with tracing tools. /Jarkko