Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp3174833ybc; Thu, 21 Nov 2019 04:32:31 -0800 (PST) X-Google-Smtp-Source: APXvYqxFxKTYSVzFy7M+sZewuIbh3ULvwpVC9wdFevAi4bUEKBDKMSCWGjE0hzEsDvLp2sVeqFNy X-Received: by 2002:a7b:c408:: with SMTP id k8mr10035496wmi.67.1574339550923; Thu, 21 Nov 2019 04:32:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574339550; cv=none; d=google.com; s=arc-20160816; b=c4YT7bpAo62JTqSdBd2D8O9cJIB5NEg66CtBHD65dJLKE0+vu3WfJxKStDfPrXMgIc 6R4oNXKFGlCOh8Rk7O/XwSKDxKeBoFyOTZbNZ/tbPTvG5YI/NvFrAgcMfVEWLQMY9YV4 QfRNnK/V/A3AQjcI/Asoq6uRKadgUy394a8Ai/ji9DpCfSDPdqy0Or7ocLrQBMrtMvWP fabI9KBLFWsJ+X1WBLx7lr7e++g9GtYKWtaIRB11Mn8/+Vd0BmQH/0OliaP7F5WnkpXv iWCGizCB/4nEezuzvdCaVJfMRn/i9EWifxtu2A7BsfhYz0/BiSMsaQondfwAEXQxdofQ mnRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=SHnW3DpA9GShnJzkqm3FRZ8Dv49uP+5rhGD1oRyhB/U=; b=TA7ukJWeS/vYCMswO6hF3aC52p5vO9jeQGby88/wcH89uHuHhlCez0rTDLy+LUvO+v eQZDLH4YKQJqhsVb5XKbc+Sk9nCcvXGRzjBJV7g+eLDJCA2rm6S3c0lVZlfwjHmZDKAU jQO0GybpHnf36pd3hqTRWuhZc/DEySKug8K2zQeAPzxT3tclrriUMd5i1ZJ4oWmnm5Zm XeV6228ULiWT+gxnoXntncKNNkloUpXsx3Nvnl1kOnuZmCMMveu/Uu7ut4geDIBQmfjw JJTAwsuD7Xlk8CvEkmFHfureIjK/Kle4jwVwjwgzg10E0zKagevn9hF1jMvf8EvAZxPq KqDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=NKT21b6r; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d36si1931922ede.44.2019.11.21.04.32.06; Thu, 21 Nov 2019 04:32:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=NKT21b6r; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726502AbfKUMay (ORCPT + 99 others); Thu, 21 Nov 2019 07:30:54 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:35884 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726230AbfKUMay (ORCPT ); Thu, 21 Nov 2019 07:30:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=SHnW3DpA9GShnJzkqm3FRZ8Dv49uP+5rhGD1oRyhB/U=; b=NKT21b6rhvpl86JwDqjPxioRJ vVxpx148pLNeM3D5oTxYsMI3opwNCkk8nc2QenVqUlDXh6kRNDj9BhkkgjzmnBnHygx5GnD285XRY lYhnPaRbNzvCNdSJ8YB4p9jjxgE4Z4u3X+7ndzHAtvFezqOH1B/unF6+QV518ZOvTzD48GomZaW18 SZS0YfRdYVdEU7/AqUa6OhVBy5ctO0DV7Khdo4m5TxjkcpghGlbRL8rCG5r9Qr+dL2YUrrpsPuKo1 2CRS0K6BW83FyuirEz6RDgIT4nKMwQsPn2ntQG0xHm+3y9spOc8QARudH2PTJH3nbQZO5QOnG2sv1 Vg73jEs+w==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1iXlbn-0003sd-7d; Thu, 21 Nov 2019 12:30:51 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 1FEC030068E; Thu, 21 Nov 2019 13:29:38 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 02224201DD6AF; Thu, 21 Nov 2019 13:30:48 +0100 (CET) Date: Thu, 21 Nov 2019 13:30:48 +0100 From: Peter Zijlstra To: YT Chang Cc: Matthias Brugger , wsd_upstream@mediatek.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 1/1] sched: panic, when call schedule with preemption disable Message-ID: <20191121123048.GQ4097@hirez.programming.kicks-ass.net> References: <1574323985-24193-1-git-send-email-yt.chang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1574323985-24193-1-git-send-email-yt.chang@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 21, 2019 at 04:13:05PM +0800, YT Chang wrote: > When preemption is disable, call schedule() is incorrect behavior. > Suggest to panic directly rather than depend on panic_on_warn. Why!?