Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp3266081ybc; Thu, 21 Nov 2019 05:59:07 -0800 (PST) X-Google-Smtp-Source: APXvYqy6IKmPyRdVMZEpWNa9PxS2GnUBjiiALr5U9VnTaXy/PMq4vseQAaVhhlRBOJjMwNZyENKm X-Received: by 2002:a17:906:600b:: with SMTP id o11mr13833371ejj.175.1574344746965; Thu, 21 Nov 2019 05:59:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574344746; cv=none; d=google.com; s=arc-20160816; b=A/uY/OX98leOSrACGTYtgVhIYTCi47zMtXaxMEGU3CFnGXrwb1O+8B/7KCiVrxrz8S eePS1It49crGd9MTBFnXABChCw/lHkLOYV+5YBaqtp8kHUo8aMycTQ635184EMlx4ozV 7CqzYWJVsDN8QG3agDFxa/8JdZgPI1gYcvty+De5PcAriseOnqX4019aNx5/J4Wo3Ntb 9VtAJKqfoyDJhC3F/RfI1fXp8F5aTDekoBUnwNuirOuCkyEU6Fp5oRQFurWG9yIIeh/E 1n3osv11pdzeetYnyb3pSHDb6pUMiNVNwChniFkMoZJB8txLTkYf9tPyxjLl4IgJ79Gi JGMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:message-id:subject:cc:to:from:date :dkim-signature; bh=20wInXBHQF7222lomTk6c1Fx8jImCZviNf8QfuiUpeY=; b=gr+fvm1VfONNov3Q0GVarbnM+LOZBesmhVvJCqt7X+WrHGLx7BygNk19JYs0lJh1Wt J3pI3l9aKNmE+0VQ7Ldu9KxRaefUljlDPE2OgTZgY6ABEEQZY+v5XPlpUxWHmEZsfS1P Mr4Mv6rlxxrVEUruC8bdn0kMcj98r9ghQWlsQri5EDdi3Lw9rrV7QqJfBDjs3skSUC/K WTHoNN5Wl+hvaUXW2EmUxIrq436/Ibemz2X5uS7mDQsFpKD94yDyKgUAfV16RYk/VGDg IX2p9BpHhG5uMZtYxiiwCZ60zf6Ugim8YOIcje8fEXhFV6MrEESDbRN4ZpdIUb/3cVQW AU3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tECdPZzF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n8si513616eja.438.2019.11.21.05.58.42; Thu, 21 Nov 2019 05:59:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tECdPZzF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726638AbfKUNzS (ORCPT + 99 others); Thu, 21 Nov 2019 08:55:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:33256 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726293AbfKUNzS (ORCPT ); Thu, 21 Nov 2019 08:55:18 -0500 Received: from localhost (173-25-83-245.client.mchsi.com [173.25.83.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 47EC920679; Thu, 21 Nov 2019 13:55:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574344517; bh=6E0YF8yMllj8qK0e/SPC6Lbz+lUTP0OyTKxxgQareDI=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=tECdPZzF8HyX9TTmeeiSmLmAIGiDqt8CoZWvW9wj9PVeU71Sq3d/ytdFURHqVq75T N15fg7oPvR15OANOzCtplXs4LfnKht8DXDXpiVb/mlaQWVKyJgRZhlpOaVYfbM86mG fsIFutGcLyCjWv35or3z/6Uexha4fojCRpm/8wcI= Date: Thu, 21 Nov 2019 07:55:05 -0600 From: Bjorn Helgaas To: Alex Deucher Cc: Frederick Lawler , "Deucher, Alexander" , Christian Koenig , Chunming Zhou , Dave Airlie , Daniel Vetter , Linux PCI , LKML , Maling list - DRI developers , amd-gfx list Subject: Re: [PATCH v2 1/1] drm: Prefer pcie_capability_read_word() Message-ID: <20191121135505.GA37567@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 18, 2019 at 12:42:25PM -0500, Alex Deucher wrote: > On Mon, Nov 18, 2019 at 3:37 AM Frederick Lawler wrote: > > > > Commit 8c0d3a02c130 ("PCI: Add accessors for PCI Express Capability") > > added accessors for the PCI Express Capability so that drivers didn't > > need to be aware of differences between v1 and v2 of the PCI > > Express Capability. > > > > Replace pci_read_config_word() and pci_write_config_word() calls with > > pcie_capability_read_word() and pcie_capability_write_word(). > > > > Signed-off-by: Frederick Lawler > > > > --- > > V2 > > - Squash both drm commits into one > > - Rebase ontop of d46eac1e658b > > --- > > drivers/gpu/drm/amd/amdgpu/cik.c | 63 ++++++++++++++++----------- > > drivers/gpu/drm/amd/amdgpu/si.c | 71 +++++++++++++++++++------------ > > drivers/gpu/drm/radeon/cik.c | 70 ++++++++++++++++++------------ > > drivers/gpu/drm/radeon/si.c | 73 ++++++++++++++++++++------------ > > Can you split this into two patches? One for amdgpu and one for radeon? I split this, and I also went back and split the related patches that preceded this one. I'll post the resulting series for reference.