Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp3413935ybc; Thu, 21 Nov 2019 08:01:45 -0800 (PST) X-Google-Smtp-Source: APXvYqwme4PF7bJvcuswYxurJs6ESfelUcq5yZPRW14+ZWpSPBlp6kb0kVjCpIyeWhn9AI0+Kq0v X-Received: by 2002:a17:906:f119:: with SMTP id gv25mr14831430ejb.164.1574352105807; Thu, 21 Nov 2019 08:01:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574352105; cv=none; d=google.com; s=arc-20160816; b=NE8BTTlMzxy/R6yk9ewIv80Z2pXM3hNtzjovZi70FDdxC6PQ7HG5fqsFM8O3+eK51o xEwPXk5Q931dYvI1lLYraq0ZW1PVE3lg2BZHlry7XXDZ7/bvWruCA8b0DqgntuvJPxW7 Q6D7X/nqNPOAc8P/ijjzlaDA9t14cVfHEb/djEuhn/YCaPqrgexZbPkE885LE9AFqe2Z DHuAADD2HHkMs94LpZSCKmcOHPc9fzyasHj5WAZKfXalNYm0rMvHds8/2DOYqKo9fUs7 QalKUjV7KYQPrwRzs+Udg2GRl227bryxZWs+7HYS1ppwuVFv9XPa+BPRvyVHaXy0HFkM 5f5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition:user-agent :in-reply-to:mime-version:references:message-id:subject:cc:to:from :date:dkim-signature; bh=FaPLEQrdTtUL2Ob9GHzV8gvblPJ9sIr1fQNhRCiAn7Q=; b=YHq4yHSgJL8HEuH06fNJhMNUhv9Jx6sfm574FeX6JSbBMVdTMFKiHANReM3hfLyssa 1NyGlEdIZxWE0k3kk4+oD4i45DwPUS7UpJ4WCmQuD3Z0fl4ofl1vjj+6x3uGnlxBrcDl jmvaQCX1LSb9REcneyy82PNSYcZIogfTYMD39tgIdfZM8DsRZbBaM/bV4HCpX0LauKUt M+EhhN2YLZX7oNYok7k3tY/816WhqbJhisgU5D6YtHmgRrts4b6KwoOpPnDb1G7y24Ea vySrWs/fITnFK1FWri1gOkp0pA2JV1lscslKV+8AtNRex/BLfxIMB74y4bTWxs/0AuWI tzgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=D9KoJ27q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k11si2089242ejv.152.2019.11.21.08.01.18; Thu, 21 Nov 2019 08:01:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=D9KoJ27q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726676AbfKUQAR (ORCPT + 99 others); Thu, 21 Nov 2019 11:00:17 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:23167 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726293AbfKUQAR (ORCPT ); Thu, 21 Nov 2019 11:00:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574352016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FaPLEQrdTtUL2Ob9GHzV8gvblPJ9sIr1fQNhRCiAn7Q=; b=D9KoJ27q006SC4FbEu8QR32tmOHP8QnIeGBv4ykdDZ3yF9cSpeY3TtV3GdbumOfOwnpR3N /JWuTU2oO8wFCZ/PWqhAVBOoB+Cs1v19E2MQ56Q/jc20AtgDj1kKUEq/Se9rh2QWnczLWH /1myAwhsVYct5MVrVPsuPd1BoXa4rWo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-337-Jp2VdSAyNJmSVgtfRmHTdw-1; Thu, 21 Nov 2019 11:00:12 -0500 X-MC-Unique: Jp2VdSAyNJmSVgtfRmHTdw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 29DA49B3A8; Thu, 21 Nov 2019 16:00:11 +0000 (UTC) Received: from localhost (ovpn-117-83.ams2.redhat.com [10.36.117.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id B833E1081303; Thu, 21 Nov 2019 16:00:03 +0000 (UTC) Date: Thu, 21 Nov 2019 16:00:01 +0000 From: Stefan Hajnoczi To: Vivek Goyal Cc: virtio-fs@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, dgilbert@redhat.com, miklos@szeredi.hu Subject: Re: [PATCH 2/4] virtiofs: Add an index to keep track of first request queue Message-ID: <20191121160001.GC445244@stefanha-x1.localdomain> References: <20191115205705.2046-1-vgoyal@redhat.com> <20191115205705.2046-3-vgoyal@redhat.com> MIME-Version: 1.0 In-Reply-To: <20191115205705.2046-3-vgoyal@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tqI+Z3u+9OQ7kwn0" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --tqI+Z3u+9OQ7kwn0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 15, 2019 at 03:57:03PM -0500, Vivek Goyal wrote: > @@ -1004,6 +1008,7 @@ __releases(fiq->lock) > =09spin_unlock(&fiq->lock); > =20 > =09fs =3D fiq->priv; > +=09queue_id =3D fs->first_reqq_idx; The TODO should be moved here. --tqI+Z3u+9OQ7kwn0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAl3WtIEACgkQnKSrs4Gr c8gp1wf9FsjNknItwwiYqgaMkCFsD/lJY+7ZWvz25GCPp4aHChGQMvg/GBxEXbUs d2n5sxD4UcV/wmUt3amPMondoXmfLu//QOg0X5+ftyWLbVK7Tq0rO+hPkysOeP+6 2svIACl5UtYuzU3SxRS5nY3CGZ3/HxLKgJyLVhorSNXacI6ijRHZLnLDEqXU/90o GCVuxTJfvf8UMQ42KSjwmCM+hyWb9HlNj/NoSZ63K8Zq6Y41N45bx+36k9J8LIlQ UaFITc5HT6wWTHN0tVJxRQVsV5ZEBx1lauzDLxKCsD47+AJOMDhX/5mbVkndJZS/ xuPiSOtg8Is+zto/rTm+wN9K4/gEAw== =Cosk -----END PGP SIGNATURE----- --tqI+Z3u+9OQ7kwn0--