Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp3755069ybc; Thu, 21 Nov 2019 13:14:20 -0800 (PST) X-Google-Smtp-Source: APXvYqyWzhc4JprTeHCFVJ/oyFANF7GhfaWH3NZC+k37H1FPdePHJzxMgktqka9XiSpXWw8yKiic X-Received: by 2002:a17:906:b310:: with SMTP id n16mr16328906ejz.129.1574370860176; Thu, 21 Nov 2019 13:14:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574370860; cv=none; d=google.com; s=arc-20160816; b=AcFNXDMr5d+I663gsrK2BVDc9ERc1za/EEdH305/li957bYkbenVVyV3kddLtRUEam /JnHlGeQcWAsN+1z/NkwTZvtfHWzxC2gNlY/qxyM2TtpzSM2n6DSLEcR5cL1TxgDzg4P Tqz8Y76NDHAvOy8kSouIx0yagZxlvcRojWMCo8mR6UEt+vMV9Elpc0k0m6k0aoR7jdjJ gn1jnjGJZ/WYyTZiBpCcijruTLiGh5FHTkaaTKwkA/UA0L+hH1ADg0UJI48B1OpIwqxS r2zyrxrSpk7DNsfCJXb9pKxYC/PmQmkovPP+jbH09Ir5/5bJz43A6D5TJKCrSXbFec2G MDZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=yTD6DYyATeMpZ3Q+gsGQZf2Ua5xQG3BGZz03EY+kl2s=; b=FUweyCaYAOgRN2h8dXmDIduwRUJ2xFWcudruH/E1sdxd6zk7hMzjx9sAFVdUkLhfzp I0FaSU2iHeiyQUXPLn5gy7cjUUpYzJIVKWomt177IGwG3Q7tQCjOUDyEpMpsuE/Q+Cfp F6Ji6R8SbQl9DPoFKJnMm6YimCvIhP/8kNvacNGmSB4BFZXL6vu4ES72U8SNN7fvDyO3 Ubn/OricgcOOQt8wKUPPhqr9y6Sw6j8GaltxrlWUFoSdyswp5wnwirEVNmyLfULfhRdt D3zJjBkfphb78BeuJoeNtD2my+QHQ3D0dVt+LyQC+LOdG2ec3Sm+N9xZwKYhh66hiPIi HZSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=CBqMrLJL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u24si2525289ejb.93.2019.11.21.13.13.55; Thu, 21 Nov 2019 13:14:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=CBqMrLJL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727097AbfKUVLN (ORCPT + 99 others); Thu, 21 Nov 2019 16:11:13 -0500 Received: from mail-io1-f68.google.com ([209.85.166.68]:43591 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727047AbfKUVLL (ORCPT ); Thu, 21 Nov 2019 16:11:11 -0500 Received: by mail-io1-f68.google.com with SMTP id r2so5167102iot.10 for ; Thu, 21 Nov 2019 13:11:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yTD6DYyATeMpZ3Q+gsGQZf2Ua5xQG3BGZz03EY+kl2s=; b=CBqMrLJLOpCxWs351k7tkCrHdirvjqVbKOi/FiI2JBBRTSKd/ddT8mgeV1o2uMWjKX skcro/m+GVfIlSfXbQeX+govttLeiAROe9c/n42Oxf7Z5kQ5qOfAdwdgEmRt8M1qEWLi 0gxuVfbgLELAzaSYd0U/+FMIEJP5jbSqQ2SoI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yTD6DYyATeMpZ3Q+gsGQZf2Ua5xQG3BGZz03EY+kl2s=; b=jJso8xcKTaRKnpU54G2YGZLtVf/jme6Wu9EXK/uWUvR7E9+lFnMM3iOaW3q+wyAzZK 4W8AEEYePzqLLRy49GT0gIEfS1GBvxrfH62wY3iLOtwbyyGwK/4OY1rPkeDzAQi8Y97G ZAb/d9v5+sQXEWDSLttZ69nZ1DXXxu6VgcivWJv6E0Yt2+FiOgJs3k3O6C+K8kUsZcEr VhUBjE7p38mf5c7vKhBfWNCnhUA7H/tV6c5nKbXrANpgaHIPXgJtqwEaHi8KWRpZ9gZW E2SLuX3KZbW1gJ+RyvEaDCILt+AQSS4SMsFEDfFDr/dla1elIae2DDO/XovmWa9+vYT1 BWqg== X-Gm-Message-State: APjAAAXNeIi9IvsESW3IYeMqmYeVt9fqnat6ckZKJIq5fKcDjuZu8T3r PuqTeQb3zUI2ff03Is5Gte1sPg== X-Received: by 2002:a05:6638:3fd:: with SMTP id s29mr5964322jaq.17.1574370670483; Thu, 21 Nov 2019 13:11:10 -0800 (PST) Received: from localhost ([2620:15c:183:0:82e0:aef8:11bc:24c4]) by smtp.gmail.com with ESMTPSA id t12sm1682648ilm.69.2019.11.21.13.11.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Nov 2019 13:11:10 -0800 (PST) From: Raul E Rangel To: enric.balletbo@collabora.com, Wolfram Sang Cc: Akshu.Agrawal@amd.com, Raul E Rangel , Akshu Agrawal , Guenter Roeck , Chanwoo Choi , linux-kernel@vger.kernel.org, Alexandre Belloni , linux-i2c@vger.kernel.org, Lee Jones , Benson Leung Subject: [PATCH 4/4] platform/chrome: i2c: i2c-cros-ec-tunnel: Convert i2c tunnel to MFD Cell Date: Thu, 21 Nov 2019 14:10:53 -0700 Message-Id: <20191121140830.4.Iddc7dd74f893297cb932e9825d413e7890633b3d@changeid> X-Mailer: git-send-email 2.24.0.432.g9d3f5f5b63-goog In-Reply-To: <20191121211053.48861-1-rrangel@chromium.org> References: <20191121211053.48861-1-rrangel@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the i2c-cros-ec-tunnel driver is compiled into the kernel, it is possible that i2c-cros-ec-tunnel could be probed before cros_ec_XXX has finished initializing and setting the drvdata. This would cause a NULL pointer panic. Converting this driver over to an MFD solves the problem and aligns with where the cros_ec is going. Signed-off-by: Raul E Rangel --- You can now see the device node lives under the mfd device. $ find /sys/bus/platform/devices/cros-ec-dev.0.auto/cros-ec-i2c-tunnel.12.auto/ -iname firmware_node -exec ls -l '{}' \; /sys/bus/platform/devices/cros-ec-dev.0.auto/cros-ec-i2c-tunnel.12.auto/firmware_node -> ../../../../../../LNXSYSTM:00/LNXSYBUS:00/PNP0A08:00/device:1c/PNP0C09:00/GOOG0004:00/GOOG0012:00 /sys/bus/platform/devices/cros-ec-dev.0.auto/cros-ec-i2c-tunnel.12.auto/i2c-9/firmware_node -> ../../../../../../../LNXSYSTM:00/LNXSYBUS:00/PNP0A08:00/device:1c/PNP0C09:00/GOOG0004:00/GOOG0012:00 /sys/bus/platform/devices/cros-ec-dev.0.auto/cros-ec-i2c-tunnel.12.auto/i2c-9/i2c-10EC5682:00/firmware_node -> ../../../../../../../../LNXSYSTM:00/LNXSYBUS:00/PNP0A08:00/device:1c/PNP0C09:00/GOOG0004:00/GOOG0012:00/10EC5682:00 drivers/i2c/busses/i2c-cros-ec-tunnel.c | 36 +++++++++---------------- drivers/mfd/cros_ec_dev.c | 19 +++++++++++++ 2 files changed, 32 insertions(+), 23 deletions(-) diff --git a/drivers/i2c/busses/i2c-cros-ec-tunnel.c b/drivers/i2c/busses/i2c-cros-ec-tunnel.c index 5d91e33eb600..2e3217678fa3 100644 --- a/drivers/i2c/busses/i2c-cros-ec-tunnel.c +++ b/drivers/i2c/busses/i2c-cros-ec-tunnel.c @@ -6,6 +6,7 @@ #include #include #include +#include #include #include #include @@ -27,7 +28,6 @@ struct ec_i2c_device { struct device *dev; struct i2c_adapter adap; - struct cros_ec_device *ec; u16 remote_bus; @@ -176,6 +176,7 @@ static int ec_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg i2c_msgs[], { struct ec_i2c_device *bus = adap->algo_data; struct device *dev = bus->dev; + struct cros_ec_dev *ec = dev_get_drvdata(dev->parent); const u16 bus_num = bus->remote_bus; int request_len; int response_len; @@ -183,6 +184,16 @@ static int ec_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg i2c_msgs[], int result; struct cros_ec_command *msg; + if (!ec) { + dev_err(dev, "%s: ec is missing!\n", __func__); + return -EINVAL; + } + + if (!ec->ec_dev) { + dev_err(dev, "%s: ec->ec_dev is missing!\n", __func__); + return -EINVAL; + } + request_len = ec_i2c_count_message(i2c_msgs, num); if (request_len < 0) { dev_warn(dev, "Error constructing message %d\n", request_len); @@ -212,7 +223,7 @@ static int ec_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg i2c_msgs[], msg->outsize = request_len; msg->insize = response_len; - result = cros_ec_cmd_xfer_status(bus->ec, msg); + result = cros_ec_cmd_xfer_status(ec->ec_dev, msg); if (result < 0) { dev_err(dev, "Error transferring EC i2c message %d\n", result); goto exit; @@ -241,17 +252,11 @@ static const struct i2c_algorithm ec_i2c_algorithm = { static int ec_i2c_probe(struct platform_device *pdev) { - struct cros_ec_device *ec = dev_get_drvdata(pdev->dev.parent); struct device *dev = &pdev->dev; struct ec_i2c_device *bus = NULL; u32 remote_bus; int err; - if (!ec->cmd_xfer) { - dev_err(dev, "Missing sendrecv\n"); - return -EINVAL; - } - bus = devm_kzalloc(dev, sizeof(*bus), GFP_KERNEL); if (bus == NULL) return -ENOMEM; @@ -263,7 +268,6 @@ static int ec_i2c_probe(struct platform_device *pdev) } bus->remote_bus = remote_bus; - bus->ec = ec; bus->dev = dev; bus->adap.owner = THIS_MODULE; @@ -292,25 +296,11 @@ static int ec_i2c_remove(struct platform_device *dev) return 0; } -static const struct of_device_id cros_ec_i2c_of_match[] = { - { .compatible = "google,cros-ec-i2c-tunnel" }, - {}, -}; -MODULE_DEVICE_TABLE(of, cros_ec_i2c_of_match); - -static const struct acpi_device_id cros_ec_i2c_tunnel_acpi_id[] = { - { "GOOG0012", 0 }, - { } -}; -MODULE_DEVICE_TABLE(acpi, cros_ec_i2c_tunnel_acpi_id); - static struct platform_driver ec_i2c_tunnel_driver = { .probe = ec_i2c_probe, .remove = ec_i2c_remove, .driver = { .name = "cros-ec-i2c-tunnel", - .acpi_match_table = ACPI_PTR(cros_ec_i2c_tunnel_acpi_id), - .of_match_table = of_match_ptr(cros_ec_i2c_of_match), }, }; diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c index 1efdba18f20b..61b20e061f75 100644 --- a/drivers/mfd/cros_ec_dev.c +++ b/drivers/mfd/cros_ec_dev.c @@ -113,6 +113,18 @@ static const struct mfd_cell cros_ec_vbc_cells[] = { { .name = "cros-ec-vbc", } }; +static struct mfd_cell_acpi_match cros_ec_i2c_tunnel_acpi_match = { + .pnpid = "GOOG0012" +}; + +static struct mfd_cell cros_ec_fw_cells[] = { + { + .name = "cros-ec-i2c-tunnel", + .acpi_match = &cros_ec_i2c_tunnel_acpi_match, + .of_compatible = "google,cros-ec-i2c-tunnel" + }, +}; + int cros_ec_check_features(struct cros_ec_dev *ec, int feature) { struct cros_ec_command *msg; @@ -485,6 +497,13 @@ static int ec_device_probe(struct platform_device *pdev) "failed to add cros-ec platform devices: %d\n", retval); + retval = mfd_add_hotplug_devices(ec->dev, cros_ec_fw_cells, + ARRAY_SIZE(cros_ec_fw_cells)); + if (retval) + dev_warn(ec->dev, + "failed to add cros-ec fw platform devices: %d\n", + retval); + /* Check whether this EC instance has a VBC NVRAM */ node = ec->ec_dev->dev->of_node; if (of_property_read_bool(node, "google,has-vbc-nvram")) { -- 2.24.0.432.g9d3f5f5b63-goog