Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191011002808.28206-1-ivan.khoronzhuk@linaro.org>
 <20191011002808.28206-12-ivan.khoronzhuk@linaro.org> <20191121214225.GA3145429@mini-arch.hsd1.ca.comcast.net>
In-Reply-To: <20191121214225.GA3145429@mini-arch.hsd1.ca.comcast.net>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Thu, 21 Nov 2019 16:11:34 -0800
Message-ID: <CAEf4BzZWPwzC8ZBWcBOfQQmxBkDRjogxw2xHZ+dMWOrrMmU0sg@mail.gmail.com>
Subject: Re: [PATCH v5 bpf-next 11/15] libbpf: don't use cxx to test_libpf target
To:     Stanislav Fomichev <sdf@fomichev.me>
Cc:     Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Yonghong Song <yhs@fb.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <jakub.kicinski@netronome.com>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        john fastabend <john.fastabend@gmail.com>,
        open list <linux-kernel@vger.kernel.org>,
        Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        clang-built-linux@googlegroups.com, ilias.apalodimas@linaro.org,
        sergei.shtylyov@cogentembedded.com,
        Andrii Nakryiko <andriin@fb.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 21, 2019 at 1:42 PM Stanislav Fomichev <sdf@fomichev.me> wrote:
>
> On 10/11, Ivan Khoronzhuk wrote:
> > No need to use C++ for test_libbpf target when libbpf is on C and it
> > can be tested with C, after this change the CXXFLAGS in makefiles can
> > be avoided, at least in bpf samples, when sysroot is used, passing
> > same C/LDFLAGS as for lib.
> >
> > Add "return 0" in test_libbpf to avoid warn, but also remove spaces at
> > start of the lines to keep same style and avoid warns while apply.
> Hey, just spotted this patch, not sure how it slipped through.
> The c++ test was there to make sure libbpf can be included and
> linked against c++ code (i.e. libbpf headers don't have some c++
> keywords/etc).
>
> Any particular reason you were not happy with it? Can we revert it
> back to c++ and fix your use-case instead? Alternatively, we can just
> remove this test if we don't really care about c++.
>

No one seemed to know why we have C++ pieces in pure C library and its
Makefile, so we decide to "fix" this. :)
But I do understand your concern. Would it be possible to instead do
this as a proper selftests test? Do you mind taking a look at that?
Thanks!

(please trim irrelevant parts)
[...]