Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp3953446ybc; Thu, 21 Nov 2019 17:00:07 -0800 (PST) X-Google-Smtp-Source: APXvYqzg+BPQQRiFQ3AM9bsBy08fbRV86mn6udG42h7ELHQFK0ka8Hoek0Y5pSDjdcv5Fe1St9K1 X-Received: by 2002:a17:906:80c:: with SMTP id e12mr18182699ejd.59.1574384407499; Thu, 21 Nov 2019 17:00:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574384407; cv=none; d=google.com; s=arc-20160816; b=lfyHsQj8qO2PWFXEd5QN5lJA+/Yn/wf2QX0Q/H+6VZXbyo4djMFIuoYQkWTPtT36ac XFFdv4n06Be1rDF3QjFXTtrEORw8aA202u0KJCpXYGvZ1dct8IZqdeQlgEiMxN4+c6Zd ahZdNY+VrHtBYGAEvZnR9eXBeUlh3MPwUj0PNdwhqOmQA1FqDxLa+kE7oRxVaU3aT35Q GsemqhON2FkrNvsUry/a4URiToadmD1KJk4AohtAhrNdvDW9Bio+FB4mtKRwL2lAGnTU SI95EFsuDSE/oczmK/rigw57MNw94+U0auoI+gPjq817GTIwqefrCHprv0alMuI4XmRr BJjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=+cc91y+cs7peM4BZsBxIvncNDYJ0+7BV/SYsR4ryPr0=; b=aDSvce9QK346Zj8XmMvPgUvJZYDFRMObDAhltl8tlpl12+bYpragAgVeBdmg5C1buz iqSyav/xbWyovWKkPYPLpeBLXlIqorvZYvL2iw9byxh98OTzmRJyeo9XdRLI2afwy8F+ j1yJURZ0sbuCzyyd4NQZU06w0umCp7Uj0tC1hUBvQvI+2zutNWZplA9vi2NMUgRAYT6U 0PUHsPsnBo+i1kcKBvytR/YrkWbewLY6TBDOZYKz02vm8gfiNKbesmv97KYK258kDGUw qJ+cgSPi7LqizIxl3Ty3nV7csAkLxzCRJXU2sMEBP/9GsefBiP0meVOmQhToxiuqytIl 0rZw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g43si3643840edg.203.2019.11.21.16.59.38; Thu, 21 Nov 2019 17:00:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726500AbfKVAzz (ORCPT + 99 others); Thu, 21 Nov 2019 19:55:55 -0500 Received: from mga18.intel.com ([134.134.136.126]:57577 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726038AbfKVAzy (ORCPT ); Thu, 21 Nov 2019 19:55:54 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 16:55:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,227,1571727600"; d="scan'208";a="381922129" Received: from agluck-desk2.sc.intel.com (HELO agluck-desk2.amr.corp.intel.com) ([10.3.52.68]) by orsmga005.jf.intel.com with ESMTP; 21 Nov 2019 16:55:53 -0800 Date: Thu, 21 Nov 2019 16:55:53 -0800 From: "Luck, Tony" To: Andy Lutomirski Cc: Peter Zijlstra , Ingo Molnar , Fenghua Yu , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , Ashok Raj , Ravi V Shankar , linux-kernel , x86 Subject: Re: [PATCH v10 6/6] x86/split_lock: Enable split lock detection by kernel parameter Message-ID: <20191122005553.GA11322@agluck-desk2.amr.corp.intel.com> References: <20191121215126.GA9075@agluck-desk2.amr.corp.intel.com> <159DB397-87E2-435D-9F33-067FF9296ADC@amacapital.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <159DB397-87E2-435D-9F33-067FF9296ADC@amacapital.net> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 21, 2019 at 02:24:21PM -0800, Andy Lutomirski wrote: > > > On Nov 21, 2019, at 1:51 PM, Luck, Tony wrote: > > Almost all of what's in this set will be required in whatever > > final solution we want to end up with. Out of this: > > Why don’t we beat it into shape and apply it, hidden behind BROKEN. > Then we can work on the rest of the patches and have a way to test them. That's my goal (and thanks for the help with the constructive beating, "die" is a much better choice that "panic" at this stage of development). I'm not sure I see the need to hide it behind BROKEN. The reasoning behind choosing disabled by default was so that this wouldn't affect anyone unless they chose to turn it on. -Tony