Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp4317169ybc; Fri, 22 Nov 2019 00:30:52 -0800 (PST) X-Google-Smtp-Source: APXvYqwNyhgVV1C46Zkv59TVi0WSE3wU7KvEhzchHS9oDRoTPLisrs+5T6s6FWyOvU26LxK6aFHs X-Received: by 2002:a2e:7d0b:: with SMTP id y11mr6163687ljc.108.1574411452581; Fri, 22 Nov 2019 00:30:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574411452; cv=none; d=google.com; s=arc-20160816; b=FjJYmnaVudMYRu0D4LURjCZBbeGA17sjo8XQvspPSv2J+04pqMGYo0AH+7Jo7/74Ub 1FaaGwg0x/7MArpaZSeRuKKCcn4ubPjqTHYBYgxUwITPh6jopBjzuxgWbEbQSV3MpOMY VK6PupuQ77oyBNIcL6LxzwFHMBB8wnfjRxYU6GLD5tRYJBTddhHFP+pca+ph0YUhNRs8 JbruW4pNUPPRdsts3X4ZvLmFjoTAIHgNG6gwMXl22bhZU+PKrYPPTnPe0wIS3WNmcK6u P3MqaPkiGf5rGuW7Du+bcE7kIJIbN/O78HC0ere21GgsfmMfuhfbCYMsVnR9piubzS2/ QpNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=TY10CcmPrcJ8xSj7BZS6+qU+XHqyTMy7Kyu8cbr2wOU=; b=aIcxZF8/qKKExywWmB5HqCZMOxkRDbfbMPXqbS71YMcH8ZlcYBsa4hE/ZTYPDDCyC/ NZyMH9eystkI8JKKhNHq5mqSAwAgosOsP5R5zBPJNDghIdtud3YsgFweUdWa3vygllbG IvpNpsoEvalY9aEVpYZ/6+tGwPMTf3cg6c8lr3XIgaKeDDCQhhke5Wz0F8r4wrvR8AtW 6UlZn3qGWB6VHcleOLQzmgYWuxOlL1naDVbeZdhdYWMA4koxQZgy2geBo2xhTOup+Kp0 sWjvtMh4wJ8huZhwKmAqm/lhOpO5NNtsjHlrIBwFDfsymKRSC5Y/WzMSX6gAQhxHx7wk zpqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f37si4220171eda.190.2019.11.22.00.30.29; Fri, 22 Nov 2019 00:30:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727716AbfKVI0h (ORCPT + 99 others); Fri, 22 Nov 2019 03:26:37 -0500 Received: from esa3.mentor.iphmx.com ([68.232.137.180]:4485 "EHLO esa3.mentor.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726887AbfKVI0f (ORCPT ); Fri, 22 Nov 2019 03:26:35 -0500 IronPort-SDR: X8nzEv9CkszHrMqWs2Cn5Wt66os8qBWEgXHc5S4D/fXg03w4QsHvgzsD39ltMDSJQax6tKXORU Jm9G4N3OL9d/59dprwMTMvDedSqS2YIIB+mv8TqIDvdNW9v9Cgxzmkp2rhNg82IPsayIRy/Q6M uk+zRyckdLj7vLgM0ZGkkcbZ7RqhqJA6VAeiHnoEwLtkO22DcUntkVPMhgpiMu7urOl7WyZkZ/ w8mGZdea4NBM5iLVlcgPnPn3UpdrE0voxAI/i3ta3vwH74AcDAhlbtiw1a3r8kIsrcV238iQ9O u80= X-IronPort-AV: E=Sophos;i="5.69,229,1571731200"; d="scan'208";a="43419509" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 22 Nov 2019 00:26:35 -0800 IronPort-SDR: eMBpF+qqcc94Gu8//rsvd4oNWAT7u58kxzZJNGumGQxAFgxz9ba562TU+xg19KPcX+20yuVW3y e+RudaxAMODHwxU/XIRi/VJCjT2BC78p7yqkpPkC/KPZNcuPTlnlJ5v/YOkznyutbRWXMS9h5X 9+alIxLLKJe+xL/or3QebaCj+faUNBYqXmNvwHJe7CFBl+TKccspjIcR1Y6vHrSyDK+2L+sDa4 3A0B8e7cY3tj2u6njJfHIN7nwvYBPasljQMBesPSvhSVqqiMN7tKtgCBPJv2eBbkjrC7/oXanM whA= From: Jiada Wang To: , , , , CC: , , , , Subject: [PATCH v6 40/48] Input: Atmel: improve error handling in mxt_update_cfg() Date: Fri, 22 Nov 2019 17:23:54 +0900 Message-ID: <20191122082402.18173-41-jiada_wang@mentor.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191122082402.18173-1-jiada_wang@mentor.com> References: <20191122082402.18173-1-jiada_wang@mentor.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Deepak Das mxt_update_cfg() failed to propagate the error code from mxt_init_t7_power_cfg() so return the error code. Signed-off-by: Deepak Das Signed-off-by: George G. Davis Signed-off-by: Jiada Wang --- drivers/input/touchscreen/atmel_mxt_ts.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index 110c966e7f3a..92af95bd4eed 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -2186,7 +2186,9 @@ static int mxt_update_cfg(struct mxt_data *data, const struct firmware *fw) dev_info(dev, "Config successfully updated\n"); /* T7 config may have changed */ - mxt_init_t7_power_cfg(data); + ret = mxt_init_t7_power_cfg(data); + if (ret) + dev_warn(dev, "Power Config failed to update\n"); release_mem: kfree(cfg.mem); -- 2.17.1