Received: by 2002:a17:90a:88:0:0:0:0 with SMTP id a8csp4827219pja; Fri, 22 Nov 2019 02:30:26 -0800 (PST) X-Google-Smtp-Source: APXvYqyhlSITpxjcUyc/LT+NO8auDz3ENnt3CXaGFcjkn9yHvGFme5S2qio5UPV2FG2CM/L/jeV1 X-Received: by 2002:aa7:d7c5:: with SMTP id e5mr171868eds.233.1574418626190; Fri, 22 Nov 2019 02:30:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574418626; cv=none; d=google.com; s=arc-20160816; b=e8uwNPGlzRP3ZPJwBN3lHUIGNxSYuC5mmEjJXo93mYo75YsXCnCiTYu97mXputJTaN BNhmHsCRt7qcrIC93IcaknWPfGbl4VDMxazPmxYa9K6gdll3MCYTcT0sOH8Awsyothlj Ee9uDK6yiqZ6MZ0Df3+E587RFmV4f+rlHMmLTCFrZObyPh2xNSwcAkv5rNYupkYwzdX4 vIBM0HvnGD6nqfLQWVeRNJb8i7rqL2kBfhl7qJj9p8URNfMd1GCBJxhK7rnmOr/pLZ5H HFNUEDWmktYEZaHs0R2We+4Ia60rh1GsHMUP4c8/gh8arQsZKwuDAU4CTsD2lzmnWy1B zClw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:subject:from; bh=aJg/hHNBilf4w3Az3M7rlXKPTSb1tSWLKnOLmqNdWEs=; b=dpMAf3yvFJcOQl29rSeoalAd6YcdD5PaNsEte+5C8waXRq+pzGV9ELf9E36aCHz1pN jQhl5Y5UX8BTBoW4RWqHka6chIS+CTi449TgYmtMlrv9Z5Un8/bUk5y63FNcSBLKC4gB Z/4lmHLR9/LJg5AoFv0BWvKJZIm/RT7ysLKN/u3FtXXkQ85hEf5N2zLx/1OzFF88M24V kDT1Dg1qHQyoz1cUdxvD0EFexfYEXzLcgqVMkjDUVBfaqma8clL5/xkmKszmeRPeAYoy 23xTx2RZkqsuneJBiQz5Yg4OXk5ZCp/HX/x5ruTgzKSuqaQejrgFMvuFIuUDZaVvGt/Z TUFA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r6si3876405ejx.115.2019.11.22.02.30.02; Fri, 22 Nov 2019 02:30:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726613AbfKVK2x (ORCPT + 99 others); Fri, 22 Nov 2019 05:28:53 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:41825 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726100AbfKVK2x (ORCPT ); Fri, 22 Nov 2019 05:28:53 -0500 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1iY6BF-0002Iy-Qd; Fri, 22 Nov 2019 11:28:49 +0100 From: Ahmad Fatoum Subject: Re: [Linux-stm32] [PATCH v2 1/1] drivers: watchdog: stm32_iwdg: set WDOG_HW_RUNNING at probe To: Christophe Roullier , wim@linux-watchdog.org, linux@roeck-us.net, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com Cc: linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de References: <20191122082442.21695-1-christophe.roullier@st.com> Message-ID: Date: Fri, 22 Nov 2019 11:28:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191122082442.21695-1-christophe.roullier@st.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Christophe, On 11/22/19 9:24 AM, Christophe Roullier wrote: > + /* > + * In case of CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED is set > + * (Means U-Boot/bootloaders leaves the watchdog running) > + * When we get here we should make a decision to prevent > + * any side effects before user space daemon will take care of it. > + * The best option, taking into consideration that there is no > + * way to read values back from hardware, is to enforce watchdog > + * being run with deterministic values. What about the "ONF: Watchdog enable status bit" in the IWDG_SR register? Cheers Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |