Received: by 2002:a17:90a:88:0:0:0:0 with SMTP id a8csp14324pja; Fri, 22 Nov 2019 02:49:31 -0800 (PST) X-Google-Smtp-Source: APXvYqwhuDf/2sFUVBgDNNB+aXWSXCX48lI4fruHxxQtIhaMFDvSV2th+J+YpWedVFsG6u7iMA4D X-Received: by 2002:aa7:ca09:: with SMTP id y9mr244452eds.101.1574419771707; Fri, 22 Nov 2019 02:49:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574419771; cv=none; d=google.com; s=arc-20160816; b=wtew/ueGBJ0RaSvqi+f5gCcW8u4l8A7gvGu1TslDtexNFYq6mhmls0ZpMhoRRZVX05 QWO/xfw+AuCXF95EGaII9PRx2ieNZCT+k670Y/CHGF4dMk7uNeoLoHeP1aYFIyVixiUm mI70LSIPAbzyOQDGBZ/oKYF9HGuSta4W0SngV8ugD34XQMsxuZNI3r1M9nl1e+R6CVV9 O+9xoKf7RtWPJGjE6QJbr0ND27j6vcTop0l+n5YXAOGTr6xrkZFp2lT8uBUUHT0yuzCD R0kE+Bgf+Rv7YYLaxqPhPMfyrGU8a/4emLDhpLXaUF9ewBbgj9DvKCTXIQC0sYYyTvs+ KbQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DgS2RDiFS8T+O1KN2gsaSxHkbP16eptwf8wcDqEN8/k=; b=mlOnNeuAQMeUWpHyEsdlFuXNxAo49lXDo8P0+QY5UfZS7rkwXaAynzykiTWcgeQQbx cAqKcWJg4E7rAZkLqlH1OH5EkbHVULnNOVgDefs44UI4/1te46eFvNmu6iJe9v6Ha5fy d4QM37xq2KKf4pJ7TNLsOg1fA6WWjJT/A8/FbZGW9Xto1+2nKEJC29isOIAP+uJ3TywD zL2THRxzar34JbgdnFvLlrhyGdCt87LTJxA3BluzAABCruJ5qAe+123H/zQBNxokkp7C ReTyafLE7kH0Lw6cdW3w1YksMcxvfuvswAWNTflKqbN/Z5y9ZaKsTcqdIlsdwBun6cQP LATQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="lHvr2G/Y"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x1si4422508eda.105.2019.11.22.02.49.08; Fri, 22 Nov 2019 02:49:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="lHvr2G/Y"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728061AbfKVKpV (ORCPT + 99 others); Fri, 22 Nov 2019 05:45:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:51574 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727978AbfKVKpT (ORCPT ); Fri, 22 Nov 2019 05:45:19 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5812620718; Fri, 22 Nov 2019 10:45:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574419518; bh=wg46qknz9Hf2607OK9IVon7QRzTj/a1p1YRAecuuMHk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lHvr2G/Y1GRHuRdnWWfQVOFizn8FPgMsPkpnTi0h9dqTl+/0DtLGN7LQgfIbw5iHc xk3fi0YhFcvdSvJQB2KDu5ossWFeHppYTIFQ9dCu3I1CEPIctO91Z/j5CFGKIJ1QiY F2tlp/drvrj5IHHMwLZ2icD9Cpi7/2/Iiqf/MyTY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michael Schmitz , Finn Thain , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.9 139/222] scsi: NCR5380: Handle BUS FREE during reselection Date: Fri, 22 Nov 2019 11:27:59 +0100 Message-Id: <20191122100912.901414049@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191122100830.874290814@linuxfoundation.org> References: <20191122100830.874290814@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Finn Thain [ Upstream commit ca694afad707cb3ae2fdef3b28454444d9ac726e ] The X3T9.2 specification (draft) says, under "6.1.4.2 RESELECTION time-out procedure", that a target may assert RST or go to BUS FREE phase if the initiator does not respond within 200 us. Something like this has been observed with AztecMonster II target. When it happens, all we can do is wait for the target to try again. Tested-by: Michael Schmitz Signed-off-by: Finn Thain Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/NCR5380.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c index 03f9ddbc37fbb..27270631c70c2 100644 --- a/drivers/scsi/NCR5380.c +++ b/drivers/scsi/NCR5380.c @@ -2133,6 +2133,9 @@ static void NCR5380_reselect(struct Scsi_Host *instance) if (NCR5380_poll_politely(instance, STATUS_REG, SR_REQ, SR_REQ, 2 * HZ) < 0) { + if ((NCR5380_read(STATUS_REG) & (SR_BSY | SR_SEL)) == 0) + /* BUS FREE phase */ + return; shost_printk(KERN_ERR, instance, "reselect: REQ timeout\n"); do_abort(instance); return; -- 2.20.1