Received: by 2002:a17:90a:88:0:0:0:0 with SMTP id a8csp18147pja; Fri, 22 Nov 2019 02:53:11 -0800 (PST) X-Google-Smtp-Source: APXvYqz+ji+X0tSXsK/l//qfeaZv/10TyGSSbR8hXBogYF3/U89/o/mckt6eMAQNpgVseruq1Go+ X-Received: by 2002:a50:978f:: with SMTP id e15mr258023edb.298.1574419991684; Fri, 22 Nov 2019 02:53:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574419991; cv=none; d=google.com; s=arc-20160816; b=g3Q0gex2CncznWjhucdKmpbLVwAZzh29B7ge7T9vRV5mHRGjx9qN3aCTcqsyK4IGTC ZqnnJ7UkV3mRVnWPoSfoOeYcA0VttUViTSip0wxVUX/bjtOexyXN2qLqRmNU68SczW8Z 4zrO9UVMY50Z129x9h3BqBKxC/c31zkM3SvJwkgutk7q4j7nVSAL/kt+1L1nr54sSZzs QXW9unFkf64vh6uimDoVOG3wA4GyhrVIFB5xA4grAX97kFh9HnedFiTi8mniB9g/tQka X1BGpzjrQ3p8BvcmAlEWQTGGa16eUS8XtQu8kpSOTKilR9wL4F4xC0XPLUvkjssSKm0C Qa1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hT/UzDayUvwhanHRwVWCs+xP69ncbfW2J5SmZPyvfzs=; b=j73cyHZIeKdjsJ+2/HKyGgwM33qEwvzqTs5MjYosQeLpSqgOGHRWVzmJ15m0TZJnTC iIRbdo7Ljy8ngj2WjXUJyo/H4Y1mYMGRK69twd2ykbY2ZPb9wnl3lHYpJb8LamoQigUG 2j9wyErVuFwcpXKlot41lPIzsqnHFsXFRfZ9UspHYSnDKOyu3GNgLLJ345b7a4f3xlHU 2FaUL4ZdtelyoRYyDys+KvwD3phYvNANo2kwZrmPD9G4PWP7EOZ8pspOkWSJLTVosoNO Tj3I4OTOdBtD+u3iaD3XO07gLqdid7HlLO1pUdEx5Jd1ULfGqLN+1MmXMuAXeqPk3dqD LueQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bdTi89Nq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id va7si483188ejb.18.2019.11.22.02.52.46; Fri, 22 Nov 2019 02:53:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bdTi89Nq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727544AbfKVKtm (ORCPT + 99 others); Fri, 22 Nov 2019 05:49:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:59138 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729540AbfKVKth (ORCPT ); Fri, 22 Nov 2019 05:49:37 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 92E5220656; Fri, 22 Nov 2019 10:49:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574419777; bh=7jmaLZ+hrUZZxUmiRO0qSUqbgKSq96bs8xMAOPC8FKM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bdTi89NqkiiSO05QW91383OXPpk9LOW7ltU+54j8NSbmeP22y5FzDIwFQ0cjbnXbL 7KxGq7rYMHB8rICze2/qgy+Y9qbCBbD1p+BsT5m8pXa7tCCuBCl7D/LdIbG1bXE1Gu A70kdfAg/8YBsfDyzaLk4+Ioo4kU1eXfn/ULGaNg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, zhong jiang , Andrew Donnellan , Frederic Barrat , Sasha Levin Subject: [PATCH 4.9 218/222] misc: cxl: Fix possible null pointer dereference Date: Fri, 22 Nov 2019 11:29:18 +0100 Message-Id: <20191122100918.319643938@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191122100830.874290814@linuxfoundation.org> References: <20191122100830.874290814@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: zhong jiang [ Upstream commit 3dac3583bf1a61db6aaf31dfd752c677a4400afd ] It is not safe to dereference an object before a null test. It is not needed and just remove them. Ftrace can be used instead. Signed-off-by: zhong jiang Acked-by: Andrew Donnellan Acked-by: Frederic Barrat Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/misc/cxl/guest.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c index 3e102cd6ed914..d08509cd978a4 100644 --- a/drivers/misc/cxl/guest.c +++ b/drivers/misc/cxl/guest.c @@ -1026,8 +1026,6 @@ int cxl_guest_init_afu(struct cxl *adapter, int slice, struct device_node *afu_n void cxl_guest_remove_afu(struct cxl_afu *afu) { - pr_devel("in %s - AFU(%d)\n", __func__, afu->slice); - if (!afu) return; -- 2.20.1